Page MenuHomePhabricator

Move Phabricator to use PhutilBinaryAnalyzer and show binary versions
ClosedPublic

Authored by epriestley on Jul 31 2017, 7:23 PM.

Details

Summary

Fixes T12942.

  • Adds binary version and path information to ConfigVersion Information.
  • Replaces old code all over the place with new consolidated code.
Test Plan

Screen Shot 2017-07-31 at 12.14.42 PM.png (341×777 px, 101 KB)

Also faked some cases of missing binaries, bad versions, etc.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

(Build just fails because this depends on D18305.)

This revision is now accepted and ready to land.Jul 31 2017, 7:31 PM
This revision was automatically updated to reflect the committed changes.
This comment was removed by alexnb.

Neither this change nor D18305 are on stable. If you encountered an issue, you're probably mixing stable and master.

I am sorry, my phabricator was on master. Unfortunately I use git only for phabricator maintenance, resulting in such confusion.