Page MenuHomePhabricator

When "mysqli->real_connect()" fails without setting an error code, recover more gracefully
ClosedPublic

Authored by epriestley on Sep 3 2019, 7:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 8:04 AM
Unknown Object (File)
Sun, Feb 9, 8:04 AM
Unknown Object (File)
Sun, Feb 9, 8:04 AM
Unknown Object (File)
Fri, Feb 7, 7:46 AM
Unknown Object (File)
Sun, Feb 2, 5:24 PM
Unknown Object (File)
Thu, Jan 30, 8:34 PM
Unknown Object (File)
Sun, Jan 26, 3:04 PM
Unknown Object (File)
Sun, Jan 26, 6:25 AM
Subscribers
None

Details

Summary

Depends on D20779. Ref T13403. Bad parameters may cause this call to fail without setting an error code; if it does, catch the issue and go down the normal connection error pathway.

Test Plan
  • With "mysql.port" set to "quack", ran bin/storage probe.
  • Before: wild mess of warnings as the code continued below and failed when trying to interact with the connection.
  • After: clean connection failure with a useful error message.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable