Page MenuHomePhabricator

When "mysqli->real_connect()" fails without setting an error code, recover more gracefully
ClosedPublic

Authored by epriestley on Sep 3 2019, 7:23 PM.
Tags
None
Referenced Files
F15391185: D20780.id49547.diff
Sat, Mar 15, 8:34 AM
F15292660: D20780.id49547.diff
Wed, Mar 5, 2:43 AM
Unknown Object (File)
Fri, Feb 21, 11:48 PM
Unknown Object (File)
Thu, Feb 20, 1:07 AM
Unknown Object (File)
Wed, Feb 19, 2:17 PM
Unknown Object (File)
Feb 9 2025, 8:04 AM
Unknown Object (File)
Feb 9 2025, 8:04 AM
Unknown Object (File)
Feb 9 2025, 8:04 AM
Subscribers
None

Details

Summary

Depends on D20779. Ref T13403. Bad parameters may cause this call to fail without setting an error code; if it does, catch the issue and go down the normal connection error pathway.

Test Plan
  • With "mysql.port" set to "quack", ran bin/storage probe.
  • Before: wild mess of warnings as the code continued below and failed when trying to interact with the connection.
  • After: clean connection failure with a useful error message.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable