Page MenuHomePhabricator

When "mysqli->real_connect()" fails without setting an error code, recover more gracefully
ClosedPublic

Authored by epriestley on Sep 3 2019, 7:23 PM.
Tags
None
Referenced Files
F19562531: D20780.diff
Sat, Jan 31, 2:28 PM
F19550777: D20780.diff
Wed, Jan 28, 3:46 AM
F19510397: D20780.diff
Sun, Jan 11, 8:56 AM
F19508217: D20780.diff
Sat, Jan 10, 2:15 AM
F19066678: D20780.diff
Nov 30 2025, 5:55 AM
F19059074: D20780.id49547.diff
Nov 29 2025, 4:13 AM
F18876828: D20780.diff
Nov 6 2025, 3:53 AM
F18854737: D20780.id.diff
Nov 1 2025, 12:31 AM
Subscribers
None

Details

Summary

Depends on D20779. Ref T13403. Bad parameters may cause this call to fail without setting an error code; if it does, catch the issue and go down the normal connection error pathway.

Test Plan
  • With "mysql.port" set to "quack", ran bin/storage probe.
  • Before: wild mess of warnings as the code continued below and failed when trying to interact with the connection.
  • After: clean connection failure with a useful error message.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable