Page MenuHomePhabricator

Make "phabricator.silent" disable build steps which rely on external services
ClosedPublic

Authored by epriestley on Feb 14 2018, 7:36 PM.

Details

Summary

Depends on D19084. Fixes T13078. When phabricator.silent is enabled, immediately fail the "HTTP Request", "CircleCI" and "Buildkite" build steps.

This doesn't feel quite as clean as most of the other behavior of phabricator.silent, since these calls are not exactly notifications in the same way that email is, and failing to make these calls means that builds run differently (whereas failing to deliver email doesn't really do anything).

However, I suspect that this behavior is almost always reasonable/correct, and that we can probably get away with it until this grey area between "notifications" and "external service calls" is more clearly defined.

Test Plan
  • Created a build with HTTP, CircleCI, and Buildkite steps.
  • Put install in phabricator.silent mode: all three steps failed with "declining, because silent" messages.
  • Put install back in normal mode: all three steps made HTTP requests.
  • Read updated documentation.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 14 2018, 7:36 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 14 2018, 7:41 PM
This revision was automatically updated to reflect the committed changes.