Paths

Table of Contentst

Differential D20781

Use the "@" operator to silence connection retry messages if initializing the stack with database config optional
ClosedPublic
Actions

Authored by epriestley on Sep 3 2019, 7:26 PM.

Tags

None

Referenced Files

	F18112291: D20781.diff
	Tue, Aug 12, 4:19 PM

	F17947695: D20781.id.diff
	Thu, Jul 31, 6:01 PM

	F17926700: D20781.diff
	Wed, Jul 30, 1:32 PM

	F17816906: D20781.id49552.diff
	Fri, Jul 25, 11:10 PM

	F17769896: D20781.id.diff
	Jul 23 2025, 9:04 AM

	F17760051: D20781.diff
	Jul 22 2025, 7:10 PM

	F17608478: D20781.id49548.diff
	Jul 9 2025, 4:45 AM

	Unknown Object (File)
	Jun 20 2025, 2:31 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues
Commits: rPe0d6994adb1c: Use the "@" operator to silence connection retry messages if initializing the…

Summary

Depends on D20780. Ref T13403. During initial setup, it's routine to run "bin/config" with a bad database config. We start the stack in "config optional" mode to anticipate this.

However, even in this mode, we may emit warnings if the connection fails in certain ways. These warnings aren't useful; suppress them with "@".

(Possibly this message should move from "phlog()" to "--trace" at some point, but it has a certain amount of context/history around it.)

Test Plan

Configured MySQL to fail with a retryable error, e.g. good host but bad port.
Ran bin/config set ....
Before: saw retry warnings on stderr.
After: no retry warnings on stderr.
(Turned off suppression code artificially and verified warnings still appear under normal startup.)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 3 2019, 7:26 PM

Harbormaster completed remote builds in B23374: Diff 49548.Sep 3 2019, 7:28 PM

epriestley requested review of this revision.Sep 3 2019, 7:28 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 3 2019, 7:54 PM

Closed by commit rPe0d6994adb1c: Use the "@" operator to silence connection retry messages if initializing the… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPe0d6994adb1c: Use the "@" operator to silence connection retry messages if initializing the….

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

env/

PhabricatorEnv.php

14 lines

storage/

connection/

mysql/

AphrontBaseMySQLDatabaseConnection.php

9 lines

Diff 49552

src/infrastructure/env/PhabricatorEnv.php

Loading...

src/infrastructure/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php

Loading...