Page MenuHomePhabricator

Make the success message from "bin/config" more clear
ClosedPublic

Authored by epriestley on Aug 12 2019, 6:22 PM.
Tags
None
Referenced Files
F15539923: D20711.id49391.diff
Fri, Apr 25, 6:00 AM
F15522336: D20711.diff
Sun, Apr 20, 7:45 PM
F15512848: D20711.id49391.diff
Thu, Apr 17, 2:31 PM
F15492859: D20711.id49391.diff
Sat, Apr 12, 7:01 PM
F15485243: D20711.id49388.diff
Wed, Apr 9, 10:50 PM
F15469124: D20711.id.diff
Apr 4 2025, 9:25 AM
F15468209: D20711.diff
Apr 3 2025, 9:36 PM
F15408682: D20711.diff
Mar 19 2025, 12:47 AM
Subscribers
None

Details

Summary

Ref T13373. When you "bin/config set x ..." a value, the success message ("Set x ...") is somewhat ambiguous and can be interpreted as "First, you need to set x..." rather than "Success, wrote x...".

Make the messaging more explicit. Also make this string more translatable.

Test Plan

Ran bin/config set ... with various combinations of flags, saw more clear messaging.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2019, 7:50 PM
This revision was automatically updated to reflect the committed changes.