Page MenuHomePhabricator

Make the success message from "bin/config" more clear
ClosedPublic

Authored by epriestley on Aug 12 2019, 6:22 PM.

Details

Summary

Ref T13373. When you "bin/config set x ..." a value, the success message ("Set x ...") is somewhat ambiguous and can be interpreted as "First, you need to set x..." rather than "Success, wrote x...".

Make the messaging more explicit. Also make this string more translatable.

Test Plan

Ran bin/config set ... with various combinations of flags, saw more clear messaging.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Aug 12 2019, 6:22 PM
epriestley requested review of this revision.Aug 12 2019, 6:23 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2019, 7:50 PM
This revision was automatically updated to reflect the committed changes.