Page MenuHomePhabricator
Feed Advanced Search

Mar 29 2019

epriestley archived Profile Menu Item.
Mar 29 2019, 4:34 PM

Mar 27 2019

epriestley closed T12167: Unable to edit menu items on mobile as Resolved by committing rP6bb9d3ac67a1: Allow users to add "ProfileMenu" items on mobile.
Mar 27 2019, 11:06 PM · Profile Menu Item, Bug Report
epriestley closed T12745: Conpherence menu item is available for creation even if Conpherence is not installed as Resolved by committing rP6648942bc885: Don't allow "Conpherence" menu items to be added to editable menus if….
Mar 27 2019, 11:01 PM · Profile Menu Item, Customer Impact
epriestley added a revision to T12167: Unable to edit menu items on mobile: D20338: Allow users to add "ProfileMenu" items on mobile.
Mar 27 2019, 9:12 PM · Profile Menu Item, Bug Report
epriestley claimed T12167: Unable to edit menu items on mobile.
Mar 27 2019, 9:09 PM · Profile Menu Item, Bug Report
epriestley added a comment to T12745: Conpherence menu item is available for creation even if Conpherence is not installed.

(Sorry, typo'd my own name into another @ep....)

Mar 27 2019, 6:29 PM · Profile Menu Item, Customer Impact
epriestley claimed T12745: Conpherence menu item is available for creation even if Conpherence is not installed.
Mar 27 2019, 6:28 PM · Profile Menu Item, Customer Impact
epriestley reassigned T12745: Conpherence menu item is available for creation even if Conpherence is not installed from chad to epramono.
Mar 27 2019, 6:28 PM · Profile Menu Item, Customer Impact
epriestley added a revision to T12745: Conpherence menu item is available for creation even if Conpherence is not installed: D20337: Don't allow "Conpherence" menu items to be added to editable menus if Conpherence is not installed.
Mar 27 2019, 6:27 PM · Profile Menu Item, Customer Impact

Feb 16 2019

epriestley closed T12165: Maybe add a (fullscreen workboard) menu item or URL for link as Wontfix.

It sounds like real-time updates will more-or-less moot this.

Feb 16 2019, 1:39 PM · Workboards, Profile Menu Item

Dec 23 2017

epriestley closed T13033: Disabling both "Workboard" and "Project Details" causes project's /tag/ProjectName url to fatal as Resolved by committing rP84cf49387984: Allow "Manage" to be the default menu item for projects.
Dec 23 2017, 7:37 PM · Profile Menu Item, Projects
epriestley added a revision to T13033: Disabling both "Workboard" and "Project Details" causes project's /tag/ProjectName url to fatal: D18843: Allow "Manage" to be the default menu item for projects.
Dec 23 2017, 4:44 PM · Profile Menu Item, Projects

Dec 22 2017

20after4 added a comment to T13033: Disabling both "Workboard" and "Project Details" causes project's /tag/ProjectName url to fatal.

D18836 probably isn't the right solution, however, it's the only straightforward fix I could come up with. I didn't dig into the details of why it 404s when I fix the code in PhabricatorProjectViewController to avoid the fatal. The patch is probably good enough for Wikimedia, however, I'm not sure if it's good enough for upstream.

Dec 22 2017, 3:26 PM · Profile Menu Item, Projects
20after4 added projects to T13033: Disabling both "Workboard" and "Project Details" causes project's /tag/ProjectName url to fatal: Projects, Profile Menu Item.
Dec 22 2017, 3:10 PM · Profile Menu Item, Projects

Dec 7 2017

lpriestley added a revision to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one: D18821: WIP Menu item that is a link to a state of a builtin menu item should display consistent selection behavior.
Dec 7 2017, 10:18 PM · Dashboards

Nov 23 2017

aik099 added a comment to T12098: Create Revision from FavoritesMenuItem doesn't work.

Obviously not a particularly important issue, but this now will populate a link in the favorites menu which leads to an exception:

Screen Shot 2017-11-22 at 10.31.09 PM.png (559×1 px, 48 KB)

Nov 23 2017, 7:28 AM · Dashboards, Differential
sshannin added a comment to T12098: Create Revision from FavoritesMenuItem doesn't work.

Obviously not a particularly important issue, but this now will populate a link in the favorites menu which leads to an exception:

Screen Shot 2017-11-22 at 10.31.09 PM.png (559×1 px, 48 KB)

Nov 23 2017, 3:33 AM · Dashboards, Differential

Aug 22 2017

chad added a comment to T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out.

Somewhat related, if you have a disabled "Home" as your top item, we still show that regardless of the active dashboard below it.

Aug 22 2017, 10:23 PM · Policy, Dashboards, Bug Report

Aug 10 2017

epriestley added a comment to T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out.

T12956 has another situation where letting MenuItem generate 2+ items may be bad: we want to let a menu item steal the selection, but it's muddy to implement if each MenuItem can return several actual views.

Aug 10 2017, 1:38 PM · Policy, Dashboards, Bug Report

Aug 5 2017

rfreebern added a revision to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one: D18346: Override project nav menu filter if link item matching URI exists.
Aug 5 2017, 2:15 PM · Dashboards
chad added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

remind me to add some more icons for Link.

Aug 5 2017, 12:51 AM · Dashboards
chad added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

That looks pretty hawt.

Aug 5 2017, 12:50 AM · Dashboards

Aug 4 2017

epriestley added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

Happy to take a look if you found a reasonable way to get access to $request. If you're reading $_REQUEST['__path__'] directly or something though the eventual upstream version probably won't look too similar.

Aug 4 2017, 7:51 PM · Dashboards
rfreebern added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

I've written a patch to make this work for the project sidebar nav for my organization's install. I don't want to take up your time with it if it's not helpful, but let me know if you'd like me to push a diff.

Aug 4 2017, 7:36 PM · Dashboards

Aug 2 2017

chad edited projects for T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one, added: Profile Menu Item; removed Workboards.
Aug 2 2017, 5:19 PM · Dashboards

Jul 27 2017

epriestley closed T12136: What to do with "Application Counts" with MenuItem, a subtask of T11957: Add MenuEngine to Home, as Wontfix.
Jul 27 2017, 4:42 PM · Profile Menu Item, Dashboards
epriestley closed T12136: What to do with "Application Counts" with MenuItem as Wontfix.

Dropping these doesn't seem to have caused any major pushback.

Jul 27 2017, 4:42 PM · Profile Menu Item
epriestley closed T12208: Collapsable Menu Item as Resolved.

This presumably counts as "not much interest" or should move to Discourse now or something, maybe.

Jul 27 2017, 4:32 PM · Profile Menu Item
epriestley merged T12308: Access forbidden on homepage if the first dashboard in menu is not visible to user into T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out.
Jul 27 2017, 4:25 PM · Policy, Dashboards, Bug Report
epriestley merged task T12308: Access forbidden on homepage if the first dashboard in menu is not visible to user into T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out.
Jul 27 2017, 4:25 PM · Dashboards, Profile Menu Item, Bug Report

Jul 9 2017

chad removed the image for Profile Menu Item.
Jul 9 2017, 7:41 PM

Jun 26 2017

epriestley lowered the priority of T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out from Normal to Low.

For private reasons affecting the reporting install, this no longer has customer impact.

Jun 26 2017, 2:02 PM · Policy, Dashboards, Bug Report

Jun 23 2017

epriestley triaged T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out as Normal priority.
Jun 23 2017, 7:16 PM · Policy, Dashboards, Bug Report

May 30 2017

neilfitz added a comment to T12423: Bring MenuItem customization options to User Profiles.

Thanks! That should be perfect.

May 30 2017, 9:17 PM · Dashboards, Restricted Project, Profile
chad added a revision to T12423: Bring MenuItem customization options to User Profiles: D18046: Group Maniphest Tasks by Priority on Profiles.
May 30 2017, 9:13 PM · Dashboards, Restricted Project, Profile
chad added a comment to T12423: Bring MenuItem customization options to User Profiles.

Possibly also, add a "See All" link to ApplicationSearch

May 30 2017, 8:53 PM · Dashboards, Restricted Project, Profile
chad added a comment to T12423: Bring MenuItem customization options to User Profiles.

Sounds reasonable to just improve that.

May 30 2017, 8:52 PM · Dashboards, Restricted Project, Profile
neilfitz added a project to T12423: Bring MenuItem customization options to User Profiles: Restricted Project.

Hey, we're also interested in this by way of T12545 (which was merged in above). A couple of our teams have historically assigned their oncall/tech-debt tasks to a mailing list user, and used the priority-sorted view of those tasks to run their oncall shifts. That workflow no longer works with the reverse-chronological sort.

May 30 2017, 8:44 PM · Dashboards, Restricted Project, Profile

May 23 2017

chad moved T12745: Conpherence menu item is available for creation even if Conpherence is not installed from Backlog to Nits on the Customer Impact board.
May 23 2017, 9:17 PM · Profile Menu Item, Customer Impact
epriestley added a comment to T12745: Conpherence menu item is available for creation even if Conpherence is not installed.

I've been busy with important emoji research.

May 23 2017, 6:11 PM · Profile Menu Item, Customer Impact
chad added a comment to T12745: Conpherence menu item is available for creation even if Conpherence is not installed.

Hows Nuance coming?

May 23 2017, 6:10 PM · Profile Menu Item, Customer Impact
epriestley added a comment to T12745: Conpherence menu item is available for creation even if Conpherence is not installed.

sorry maybe I am supposed to use these now 😱 😱 😱 😱

May 23 2017, 6:05 PM · Profile Menu Item, Customer Impact
epriestley added a comment to T12745: Conpherence menu item is available for creation even if Conpherence is not installed.

We un-install it on admin.phacility.com. :) :) :) :)

May 23 2017, 6:03 PM · Profile Menu Item, Customer Impact
chad added a comment to T12745: Conpherence menu item is available for creation even if Conpherence is not installed.

Hmm, we shouldn't allow Dashboards to be un-installed.

May 23 2017, 5:52 PM · Profile Menu Item, Customer Impact
epriestley added a comment to T12745: Conpherence menu item is available for creation even if Conpherence is not installed.

(The "Dashboard" item may also be affected.)

May 23 2017, 5:50 PM · Profile Menu Item, Customer Impact
chad claimed T12745: Conpherence menu item is available for creation even if Conpherence is not installed.
May 23 2017, 5:13 PM · Profile Menu Item, Customer Impact
epriestley created T12745: Conpherence menu item is available for creation even if Conpherence is not installed.
May 23 2017, 5:01 PM · Profile Menu Item, Customer Impact

May 21 2017

chad added a revision to T12423: Bring MenuItem customization options to User Profiles: D17987: Add Revisions to User Profiles.
May 21 2017, 12:07 AM · Dashboards, Restricted Project, Profile

May 10 2017

chad merged T12700: Bring back diff results from the user page into T12423: Bring MenuItem customization options to User Profiles.
May 10 2017, 2:34 AM · Dashboards, Restricted Project, Profile

Apr 12 2017

epriestley merged T12545: People > Assigned Tasks are not ordered by priority into T12423: Bring MenuItem customization options to User Profiles.
Apr 12 2017, 5:28 PM · Dashboards, Restricted Project, Profile

Apr 11 2017

nfirmani added a comment to T12423: Bring MenuItem customization options to User Profiles.

Awesome, makes total sense to move this towards a customization of user profiles task. Thanks!

Apr 11 2017, 8:22 PM · Dashboards, Restricted Project, Profile
chad added a comment to T12423: Bring MenuItem customization options to User Profiles.

I'm going to just repurpose this into a general "allow installs to customize user profiles" task to broaden interest.

Apr 11 2017, 7:24 PM · Dashboards, Restricted Project, Profile
chad renamed T12423: Bring MenuItem customization options to User Profiles from Add link for Revisions back to profile pages to Bring MenuItem customization options to User Profiles.
Apr 11 2017, 7:23 PM · Dashboards, Restricted Project, Profile

Mar 23 2017

chad triaged T12165: Maybe add a (fullscreen workboard) menu item or URL for link as Normal priority.
Mar 23 2017, 6:40 PM · Workboards, Profile Menu Item

Mar 22 2017

chad closed T12174: Home Menu Errata as Resolved.

I think most everything here is complete and will file individual follow up tasks if needed.

Mar 22 2017, 12:48 AM · Dashboards (v2), Profile Menu Item

Mar 16 2017

rkettelerij added a comment to T12165: Maybe add a (fullscreen workboard) menu item or URL for link.

Currently the workboard has an option for fullscreen display. However this setting is lost when the browser refreshes. Since we're using Chrome + a Chrome autorefresh extension (SuperAutoRefresh) to display a Phabricator workboard on a bigscreen TV it would be useful if this setting is persisted across refreshes. Like ?fullscreen=yes as suggested.

Mar 16 2017, 7:48 AM · Workboards, Profile Menu Item

Mar 15 2017

chad closed T12264: Install Dashboard to Home / Favorites / Project as Resolved.

Resolved enough, unclear any benefit to installing to Favorites and Projects needs additional work to make it truly useful.

Mar 15 2017, 6:17 PM · Profile Menu Item, Dashboards (v2)

Mar 12 2017

chad added a revision to T12264: Install Dashboard to Home / Favorites / Project: D17492: Basic "Install Dashboard" workflow.
Mar 12 2017, 5:13 AM · Profile Menu Item, Dashboards (v2)

Mar 2 2017

urzds added a comment to T12174: Home Menu Errata.
In T12174#213854, @chad wrote:

It's not hard to add, just curious what the use case is. Most requests have been to "rename" the applications (Differential -> Code Review"), so pulling in built-in tooltips didn't make sense. Maybe we should add tooltip to the "Link" menu type for best flexibility.

Mar 2 2017, 12:44 PM · Dashboards (v2), Profile Menu Item

Mar 1 2017

rphl added a comment to T12174: Home Menu Errata.

thanks for the hint

Mar 1 2017, 10:50 PM · Dashboards (v2), Profile Menu Item
chad added a comment to T12174: Home Menu Errata.

Though I guess we need the icon typeahead there.

Mar 1 2017, 10:48 PM · Dashboards (v2), Profile Menu Item
chad added a comment to T12174: Home Menu Errata.

Alternatively, use "Link" and make whatever you want.

Mar 1 2017, 10:48 PM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12174: Home Menu Errata.

That's the default behavior, and you can achieve it by deleting "Name":

Mar 1 2017, 10:47 PM · Dashboards (v2), Profile Menu Item
rphl added a comment to T12174: Home Menu Errata.

It would be nice if we could have tooltips for Apps, etc. too

Mar 1 2017, 10:45 PM · Dashboards (v2), Profile Menu Item
chad merged T12339: Dashboard show odd header at the bottom of the screen into T12174: Home Menu Errata.
Mar 1 2017, 10:32 PM · Dashboards (v2), Profile Menu Item
chad updated the task description for T12174: Home Menu Errata.
Mar 1 2017, 10:32 PM · Dashboards (v2), Profile Menu Item
chad added a comment to T12174: Home Menu Errata.

You can now add tooltips adhoc to "Link" menu items.

Mar 1 2017, 7:58 PM · Dashboards (v2), Profile Menu Item
chad added a revision to T12174: Home Menu Errata: D17437: Add a tooltip option to Link menu items.
Mar 1 2017, 7:07 PM · Dashboards (v2), Profile Menu Item
cspeckmim added a comment to T12174: Home Menu Errata.

Add catfacts tooltip to each application?

Mar 1 2017, 3:38 PM · Dashboards (v2), Profile Menu Item
chad added a comment to T12174: Home Menu Errata.

It's not hard to add, just curious what the use case is. Most requests have been to "rename" the applications (Differential -> Code Review"), so pulling in built-in tooltips didn't make sense. Maybe we should add tooltip to the "Link" menu type for best flexibility.

Mar 1 2017, 3:37 PM · Dashboards (v2), Profile Menu Item
urzds added a comment to T12174: Home Menu Errata.
In T12174#213852, @chad wrote:

That's expected. When you customize the name, the built-in data (name, tooltip) goes away.

Mar 1 2017, 3:35 PM · Dashboards (v2), Profile Menu Item
chad added a comment to T12174: Home Menu Errata.

That's expected. When you customize the name, the built-in data (name, tooltip) goes away.

Mar 1 2017, 3:21 PM · Dashboards (v2), Profile Menu Item
urzds added a comment to T12174: Home Menu Errata.

I just noticed that that tooltips behave unexpectedly for application entries in the menu: When the application has no "Name", the default name is displayed as well as a tooltip on mouse-over. When I set a custom "Name", only that name is displayed and the tooltip is no longer displayed.

Mar 1 2017, 3:19 PM · Dashboards (v2), Profile Menu Item

Feb 22 2017

chad added a project to T12308: Access forbidden on homepage if the first dashboard in menu is not visible to user: Dashboards.
Feb 22 2017, 9:38 PM · Dashboards, Profile Menu Item, Bug Report
cspeckmim added a comment to T12308: Access forbidden on homepage if the first dashboard in menu is not visible to user.

In my scenario the external companies would not see eachother's tasks (separate Spaces), nor other internal items (default Space). However the developers within my company would need to see things from across multiple Spaces.

Feb 22 2017, 4:30 PM · Dashboards, Profile Menu Item, Bug Report
chad added a comment to T12308: Access forbidden on homepage if the first dashboard in menu is not visible to user.

Yeah, but I still want Spaces to be "hard walls" around content. If it's just some minor dashboard permissions, it might be overkill (ie, they both need to see same tasks).

Feb 22 2017, 4:12 PM · Dashboards, Profile Menu Item, Bug Report
cspeckmim added a comment to T12308: Access forbidden on homepage if the first dashboard in menu is not visible to user.

Do these dashboards contain sensitive information?

For the use-case I was trying to outline in T9501, this would be the case. We work with a handful of external companies and use Phabricator for organizing and communicating work. We also use Phabricator for our code review. Each project with external company (People, Projects, Maniphest) is organized into separate Spaces so that they are fully isolated, and we have a default space for internal use for Diffusion/Differential. Ideally when a user from Company A logs in they would land on a dashboard that shows only the Projects/Maniphest for them, while Company B user logs in and only shows the Projects/Maniphest for them.

Feb 22 2017, 3:42 PM · Dashboards, Profile Menu Item, Bug Report
dtf added a comment to T12308: Access forbidden on homepage if the first dashboard in menu is not visible to user.
In T12308#212972, @chad wrote:

Do these dashboards contain sensitive information?

Feb 22 2017, 3:26 PM · Dashboards, Profile Menu Item, Bug Report
chad added a project to T12308: Access forbidden on homepage if the first dashboard in menu is not visible to user: Profile Menu Item.
Feb 22 2017, 3:24 PM · Dashboards, Profile Menu Item, Bug Report

Feb 19 2017

cspeckmim added a comment to T12174: Home Menu Errata.

Just tested this out with having global menu items of Create Task forms and Projects, each which are only visible based on some policy - looks to not have any issues hiding/showing based on those policies. Thanks for all this, when I get these changes into production install I'll check for feedback but I'm anticipating it will be a smoother experience for everyone.

Feb 19 2017, 5:18 PM · Dashboards (v2), Profile Menu Item

Feb 18 2017

chad added a comment to T12202: Upgrade Guide: Home Menu Items.

I'm probably going to add a note to the dashboard dialog explaining home special casing better

Feb 18 2017, 3:15 AM · Guides, Installing & Upgrading, Profile Menu Item
epriestley closed T12202: Upgrade Guide: Home Menu Items as Resolved.

This has been live for a couple of weeks and I don't think we've seen too much confusion from users.

Feb 18 2017, 2:25 AM · Guides, Installing & Upgrading, Profile Menu Item

Feb 14 2017

chad created T12264: Install Dashboard to Home / Favorites / Project.
Feb 14 2017, 10:28 PM · Profile Menu Item, Dashboards (v2)
chad removed a project from T12136: What to do with "Application Counts" with MenuItem: Dashboards (v2).
Feb 14 2017, 10:16 PM · Profile Menu Item

Feb 13 2017

chad closed T12128: Favorites Menu Errata as Resolved.

Seems functional.

Feb 13 2017, 11:55 PM · Profile Menu Item

Feb 10 2017

chad updated the task description for T12174: Home Menu Errata.
Feb 10 2017, 5:07 PM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12167: Unable to edit menu items on mobile.

Oh we already had one of these

Feb 10 2017, 5:05 PM · Profile Menu Item, Bug Report
epriestley updated the task description for T12174: Home Menu Errata.
Feb 10 2017, 4:59 PM · Dashboards (v2), Profile Menu Item
chad moved T12136: What to do with "Application Counts" with MenuItem from Backlog to v2 on the Dashboards board.
Feb 10 2017, 4:36 AM · Profile Menu Item
chad moved T12174: Home Menu Errata from Backlog to v2 on the Dashboards board.
Feb 10 2017, 4:36 AM · Dashboards (v2), Profile Menu Item

Feb 9 2017

jdforrester added a comment to T12165: Maybe add a (fullscreen workboard) menu item or URL for link.

This would be helpful; post-T4900: Workboards updating in real time this would let the workboard be a broadcast mechanism of progress on an office screen, for instance.

Feb 9 2017, 9:54 PM · Workboards, Profile Menu Item

Feb 8 2017

chad closed T12226: Week 6 Useless Feature as Resolved by committing rP3b558d7dd0e3: Add back the motivator panel.
Feb 8 2017, 5:09 PM · Profile Menu Item
chad closed T12227: Restrict ProfileMenuItem by location as Invalid.
Feb 8 2017, 4:56 PM · Profile Menu Item
chad triaged T12208: Collapsable Menu Item as Normal priority.
Feb 8 2017, 3:24 PM · Profile Menu Item
chad added a comment to T12227: Restrict ProfileMenuItem by location.

:3

Feb 8 2017, 3:50 AM · Profile Menu Item
epriestley added a comment to T12227: Restrict ProfileMenuItem by location.

You should be able to implement canAddToObject() to do this. If you want a Home-only item, implement it like this:

Feb 8 2017, 3:18 AM · Profile Menu Item
chad created T12227: Restrict ProfileMenuItem by location.
Feb 8 2017, 12:27 AM · Profile Menu Item

Feb 7 2017

chad added a revision to T12226: Week 6 Useless Feature: D17324: Add back the motivator panel.
Feb 7 2017, 10:05 PM · Profile Menu Item
chad created T12226: Week 6 Useless Feature.
Feb 7 2017, 9:44 PM · Profile Menu Item

Feb 6 2017

chad closed T12211: phabricator-home css doesn't get applied to dashboards on home as Resolved by committing rP1f4a89b613a6: More minor CSS tweaks globally.
Feb 6 2017, 7:06 PM · Profile Menu Item, Dashboards, Bug Report