Differential D20337

Don't allow "Conpherence" menu items to be added to editable menus if Conpherence is not installed
ClosedPublic
Actions

Authored by epriestley on Mar 27 2019, 6:27 PM.

Details

Reviewers

Maniphest Tasks

T12745: Conpherence menu item is available for creation even if Conpherence is not installed
T13272: Remove the hard-coded homepage, and other Dashboards improvements

Commits

rP6648942bc885: Don't allow "Conpherence" menu items to be added to editable menus if…

Summary

Depends on D20336. Ref T13272. Fixes T12745. If you uninstall Conpherence, "Edit Favorites" and other editable menu interfaces still allow you to add "Conpherence" items. Prevent this.

Test Plan

Installed Conpherence: Saw option to add a "Conpherence" link when editing favorites menu.
Uninstalled Conpherence: No more option.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 27 2019, 6:27 PM

Harbormaster completed remote builds in B22404: Diff 48533.Mar 27 2019, 6:29 PM

epriestley requested review of this revision.Mar 27 2019, 6:29 PM

epriestley added a child revision: D20338: Allow users to add "ProfileMenu" items on mobile.Mar 27 2019, 9:12 PM

amckinley accepted this revision.Mar 27 2019, 9:33 PM

This revision is now accepted and ready to land.Mar 27 2019, 9:33 PM

Closed by commit rP6648942bc885: Don't allow "Conpherence" menu items to be added to editable menus if… (authored by epriestley). · Explain WhyMar 27 2019, 11:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

menuitem/

PhabricatorConpherenceProfileMenuItem.php

6 lines

Diff 48542

View Options

src/applications/search/menuitem/PhabricatorConpherenceProfileMenuItem.php

Don't allow "Conpherence" menu items to be added to editable menus if Conpherence is not installedClosedPublicActions