Page MenuHomePhabricator

Don't allow "Conpherence" menu items to be added to editable menus if Conpherence is not installed

Authored by epriestley on Mar 27 2019, 6:27 PM.



Depends on D20336. Ref T13272. Fixes T12745. If you uninstall Conpherence, "Edit Favorites" and other editable menu interfaces still allow you to add "Conpherence" items. Prevent this.

Test Plan
  • Installed Conpherence: Saw option to add a "Conpherence" link when editing favorites menu.
  • Uninstalled Conpherence: No more option.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 27 2019, 6:27 PM
epriestley requested review of this revision.Mar 27 2019, 6:29 PM
amckinley accepted this revision.Mar 27 2019, 9:33 PM
This revision is now accepted and ready to land.Mar 27 2019, 9:33 PM
This revision was automatically updated to reflect the committed changes.