Page MenuHomePhabricator
Feed Advanced Search

Aug 29 2018

epriestley added a comment to T13077: Plans: Phriction modern "v3" APIs, Drafts.

contentID on Document should probably not be nullable. We can generate a Document PHID first, save the Content with the right Document PHID, then save the Document with the content ID. Deleted/moved/stub documents still have Content, I'm pretty sure -- oh, except we can't do, this because Content uses documentID, not documentPHID. So maybe kick the can down the road.

Aug 29 2018, 4:04 PM · Plans, Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Aug 29 2018, 3:47 PM · Plans, Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Aug 29 2018, 3:29 PM · Plans, Phriction
epriestley added a revision to T13065: Move storage for `mailKey` to the Mail application: Unknown Object (Differential Revision).
Aug 29 2018, 3:29 PM · Mail
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Restricted Differential Revision.
Aug 29 2018, 3:18 PM · Plans, Phriction
epriestley added a comment to T8971: Auto-fix patch is wrong when multiple issue affect the same line.

Oh, and also to the original use case, I'll at least add some kind of warning for this since "silently skip some patches" isn't a good behavior. I'm open to adding some other hint mechanisms on top of this later so linters can better pick which patch wins, but would like to motivate it with some specific, surgical examples. The original example, where one linter removes debugging code and one linter reformats it, is a good starting point: in this case, "remove" should have greater strength than "reformat" and we'd prefer to discard the reformat patch and apply only the removal patch.

Aug 29 2018, 3:08 PM · Restricted Project, Arcanist
epriestley added a comment to T8971: Auto-fix patch is wrong when multiple issue affect the same line.

I'll plan to make these changes:

Aug 29 2018, 3:00 PM · Restricted Project, Arcanist

Aug 28 2018

epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Aug 28 2018, 10:14 PM · Plans, Phriction
epriestley closed T8172: "Edit" button shouldn't be hidden in "Actions", a subtask of T9379: Build Phriction v3, as Resolved.
Aug 28 2018, 9:58 PM · Phriction
epriestley closed T8172: "Edit" button shouldn't be hidden in "Actions" as Resolved by committing Restricted Diffusion Commit.
Aug 28 2018, 9:58 PM · FreeBSD, Restricted Project, Phriction
epriestley added a revision to T8172: "Edit" button shouldn't be hidden in "Actions": Unknown Object (Differential Revision).
Aug 28 2018, 9:51 PM · FreeBSD, Restricted Project, Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Aug 28 2018, 9:51 PM · Plans, Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Aug 28 2018, 9:00 PM · Plans, Phriction
epriestley updated the task description for T13189: Plans: 2018 Week 35 Bonus Content.
Aug 28 2018, 8:44 PM · Plans
epriestley added a comment to T9951: Store/display more information for Unit tests.

After D19615, callers to harbormaster.sendmessage can specify "format": "remarkup" to get "details" rendered as remarkup (including {Fxxx}) instead of plain text.

Aug 28 2018, 8:30 PM · Restricted Project, Restricted Project, Harbormaster, Feature Request
epriestley closed T9951: Store/display more information for Unit tests as Resolved by committing Restricted Diffusion Commit.
Aug 28 2018, 8:26 PM · Restricted Project, Restricted Project, Harbormaster, Feature Request
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: Unknown Object (Differential Revision).
Aug 28 2018, 8:24 PM · Plans, Harbormaster
epriestley added a revision to T9951: Store/display more information for Unit tests: Unknown Object (Differential Revision).
Aug 28 2018, 8:24 PM · Restricted Project, Restricted Project, Harbormaster, Feature Request
epriestley added a revision to T13189: Plans: 2018 Week 35 Bonus Content: Unknown Object (Differential Revision).
Aug 28 2018, 8:24 PM · Plans
epriestley added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

The unit test results also don't currently show on individual builds, which is a little whack?

Aug 28 2018, 8:05 PM · Plans, Harbormaster
epriestley added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

See T13189#240682 for some planning on the Unit Test result table.

Aug 28 2018, 7:52 PM · Plans, Harbormaster
epriestley added a comment to T13189: Plans: 2018 Week 35 Bonus Content.

See PHI710. This is a request for richer lint/unit results. It's likely entangled with T13088 but can probably be planned.

Aug 28 2018, 7:52 PM · Plans

Aug 27 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Aug 27 2018, 10:21 PM · Plans, Harbormaster
epriestley closed T10870: Allow Harbormaster builds to run another build plan on the same buildable as Invalid.

(Feature request with no support mana.)

Aug 27 2018, 10:16 PM · Restricted Project, Harbormaster
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Aug 27 2018, 10:16 PM · Plans, Harbormaster
epriestley closed T10568: Report partially failed builds better in Diffusion history as Wontfix.

I expect to add flags like "this doesn't block undrafting" and "this build doesn't matter" soon, and then possibly refine those. I'd consider revisiting this after those deploy, but am not excited about formalizing the idea of "only some of your tests failed so it's okay" or adding a check for each build (since this won't scale very far). The tooltip is reasonable but I'll just turn that into a note on T13088.

Aug 27 2018, 10:14 PM · Restricted Project, Harbormaster, Diffusion, Feature Request
epriestley closed T10516: Harbormaster Conduit API to build as Invalid.

(Feature request with no support mana and no discussion.)

Aug 27 2018, 10:10 PM · Restricted Project, Conduit, Harbormaster, Feature Request
epriestley closed T9892: I want to be sent email when a build fails for any commit in a repository as Wontfix.

Feature request with no support mana and no discussion / unique insight.

Aug 27 2018, 10:08 PM · Restricted Project, Harbormaster
epriestley closed T9586: Modernize Harbormaster build step UI elements as Wontfix.

Nothing really actionable here.

Aug 27 2018, 10:07 PM · Restricted Project, Harbormaster
epriestley closed T5877: Allow build plans to be "embedded" inside other build plans, a subtask of T1049: Implement Harbormaster, as Wontfix.
Aug 27 2018, 10:06 PM · Harbormaster
epriestley closed T5877: Allow build plans to be "embedded" inside other build plans as Wontfix.

This is reasonable to build eventually, but there's currently no support mana behind it and this task doesn't have any unique context or discussion.

Aug 27 2018, 10:06 PM · Restricted Project, Harbormaster
epriestley closed T5860: Allow build plans to be cloned in Harbormaster, a subtask of T1049: Implement Harbormaster, as Wontfix.
Aug 27 2018, 10:06 PM · Harbormaster
epriestley closed T5860: Allow build plans to be cloned in Harbormaster as Wontfix.

No support mana behind this and no unique information in the task.

Aug 27 2018, 10:06 PM · Restricted Project, Harbormaster
epriestley closed T5803: Discussion: How will iteration over build steps work?, a subtask of T1049: Implement Harbormaster, as Resolved.
Aug 27 2018, 10:05 PM · Harbormaster
epriestley closed T5803: Discussion: How will iteration over build steps work? as Resolved.

This isn't an actionable task so I'm banishing it to the shadow realm.

Aug 27 2018, 10:05 PM · Restricted Project, Harbormaster
epriestley closed T12813: Integrate Harbormaster with GoCD, a subtask of T9456: Evaluate upstream support for third-party build systems, as Wontfix.
Aug 27 2018, 10:04 PM · Restricted Project, Harbormaster
epriestley closed T12813: Integrate Harbormaster with GoCD as Wontfix.

We don't have any support mana behind this request, it's a good candidate for third-party development, and there's no unique information in this task so I'm just going to close it out.

Aug 27 2018, 10:04 PM · Harbormaster, Feature Request
epriestley updated the task description for T13077: Plans: Phriction modern "v3" APIs, Drafts.
Aug 27 2018, 9:48 PM · Plans, Phriction
epriestley closed T12793: Unable to move Phriction documents as Wontfix.

This doesn't have a repro and will probably be fixed via rewrite / modernization in T13077 anyway.

Aug 27 2018, 9:47 PM · Customer Impact, Bug Report, Phriction
epriestley updated the task description for T13077: Plans: Phriction modern "v3" APIs, Drafts.
Aug 27 2018, 9:45 PM · Plans, Phriction
epriestley closed T8970: Ability to draft/archive Phriction documents, a subtask of T9379: Build Phriction v3, as Wontfix.
Aug 27 2018, 9:43 PM · Phriction
epriestley closed T8970: Ability to draft/archive Phriction documents as Wontfix.

"Draft" will get a writeup in T13077 shortly.

Aug 27 2018, 9:43 PM · Phriction
epriestley closed T9371: Subscribers not inherited for wiki pages as Wontfix.

It's plausible that we might support this some day, but there's no clear pathway forward and no support mana behind this feature so I'm going to banish this task to the shadow realm. Herald provides a workaround in at least some cases.

Aug 27 2018, 9:41 PM · Phriction
epriestley updated the task description for T13189: Plans: 2018 Week 35 Bonus Content.
Aug 27 2018, 7:53 PM · Plans
epriestley closed T12251: Add author information when creating a build in Buildkite as Resolved by committing Restricted Diffusion Commit.
Aug 27 2018, 7:52 PM · Harbormaster, Feature Request
epriestley added a revision to T13189: Plans: 2018 Week 35 Bonus Content: Unknown Object (Differential Revision).
Aug 27 2018, 7:50 PM · Plans
epriestley added a revision to T12251: Add author information when creating a build in Buildkite: Unknown Object (Differential Revision).
Aug 27 2018, 7:50 PM · Harbormaster, Feature Request
epriestley closed T9041: Control access to administrator capabilities with custom policies as Resolved.

"Disable User", specifically, is now granular.

Aug 27 2018, 6:43 PM · FreeBSD, Policy, People
epriestley updated the task description for T13189: Plans: 2018 Week 35 Bonus Content.
Aug 27 2018, 6:39 PM · Plans
epriestley added a comment to T13189: Plans: 2018 Week 35 Bonus Content.

See PHI690. An install would like access to Drydock lease metrics, notably the time a lease spent in queue. See also T13073, but this is more narrowly scoped.

Aug 27 2018, 6:32 PM · Plans
epriestley updated the task description for T13189: Plans: 2018 Week 35 Bonus Content.
Aug 27 2018, 6:28 PM · Plans
epriestley added a revision to T13189: Plans: 2018 Week 35 Bonus Content: Unknown Object (Differential Revision).
Aug 27 2018, 6:23 PM · Plans
epriestley added a revision to T13189: Plans: 2018 Week 35 Bonus Content: Unknown Object (Differential Revision).
Aug 27 2018, 5:53 PM · Plans
epriestley updated the task description for T13189: Plans: 2018 Week 35 Bonus Content.
Aug 27 2018, 5:30 PM · Plans
epriestley triaged T13192: Inactive repositories can cause "Repository Servers" to always report "Partial Sync?" as Low priority.
Aug 27 2018, 5:28 PM · Clusters, Diffusion
epriestley triaged T13191: Add date ranges to Multimeter as Low priority.
Aug 27 2018, 5:26 PM · Performance
epriestley updated the task description for T13161: Plans: Improve Differential diff display behaviors.
Aug 27 2018, 5:23 PM · Differential, Plans
epriestley updated the task description for T13189: Plans: 2018 Week 35 Bonus Content.
Aug 27 2018, 5:12 PM · Plans
epriestley added a revision to T13189: Plans: 2018 Week 35 Bonus Content: Unknown Object (Differential Revision).
Aug 27 2018, 5:12 PM · Plans
epriestley updated the task description for T13189: Plans: 2018 Week 35 Bonus Content.
Aug 27 2018, 4:58 PM · Plans
epriestley updated the task description for T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance.
Aug 27 2018, 4:55 PM · Plans, Diffusion
epriestley updated the task description for T13189: Plans: 2018 Week 35 Bonus Content.
Aug 27 2018, 4:55 PM · Plans
epriestley added a revision to T13189: Plans: 2018 Week 35 Bonus Content: Unknown Object (Differential Revision).
Aug 27 2018, 4:51 PM · Plans
epriestley updated the task description for T13190: Plans: User Accounts, Profiles, Registration and Imports.
Aug 27 2018, 4:40 PM · Auth, People, Plans
epriestley added a comment to T13189: Plans: 2018 Week 35 Bonus Content.

I kicked some user/profile/account stuff to T13190.

Aug 27 2018, 4:40 PM · Plans
epriestley updated the task description for T13189: Plans: 2018 Week 35 Bonus Content.
Aug 27 2018, 4:40 PM · Plans
epriestley triaged T13190: Plans: User Accounts, Profiles, Registration and Imports as Normal priority.
Aug 27 2018, 4:35 PM · Auth, People, Plans
epriestley added a comment to T12877: Should not allow searching for users if "Can Browse User Directory" is not allowed.

I made this public since I've disclosed/discussed this elsewhere, including an indirect reference in the Spaces documentation, and I'm going to schedule it alongside some other stuff.

Aug 27 2018, 4:34 PM · People, Security
epriestley changed the visibility for T12877: Should not allow searching for users if "Can Browse User Directory" is not allowed.
Aug 27 2018, 4:32 PM · People, Security
epriestley added a revision to T13189: Plans: 2018 Week 35 Bonus Content: Unknown Object (Differential Revision).
Aug 27 2018, 4:28 PM · Plans
epriestley added a revision to T13186: Upgrading: Legacy "Can Edit <Field>" policies in Maniphest; requireCapabilities() in TransactionEditor: Unknown Object (Differential Revision).
Aug 27 2018, 2:56 PM · Security, Policy, ApplicationEditor, Guides, Installing & Upgrading
epriestley added a revision to T13189: Plans: 2018 Week 35 Bonus Content: Unknown Object (Differential Revision).
Aug 27 2018, 2:56 PM · Plans
epriestley added a revision to T13189: Plans: 2018 Week 35 Bonus Content: Unknown Object (Differential Revision).
Aug 27 2018, 2:46 PM · Plans
epriestley updated the task description for T13189: Plans: 2018 Week 35 Bonus Content.
Aug 27 2018, 2:36 PM · Plans
epriestley added a revision to T13189: Plans: 2018 Week 35 Bonus Content: Unknown Object (Differential Revision).
Aug 27 2018, 1:58 PM · Plans
epriestley updated the task description for T13189: Plans: 2018 Week 35 Bonus Content.
Aug 27 2018, 1:48 PM · Plans
epriestley added a revision to T13189: Plans: 2018 Week 35 Bonus Content: Unknown Object (Differential Revision).
Aug 27 2018, 1:47 PM · Plans
epriestley added a revision to T13189: Plans: 2018 Week 35 Bonus Content: Unknown Object (Differential Revision).
Aug 27 2018, 1:35 PM · Plans

Aug 25 2018

epriestley updated the task description for T13189: Plans: 2018 Week 35 Bonus Content.
Aug 25 2018, 1:58 PM · Plans
epriestley closed T13183: AWS is rebooting instances in late August 2018 as Resolved.

That one seemed straightforward.

Aug 25 2018, 1:57 PM · Ops, Phacility
epriestley added a comment to T13183: AWS is rebooting instances in late August 2018.

Doing admin001 now.

Aug 25 2018, 1:52 PM · Ops, Phacility
epriestley added a comment to T13183: AWS is rebooting instances in late August 2018.

Kicking secure001 now.

Aug 25 2018, 1:52 PM · Ops, Phacility
epriestley added a comment to T13183: AWS is rebooting instances in late August 2018.

(It not being covered is covered by T12879.)

Aug 25 2018, 1:38 PM · Ops, Phacility
epriestley added a comment to T13183: AWS is rebooting instances in late August 2018.

I think the only thing on secure or admin which isn't properly covered by deploy automation is the crontab on secure001:

Aug 25 2018, 1:37 PM · Ops, Phacility
epriestley added a comment to T13183: AWS is rebooting instances in late August 2018.

I'm going to do admin001 and secure001 today.

Aug 25 2018, 1:19 PM · Ops, Phacility
epriestley added a comment to T13189: Plans: 2018 Week 35 Bonus Content.

I landed D19586 (the thing which breaks T13186) and pushed it here. This generally causes us to perform more policy checks, and may cause new policy exceptions which did not exist before (because the workflows relied implicitly on weak policy enforcement). If these crop up, the remedy is generally to explicitly weaken the required capability for the action.

Aug 25 2018, 12:50 AM · Plans
epriestley edited the content of 2018 Week 34 (Very Late August).
Aug 25 2018, 12:44 AM
epriestley edited the content of Changelog.
Aug 25 2018, 12:44 AM
epriestley created 2018 Week 34 (Very Late August).
Aug 25 2018, 12:43 AM
epriestley closed T13187: Plans: 2018 Week 34 Bonus Content as Resolved.

I punted the rest of this to T13189.

Aug 25 2018, 12:38 AM · Plans
epriestley triaged T13189: Plans: 2018 Week 35 Bonus Content as Normal priority.
Aug 25 2018, 12:25 AM · Plans
epriestley updated the task description for T13187: Plans: 2018 Week 34 Bonus Content.
Aug 25 2018, 12:25 AM · Plans

Aug 24 2018

epriestley updated the task description for T13187: Plans: 2018 Week 34 Bonus Content.
Aug 24 2018, 8:47 PM · Plans
epriestley updated the task description for T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance.
Aug 24 2018, 8:47 PM · Plans, Diffusion
epriestley updated the task description for T13187: Plans: 2018 Week 34 Bonus Content.
Aug 24 2018, 7:56 PM · Plans
epriestley added a comment to T13188: CircleCI 1.0 sunsets on August 31, 2018; CircleCI 2.0 can not work with Phabricator.

The actual evidence about webhooks is a little spotty and it's possible that they "work" and are just undocumented and not officially supported. It's possible that CircleCI just needs a nudge to actually document/support them.

Aug 24 2018, 7:35 PM · Guides, Harbormaster
epriestley updated the task description for T9456: Evaluate upstream support for third-party build systems.
Aug 24 2018, 7:31 PM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

See T13188 for CircleCI 2.0. Upshot: they removed webhooks so we can no longer interact with them.

Aug 24 2018, 7:30 PM · Restricted Project, Harbormaster
epriestley triaged T13188: CircleCI 1.0 sunsets on August 31, 2018; CircleCI 2.0 can not work with Phabricator as Low priority.
Aug 24 2018, 7:30 PM · Guides, Harbormaster
epriestley added a revision to T13187: Plans: 2018 Week 34 Bonus Content: Unknown Object (Differential Revision).
Aug 24 2018, 5:58 PM · Plans