Page MenuHomePhabricator
Feed Advanced Search

Jun 14 2017

epriestley added a project to T12843: Add support for creating workboard columns from the Conduit API: Conduit.
Jun 14 2017, 12:08 PM · Conduit, Projects, Workboards, Feature Request
epriestley added projects to T12843: Add support for creating workboard columns from the Conduit API: Workboards, Projects.

I think this use case is a reasonable one.

Jun 14 2017, 12:08 PM · Conduit, Projects, Workboards, Feature Request

Jun 13 2017

epriestley added a comment to T10268: "Batch Edit" from workboards uses "?ids=X,Y,Z" which can exceed "Location" header or URL byte limits for large task sets.

Yeah -- the workflow from the Maniphest side dumps all the values into inputs in the body and does a POST, I believe.

Jun 13 2017, 10:09 PM · Customer Impact, Workboards, Maniphest
epriestley renamed T10268: "Batch Edit" from workboards uses "?ids=X,Y,Z" which can exceed "Location" header or URL byte limits for large task sets from Batch Edit tasks returns a 502 to "Batch Edit" from workboards uses "?ids=X,Y,Z" which can exceed "Location" header or URL byte limits for large task sets.
Jun 13 2017, 9:57 PM · Customer Impact, Workboards, Maniphest
epriestley updated subscribers of T10268: "Batch Edit" from workboards uses "?ids=X,Y,Z" which can exceed "Location" header or URL byte limits for large task sets.

@swisspol hit a variant of this with 1,172 tasks bumping up against an Apache URL limit in the Phacility cluster when editing from a workboard column.

Jun 13 2017, 9:54 PM · Customer Impact, Workboards, Maniphest
epriestley added a project to T10268: "Batch Edit" from workboards uses "?ids=X,Y,Z" which can exceed "Location" header or URL byte limits for large task sets: Customer Impact.
Jun 13 2017, 9:53 PM · Customer Impact, Workboards, Maniphest
epriestley closed T12839: Can't create one day event as Resolved.

iiam

Jun 13 2017, 9:21 PM · Calendar, Bug Report
epriestley added a comment to T12839: Can't create one day event.

I used the current version, but there should be no meaningful changes to this behavior between your version and HEAD.

Jun 13 2017, 9:10 PM · Calendar, Bug Report
epriestley added a comment to T12839: Can't create one day event.

I can't reproduce this. Here's what I did:

Jun 13 2017, 8:54 PM · Calendar, Bug Report
epriestley added a comment to T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs.

How did you generate this diff?

Jun 13 2017, 3:43 PM · Arcanist, Bug Report
epriestley closed T12834: Set new hourly rate for our new colleague as Invalid.
Jun 13 2017, 9:47 AM · Feature Request

Jun 12 2017

• tomekj2ee awarded T929: Allow two arbitrary revisions to be compared in Diffusion a Like token.
Jun 12 2017, 9:49 PM · Diffusion (v3), Restricted Project
epriestley added projects to T12830: Disentangle "repoXYZ = dbXYZ" in the Phacility cluster: Phacility, Ops.
Jun 12 2017, 6:44 PM · Ops, Phacility
epriestley created T12830: Disentangle "repoXYZ = dbXYZ" in the Phacility cluster.
Jun 12 2017, 6:44 PM · Ops, Phacility
amckinley awarded T12798: Decommission cluster host `repo012` a Baby Tequila token.
Jun 12 2017, 6:36 PM · Ops, Phacility
epriestley lowered the priority of T12798: Decommission cluster host `repo012` from High to Low.

I moved everything except one test instance off in T12817, and we appear to be ready for this host to die.

Jun 12 2017, 6:34 PM · Ops, Phacility
epriestley added a comment to T12828: git lfs broken due to missing ttf.relative config key.

I believe this should now be resolved in HEAD of master. Let us know if it doesn't work for you or if you're still seeing issues after upgrading. Thanks for the report!

Jun 12 2017, 6:25 PM · Bug Report
epriestley closed T12828: git lfs broken due to missing ttf.relative config key as Resolved by committing Restricted Diffusion Commit.
Jun 12 2017, 6:24 PM · Bug Report
epriestley closed T12817: Move instances from repo012 to repo025 as Resolved.

No one has complained that all their data is gone so I'm going to assume the best here.

Jun 12 2017, 6:23 PM · Phacility, Ops
epriestley closed T12821: Herald should allow "only the first time the rule matches" for calendar events as well as Resolved by committing Restricted Diffusion Commit.
Jun 12 2017, 6:23 PM · Herald, Bug Report
epriestley added a comment to T12828: git lfs broken due to missing ttf.relative config key.

This is not a configuration problem, and you can't fix it by changing configuration. D18119 should fix it.

Jun 12 2017, 6:21 PM · Bug Report
epriestley added a revision to T12828: git lfs broken due to missing ttf.relative config key: Unknown Object (Differential Revision).
Jun 12 2017, 6:21 PM · Bug Report
epriestley claimed T12828: git lfs broken due to missing ttf.relative config key.
Jun 12 2017, 6:21 PM · Bug Report
epriestley merged T12829: Synchronous accepts for the same project produce a misleading error into T12757: Multiple reviewers can race one another to accept on behalf of packages and get a poor UX.
Jun 12 2017, 6:16 PM · Customer Impact, Restricted Project, Differential
epriestley merged task T12829: Synchronous accepts for the same project produce a misleading error into T12757: Multiple reviewers can race one another to accept on behalf of packages and get a poor UX.
Jun 12 2017, 6:16 PM · Restricted Project, Differential, Bug Report
epriestley added a comment to T12829: Synchronous accepts for the same project produce a misleading error.

Presuming resolved by T12757 (May 25).

Jun 12 2017, 6:16 PM · Restricted Project, Differential, Bug Report
epriestley added a comment to T12829: Synchronous accepts for the same project produce a misleading error.

Version?

Jun 12 2017, 6:15 PM · Restricted Project, Differential, Bug Report
epriestley added a comment to T12688: Inline Comment Design Opportunities for Improvement.

Not exactly related, but these cancel buttons used to be grey and are now blue:

Jun 12 2017, 4:57 PM · Design, Differential, Inline Comments
epriestley added a comment to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size.

Some other general thoughts:

Jun 12 2017, 4:49 PM · Restricted Project, Search
epriestley added a comment to T12823: Customization of Projects / Diffusion homepages.

Sorry, I guess I'm being unclear: I don't believe that (1) is a reasonable starting point.

Jun 12 2017, 4:00 PM · Design
epriestley added a comment to T12823: Customization of Projects / Diffusion homepages.

I think maybe we're talking about a couple different things? These are both relatively easy:

Jun 12 2017, 3:54 PM · Design
epriestley added a comment to T12823: Customization of Projects / Diffusion homepages.

have a flagged filter automatically everywhere

Jun 12 2017, 3:05 PM · Design
epriestley added a comment to T12823: Customization of Projects / Diffusion homepages.

Maybe also, in general, we could define an "explore by tags" view, that works something like this:

Jun 12 2017, 3:03 PM · Design
epriestley added a comment to T12823: Customization of Projects / Diffusion homepages.

Constructively, some adjacent changes which are maybe worth considering instead:

Jun 12 2017, 2:54 PM · Design
epriestley added a revision to T12821: Herald should allow "only the first time the rule matches" for calendar events as well: Unknown Object (Differential Revision).
Jun 12 2017, 2:46 PM · Herald, Bug Report
epriestley added a comment to T12823: Customization of Projects / Diffusion homepages.

The requests I've seen seem like users want this done automatically/by default, not that they want better tools to do it themselves.

Jun 12 2017, 2:41 PM · Design
epriestley added a comment to T11150: ArcanistTextLinter: Support UTF8.

On a purely personal/aesthetic level, the box-drawing character block is total garbage and master ASCII artisans would never use it in serious work. A true connoisseur of the craft should accept nothing more than single-byte ASCII range in their collection.

Jun 12 2017, 2:13 PM · Restricted Project, Lint, Feature Request
epriestley added a comment to T11150: ArcanistTextLinter: Support UTF8.

See some related discussion in T12822. In particular:

Jun 12 2017, 2:06 PM · Restricted Project, Lint, Feature Request
epriestley added a comment to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery.

me too but not everyone is on our level

Jun 12 2017, 1:51 PM · Differential
epriestley added a comment to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery.
Jun 12 2017, 1:44 PM · Differential
epriestley added a project to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: Customer Impact.

Per above, these are already detected by the Text linter:

Jun 12 2017, 1:36 PM · Differential
epriestley triaged T12827: phd stop --force can’t find any daemons to kill on Solaris as Wishlist priority.

See also T4124 for another Solaris issue.

Jun 12 2017, 12:43 PM · Daemons, Bug Report

Jun 11 2017

briankc awarded T7125: Provide tooling to for periodic reminders (like renewing domains and update SSL certificates) a Like token.
Jun 11 2017, 3:49 AM · Calendar

Jun 10 2017

epriestley added a comment to T12817: Move instances from repo012 to repo025.

The move completed without errors.

Jun 10 2017, 10:40 AM · Phacility, Ops
epriestley added a comment to T12817: Move instances from repo012 to repo025.

Instances are moving now.

Jun 10 2017, 10:08 AM · Phacility, Ops
epriestley added a comment to T12817: Move instances from repo012 to repo025.

Deploying, then picking this up again.

Jun 10 2017, 9:31 AM · Phacility, Ops
cspeckmim awarded T12817: Move instances from repo012 to repo025 a Party Time token.
Jun 10 2017, 6:14 AM · Phacility, Ops
epriestley added a comment to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size.

I suspect some of those features have no actual use case outside very marginal nonsense like T12799, but they're "things computers should be able to do".

Jun 10 2017, 12:24 AM · Restricted Project, Search
epriestley added a comment to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size.

I want to get clear of T12798 first, but there are some other features I'd like to add to our search anyway, including:

Jun 10 2017, 12:23 AM · Restricted Project, Search
epriestley created T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size.
Jun 10 2017, 12:06 AM · Restricted Project, Search

Jun 9 2017

epriestley closed T11670: Automate more of the migration process for moving instances across shards in the Phacility cluster as Resolved.

I'm going to call this "resolved" since I migrated instances in T12817 successfully. There's followup work, but T12798 is probably a better point of consolidation for future work now than this task is.

Jun 9 2017, 11:51 PM · Ops, Phacility
epriestley closed T11670: Automate more of the migration process for moving instances across shards in the Phacility cluster, a subtask of T11665: repo002.phacility.net is heavily loaded, as Resolved.
Jun 9 2017, 11:51 PM · Ops, Phacility
epriestley created P2060 example_query.sql.
Jun 9 2017, 10:52 PM
epriestley edited the content of Changelog.
Jun 9 2017, 9:03 PM
epriestley created 2017 Week 23 (Early June).
Jun 9 2017, 9:02 PM
epriestley added a comment to T12817: Move instances from repo012 to repo025.

The disabled/suspended instances finished up with no apparent issues, so I expect to move the live instances tomorrow.

Jun 9 2017, 8:21 PM · Phacility, Ops
epriestley added a comment to T12817: Move instances from repo012 to repo025.

A verrrry minor thing is that because we always transfer a repository backup (even if it's empty), a migration always generates a repository directory on the far end. We could maaaybe have restore remove the directory if it's empty after the restore finishes to tidy this up just a touch.

Jun 9 2017, 7:46 PM · Phacility, Ops
epriestley added a comment to T12124: Counterintuitive priority setting via maniphest.edit conduit call.

Maybe just include name, value, closed and special?

Jun 9 2017, 7:39 PM · Maniphest, Conduit, Bug Report
epriestley added a comment to T12817: Move instances from repo012 to repo025.

I'm moving all the disabled/suspended instances now.

Jun 9 2017, 7:30 PM · Phacility, Ops
epriestley added a comment to T12817: Move instances from repo012 to repo025.

With those changes, bin/instances move completed successfully.

Jun 9 2017, 5:30 PM · Phacility, Ops
epriestley added a comment to T12817: Move instances from repo012 to repo025.

As a sort of aside, --global --instance X is really slow right now (about 10s), and will only get slower in the future: it loads every instance page by page over Conduit, then does the remaining filtering by name locally. But it gets the right result, so this is reasonable enough for the moment. I may try to tune this before moving a lot of instances.

Jun 9 2017, 5:23 PM · Phacility, Ops
epriestley added a comment to T12817: Move instances from repo012 to repo025.

I hit two more minor issues:

Jun 9 2017, 5:21 PM · Phacility, Ops
epriestley added a comment to T12817: Move instances from repo012 to repo025.

bin/host restore failed with this error:

Jun 9 2017, 5:04 PM · Phacility, Ops
epriestley added a comment to T12817: Move instances from repo012 to repo025.

I read and wrote the repository and verified that the data really ended up on db012 and repo025.

Jun 9 2017, 4:51 PM · Phacility, Ops
epriestley added a comment to T12817: Move instances from repo012 to repo025.

I launched yellow-underneathie.phacility.com with forced services dbx012 and repox025. My goal here is to check for any code I missed which makes the assumption that dbX = repoX. I believe we don't have any of this code, but if we do, this instance should point out whatever problems we have that still need to be cleaned up.

Jun 9 2017, 4:46 PM · Phacility, Ops
epriestley added a comment to T12817: Move instances from repo012 to repo025.
  • Swap stuff finished up.
  • I merged master to stable for services/ to pick up bin/services sync --src ... --dst ....
  • I merged master to stable for instances/ to pick up bin/instances move ... and related changes.
  • core/ just runs master so nothing needed to merge.
  • I upgraded repo025, then repo012, then admin001. None of these seemed to hit any issues.
Jun 9 2017, 4:42 PM · Phacility, Ops
epriestley added a comment to T12817: Move instances from repo012 to repo025.

While that's running, I closed dbx012 and repox012 to new allocations. The shard status panel correctly reflects repox025 with no paired DB service and the 012 shard as closed:

Jun 9 2017, 4:26 PM · Phacility, Ops
epriestley added a comment to T12817: Move instances from repo012 to repo025.
  • I launched repo025.phacility.net, like other hosts in the tier.
  • I added repo025.phacility.net to DNS in Route 53 (172.30.0.115).
  • I added a device record (repo025.phacility.net) to Almanac on admin.phacility.com.
  • I added a service record (repox025.phacility.net) to Almanac on admin.phacility.com, and bound it to the device.
  • I added a device record for the backup volume, rback025.phacility.net.
Jun 9 2017, 4:24 PM · Phacility, Ops
epriestley created T12817: Move instances from repo012 to repo025.
Jun 9 2017, 4:14 PM · Phacility, Ops
epriestley added a revision to T11670: Automate more of the migration process for moving instances across shards in the Phacility cluster: Unknown Object (Differential Revision).
Jun 9 2017, 3:55 PM · Ops, Phacility
epriestley closed T12815: arc land help mention --update-with-rebase work with git, but running it says it is not supported as Resolved by committing Restricted Diffusion Commit.
Jun 9 2017, 3:12 PM · Arcanist, Bug Report
epriestley lowered the priority of T12816: Setup NAT for the primary Phacility cluster from Normal to Low.

I think the next steps are:

Jun 9 2017, 3:11 PM · Ops, Phacility
epriestley added a comment to T12816: Setup NAT for the primary Phacility cluster.

I cleaned up all that stuff and it doesn't look like I broke the world.

Jun 9 2017, 3:00 PM · Ops, Phacility
epriestley added a comment to T12816: Setup NAT for the primary Phacility cluster.

I think this means we don't need to migrate every host: the problem with swapping block001 over to be NAT'd was probably that the NAT gateway itself couldn't reach the public internet. When we changed the 0.0.0.0/0 rule to nat-..., that blocked the NAT gateway itself from getting out.

Jun 9 2017, 2:53 PM · Ops, Phacility
epriestley added a comment to T12816: Setup NAT for the primary Phacility cluster.
  • I launched a new NAT gateway into the public subnet (block001); nat-0d470fc54d846a993.
  • I reconfigured the private subnet route table to point at the new gateway instead of the old one.
  • I can now reach the public internet from the host on the private subnet:
Jun 9 2017, 2:38 PM · Ops, Phacility
epriestley added a comment to T12816: Setup NAT for the primary Phacility cluster.

I think the problem is that the NAT gateway is currently in the private001 subnet, but needs to be in the public subnet (the NAT gateway itself must have a route to the public internet).

Jun 9 2017, 2:34 PM · Ops, Phacility
epriestley added a comment to T12816: Setup NAT for the primary Phacility cluster.
  • I stopped the host, and got kicked off as expected.
  • I started the host.
  • Problem: This failed to magically fix anything, and I still can't connect to the public internet.
Jun 9 2017, 2:29 PM · Ops, Phacility
epriestley added a comment to T12816: Setup NAT for the primary Phacility cluster.
  • I built a new route table, following the main route table.
  • I replaced the target for the 0.0.0.0/0 rule with nat-... instead of igw-....
  • Under "Endpoints", I added the new route table to the S3 endpoint so the private subnet can access S3.
    • (This wasn't immediately reflected in the "Routes" UI, but it's not important for now so I'm going to assume it's a propagation issue until I need it.)
    • (It showed up about a minute later.)
  • I changed private001.phacility.net to use the new route table, with nat-... instead of igw-....
  • I can still connect to the test host from the bastion.
  • Problem: I still can't connect to the public internet from the test host.
Jun 9 2017, 2:24 PM · Ops, Phacility
epriestley added a comment to T12816: Setup NAT for the primary Phacility cluster.
  • We launched a new private subnet (private001.phacility.net) yesterday.
  • I launched a new instance (nat-test001.phacility.net) into this subnet, with no public IP.
  • I can connect to the instance from the bastion host (bastion005), which is good.
  • Problem: I can not connect to the public internet from the test host.
Jun 9 2017, 2:18 PM · Ops, Phacility
epriestley created T12816: Setup NAT for the primary Phacility cluster.
Jun 9 2017, 2:16 PM · Ops, Phacility
epriestley added a comment to T12815: arc land help mention --update-with-rebase work with git, but running it says it is not supported.

The behavior of arc land is complex. You can look at the source for the details, or run arc land --trace to see which commands it executes.

Jun 9 2017, 2:11 PM · Arcanist, Bug Report
epriestley added a comment to T12814: pholio transaction emails have too much html.

Per @chad's link, PholioMockEditor->buildMailBody() does some improper stuff where it explicitly sets rendering targets and adds raw sections to the mail body.

Jun 9 2017, 2:05 PM · Pholio, Transactions, Bug Report
epriestley claimed T12815: arc land help mention --update-with-rebase work with git, but running it says it is not supported.
Jun 9 2017, 2:02 PM · Arcanist, Bug Report
epriestley added a comment to T12815: arc land help mention --update-with-rebase work with git, but running it says it is not supported.

Prior to October 2015, this flag only had an effect under git. This is why it says "Supports: git".

Jun 9 2017, 2:01 PM · Arcanist, Bug Report
epriestley added a revision to T12815: arc land help mention --update-with-rebase work with git, but running it says it is not supported: Unknown Object (Differential Revision).
Jun 9 2017, 1:58 PM · Arcanist, Bug Report
epriestley closed T12650: Allow setting --delete-remote on .arcrc as Invalid.

Arc supports auto-deleting the remote branch as well as the local one

Jun 9 2017, 1:56 PM · Feature Request
epriestley added a comment to T12815: arc land help mention --update-with-rebase work with git, but running it says it is not supported.

The version of arcanist used is the one packaged in debian.

Jun 9 2017, 1:49 PM · Arcanist, Bug Report
epriestley added a comment to M1477: Diffusion - June 2017.

See T12814.

Jun 9 2017, 1:20 PM

Jun 8 2017

epriestley added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

Maybe this was the workflow?

Jun 8 2017, 10:44 PM · Diffusion, Design
epriestley closed T12803: When tasks fail permanently, they should log the failure even if `phd.verbose` is not enabled as Resolved by committing Restricted Diffusion Commit.
Jun 8 2017, 10:26 PM · Daemons, Restricted Project
epriestley closed T12807: Diffusion's "Grep File Content" doesn't work with UTF characters as Resolved by committing Restricted Diffusion Commit.
Jun 8 2017, 10:26 PM · Diffusion, Bug Report
epriestley closed T12811: For commits, "committed" transaction is no longer stronger than other transactions like auditors and projects via Herald as Resolved by committing Restricted Diffusion Commit.
Jun 8 2017, 10:25 PM · Transactions, Diffusion, Bug Report
epriestley added a comment to T12813: Integrate Harbormaster with GoCD.

To set expectations, this is an exceedingly low priority for the upstream and these tasks basically only move forward when an existing customer requests integrations.

Jun 8 2017, 9:04 PM · Harbormaster, Feature Request
epriestley added a comment to T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).

(T12812 wants custom headers, but the only use case appears to be better covered by T12813.)

Jun 8 2017, 9:02 PM · Restricted Project, Harbormaster
epriestley merged T12812: Make it possible to send HTTP headers in Harbormaster's "Make HTTP Request" build step into T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).
Jun 8 2017, 9:01 PM · Restricted Project, Harbormaster
epriestley merged task T12812: Make it possible to send HTTP headers in Harbormaster's "Make HTTP Request" build step into T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).
Jun 8 2017, 9:01 PM · Harbormaster, Feature Request
epriestley added a project to T12813: Integrate Harbormaster with GoCD: Harbormaster.
Jun 8 2017, 9:00 PM · Harbormaster, Feature Request
epriestley triaged T12813: Integrate Harbormaster with GoCD as Wishlist priority.
Jun 8 2017, 9:00 PM · Harbormaster, Feature Request
epriestley added a subtask for T9456: Evaluate upstream support for third-party build systems: T12813: Integrate Harbormaster with GoCD.
Jun 8 2017, 8:59 PM · Restricted Project, Harbormaster
epriestley added a parent task for T12813: Integrate Harbormaster with GoCD: T9456: Evaluate upstream support for third-party build systems.
Jun 8 2017, 8:59 PM · Harbormaster, Feature Request