Page MenuHomePhabricator

Synchronous accepts for the same project produce a misleading error
Closed, DuplicatePublic


  • Project "Secret" contains users "Alice" and "Bob".
  • The "Secret" project is added as a group reviewer on a diff.
  • Alice selects "accept" from the actions dropdown, and leaves the default of accepting on behalf of herself and Secret; she does not yet hit "Submit."
  • Simultaneously, Bob does the same thing, leaving both checkboxes selected, but not hitting "Submit."
  • Alice then hits "Submit," which proceeds flawlessly.
  • Bob hits Submit, and receives the message:

Ideally, this would be a silent no-op, not a message that might imply to Bob that he is no longer a member of the Secret group.

Event Timeline

alexmv created this task.Jun 12 2017, 6:13 PM
alexmv added a project: Restricted Project.
alexmv added a subscriber: neilfitz.
alexmv added a comment.EditedJun 12 2017, 6:15 PM

Sorry, just pulling that out. 4d2c7e4d3d5d61e34b7e2af3df0e901d89d29433

Presuming resolved by T12757 (May 25).

Beautiful. Sorry for not finding that.