Page MenuHomePhabricator
Create Task
Maniphest T12811

For commits, "committed" transaction is no longer stronger than other transactions like auditors and projects via Herald
Closed, ResolvedPublic
Actions

Description

Hello, we used this function (T6973 "add project to a commit by Herald rule") happily for about two years (working version of phabricator was from 03/16/2016). The current phabricator update (06/06/2017) now lead to messages in the activity feed (Feed Stories - DefaultQuery "All Stories") in the form of

"Herald added a project to rXXXXX: <message>: <project>"

and the commit itself (or better the message) does not appear anymore. When we disable the Herald rule the commit messages appear in the feed again as before and expected. Is there a way to disable the Herald messages in the feed or a different way of adding projects to commits? (i did search the net unsuccessfully)

I am not sure, if this is a bug or a feature request. Thanks in advance!

Revisions and Commits

rP Phabricator
D18104rPe26cd3ffe0f9 Give "x committed <commit>" feed stories an explicitly higher action strength…

Related Objects

Event Timeline

Ben_RMCon created this task.Jun 8 2017, 11:18 AM

Herald rule:

pasted_file (510×939 px, 35 KB)

epriestley renamed this task from Herald rule message in acticity feed instead of commit message to For commits, "committed" transaction is no longer stronger than other transactions like auditors and projects via Herald.Jun 8 2017, 12:01 PM
epriestley claimed this task.
epriestley added projects: Diffusion, Transactions.
epriestley added a revision: D18104: Give "x committed <commit>" feed stories an explicitly higher action strength than other transactions.Jun 8 2017, 12:45 PM
Ben_RMCon awarded a token.Jun 8 2017, 1:26 PM
epriestley added a comment.Jun 8 2017, 1:27 PM

Note that D18104 is not retroactive, so existing feed stories aren't expected to change after upgrading. New feed stories published after picking up the fix should show "alice committed <commit>" as the title again, though.

epriestley closed this task as Resolved by committing rPe26cd3ffe0f9: Give "x committed <commit>" feed stories an explicitly higher action strength….Jun 8 2017, 10:25 PM
epriestley added a commit: rPe26cd3ffe0f9: Give "x committed <commit>" feed stories an explicitly higher action strength….
Phabricator · Built by Phacility