Page MenuHomePhabricator
Feed Advanced Search

Feb 10 2017

epriestley added a comment to T12232: Phortune "add payment method" erroring out on submission.

D17333 is a probable fix without needing to resort to a bunch of weird setInterval() juggling. I've pushed that here, let me know if you're still seeing the issue? If you are, does your JS console have anything in it?

Feb 10 2017, 4:44 PM · Phortune, Bug Report
epriestley added a comment to T12242: arc commandeer.

Other than implementing arc commandeer, can you suggest two different ways we could solve the problem you're running into?

Feb 10 2017, 4:38 PM · Feature Request
epriestley added a revision to T12232: Phortune "add payment method" erroring out on submission: Unknown Object (Differential Revision).
Feb 10 2017, 4:35 PM · Phortune, Bug Report
epriestley added a comment to T12232: Phortune "add payment method" erroring out on submission.

I'm having some trouble reproducing this -- I tried Safari and Chrome here and in my sandbox. You aren't using anything weird, right?

Feb 10 2017, 4:30 PM · Phortune, Bug Report
epriestley added a comment to T12234: Add a "Duplicates" tab to the "Related Objects" section on task page.

At some point, it's starting to be a lot of noise in the project, so we dup all these reports against the task tracking the root cause.

Feb 10 2017, 4:12 PM · Customer Impact, Feature Request
epriestley added a comment to T12234: Add a "Duplicates" tab to the "Related Objects" section on task page.

From a technical standpoint, we did not record these relationships in a normalized way prior to D16196 (June 2016, about 7 months ago) -- they only existed in the transaction log, and we just wrote a "close", extra_data="as duplicate of X" transaction that can't be queried efficiently.

Feb 10 2017, 4:09 PM · Customer Impact, Feature Request
epriestley added a comment to T12240: Best of Both Worlds: one email to everyone with privacy controls and good threading.

We could also implement "Mute Thread" in Phabricator, but I assume no one would be willing to click twice to mute a thread.

Feb 10 2017, 3:44 PM · Restricted Project, Mail, Feature Request
epriestley closed T12236: Conduit Method maniphest.edit: Unhandled Exception as Resolved by committing Restricted Diffusion Commit.
Feb 10 2017, 3:39 PM · Bug Report
epriestley added a comment to T12240: Best of Both Worlds: one email to everyone with privacy controls and good threading.

If we use SMTP envelope To, doesn't Alice potentially get multiple messages still (envelope "To: Alice", envelope "To: All-About-Alice@lists.company.com")? The list rewrites the envelope to go to all the list members, right? Or is there more magic there I don't know about?

Feb 10 2017, 3:35 PM · Restricted Project, Mail, Feature Request
epriestley added a comment to T12240: Best of Both Worlds: one email to everyone with privacy controls and good threading.

One issue with one-mail-per-recipient is that gmail does not permit muting an email conversation if you are the only TO recipient.

Feb 10 2017, 3:28 PM · Restricted Project, Mail, Feature Request
epriestley closed T12235: Differential wrongly says I "Must Review" reviews rejected by group as Wontfix.

T11050 describes a way you could work around this issue in some cases in the future, by resigning from the review (basically, saying "I'm not going to review this on behalf of Project 1 because user B is on top of it, so get it out of my queue"). That doesn't help if you want it in your queue but just not in the "Must Review" bucket.

Feb 10 2017, 3:22 PM · Differential, Bug Report
epriestley added a comment to T12236: Conduit Method maniphest.edit: Unhandled Exception.

Thanks for the report, and for including detailed reproduction steps. The were very helpful in reproducing and fixing this issue.

Feb 10 2017, 3:15 PM · Bug Report
epriestley added a revision to T12236: Conduit Method maniphest.edit: Unhandled Exception: Unknown Object (Differential Revision).
Feb 10 2017, 3:14 PM · Bug Report
epriestley added a comment to T12241: Make it easier to find objects while in remarkup box.

If you want to implement the rest of it with a ( trigger I can counter-diff you for a (( trigger.

Feb 10 2017, 2:53 PM · Phurl, Remarkup, Feature Request
epriestley added a comment to T12240: Best of Both Worlds: one email to everyone with privacy controls and good threading.

(D17331 should fix the outdated discussion of the option in Config.)

Feb 10 2017, 2:40 PM · Restricted Project, Mail, Feature Request
epriestley added a revision to T12240: Best of Both Worlds: one email to everyone with privacy controls and good threading: Unknown Object (Differential Revision).
Feb 10 2017, 2:38 PM · Restricted Project, Mail, Feature Request
epriestley added a project to T12241: Make it easier to find objects while in remarkup box: Phurl.
Feb 10 2017, 2:29 PM · Phurl, Remarkup, Feature Request
epriestley added a comment to T12241: Make it easier to find objects while in remarkup box.

In the specific case of Phurl autocompletion, I'd be happy to review a change if someone wants to tackle it. The recent emoji autocompletion is probably a pretty good example to start from.

Feb 10 2017, 2:29 PM · Phurl, Remarkup, Feature Request
epriestley added a comment to T5951: Remarkup cannot properly link to Phriction pages with special characters in the title..

(It's still not possible to name a link X | Y, but I think we're no longer aware of any reasonable cases where this is important.)

Feb 10 2017, 2:26 PM · Remarkup
epriestley closed T5951: Remarkup cannot properly link to Phriction pages with special characters in the title. as Resolved.

I belive this was effectively resolved by changes connected to T7691. Specifically, if you had a page titled "A" at location "x", you previously needed to type [[ x | A ]] to get it to render the right link text. If you omitted the ... | A ... part, the link would just be named x.

Feb 10 2017, 2:25 PM · Remarkup
epriestley added a comment to T5301: Inline Remarkup escaping.

What about triple backticks in code blocks? Code blocks can contain
anything, so I consider not being able to put three consecutive backticks
in them a bug.

Feb 10 2017, 2:18 PM · Remarkup
epriestley added a comment to T5301: Inline Remarkup escaping.

Commentary on this is welcome, even just to say no it won't fly.

Feb 10 2017, 1:58 PM · Remarkup
epriestley merged T11543: Provide an on-page workflow for searching for objects to reference while typing a Remarkup comment into T12241: Make it easier to find objects while in remarkup box.
Feb 10 2017, 1:54 PM · Phurl, Remarkup, Feature Request
epriestley merged task T11543: Provide an on-page workflow for searching for objects to reference while typing a Remarkup comment into T12241: Make it easier to find objects while in remarkup box.
Feb 10 2017, 1:54 PM · Restricted Project, Remarkup, Feature Request
epriestley added a comment to T12241: Make it easier to find objects while in remarkup box.

I think this is the same as T11543 but I'm going to merge that here since this one is a little cleaner. My current thinking:

Feb 10 2017, 1:53 PM · Phurl, Remarkup, Feature Request
epriestley added a comment to E1370: Last-Minute Pup Adventures.

haha good 🐱 👍

Feb 10 2017, 1:47 PM
epriestley added a comment to T12237: Amazon SES has suspended outbound mail from secure.phabricator.com.

I imagine that the rest of the process will work like this:

Feb 10 2017, 1:46 PM · Mail, Phacility, Ops
epriestley updated subscribers of T12237: Amazon SES has suspended outbound mail from secure.phabricator.com.

AWS got back to me with essentially a form response that didn't address any of the particulars of our case.

Feb 10 2017, 1:30 PM · Mail, Phacility, Ops

Feb 9 2017

epriestley added a comment to T5301: Inline Remarkup escaping.

For starters, this regex fails to work

Feb 9 2017, 10:33 PM · Remarkup
epriestley added a comment to T12240: Best of Both Worlds: one email to everyone with privacy controls and good threading.

Sometimes people will "Reply All" and everyone will get two mails, one from the user and one from Phabricator turning their mail into a comment.

Feb 9 2017, 9:53 PM · Restricted Project, Mail, Feature Request
epriestley added a comment to T12240: Best of Both Worlds: one email to everyone with privacy controls and good threading.

To jump back further, the root-ier cause is that you're using mailing lists?

Feb 9 2017, 9:48 PM · Restricted Project, Mail, Feature Request
epriestley added a comment to T12240: Best of Both Worlds: one email to everyone with privacy controls and good threading.

Oh, I didn't even realize that was a thing. I assumed SMTP went like "okay here is a message: <message body>".

Feb 9 2017, 9:21 PM · Restricted Project, Mail, Feature Request
epriestley added a comment to E1370: Last-Minute Pup Adventures.

Here is a picture from this morning but she was a little confused that we were wasting time taking pictures (boring) instead of going straight to daycare.

Feb 9 2017, 7:54 PM
epriestley added a comment to T12240: Best of Both Worlds: one email to everyone with privacy controls and good threading.

Or, more generally, if we send two mails:

Feb 9 2017, 7:42 PM · Restricted Project, Mail, Feature Request
epriestley added a comment to T12106: task search not finding task with full word match .

I think you don't need to rebuild the search index for that to take full effect. Although rebuilding it will change the content in the index in some cases, the new, more-tailored queries should match either version.

Feb 9 2017, 7:36 PM · Restricted Project, Search, Bug Report
epriestley closed T12106: task search not finding task with full word match as Resolved by committing Restricted Diffusion Commit.
Feb 9 2017, 7:30 PM · Restricted Project, Search, Bug Report
epriestley added a comment to T12106: task search not finding task with full word match .

We transform x y into +"x" +"y" in the general case, but currently apply stemming to "a_b" and "c.d". This is because it's generally correct to stem "x-y", which is usually a hyphenated English phrase rather than a "constant" or "token", and correct to stem "z.", which is usually something copy-pasted with a stray period, not an intent to search for a token ending with a period, and the cases of "_" and "." got lumped in with those.

Feb 9 2017, 7:28 PM · Restricted Project, Search, Bug Report
epriestley added a revision to T12106: task search not finding task with full word match : Unknown Object (Differential Revision).
Feb 9 2017, 7:27 PM · Restricted Project, Search, Bug Report
epriestley added a comment to T12237: Amazon SES has suspended outbound mail from secure.phabricator.com.
  • We no longer send normal mail to unverified addresses. Consequently, mail sent between creating an account and that user verifying their address (for example, assigning them tasks) is now dropped.
  • We no longer send "sorry, we ignored your mail because we don't recognize the address" replies if we don't recognize the sender, unless phabricator.allow-email-users is set.
    • I would like to eventually (post-Nuance?) remove this option, stop allowing "email users", and move away from "grey users".
  • We no longer send a misleading error about "no default user" if an application address is not configured with a default user.
  • This install now delivers outbound mail through Mailgun instead of SES.
  • The queued backlog appears to have flushed.
Feb 9 2017, 6:45 PM · Mail, Phacility, Ops
epriestley added a comment to T3569: Make Phrequent somewhat usable.

Unfortunately, this is so far afield from our roadmap that we don't have room for this year, even under paid prioritization.

Feb 9 2017, 6:35 PM · Phrequent
epriestley added a comment to T12240: Best of Both Worlds: one email to everyone with privacy controls and good threading.
  • I think this sends the recipients many copies of the email, particularly if they are on mailing lists? Why do you believe that users will receive only one copy of the mail if we send ten messages with their address in "To"?
  • Are you sure "Reply-To" overrides "Reply All" in all major clients? I haven't tested this personally, but I can't immediately find any references to this behavior on Google. I believe we already use "Reply-To", so I would expect "Reply All" to already be a non-problem if "Reply-To" overrode it. My pre-existing belief was that "Reply-To" replaced only "From", not the entire recipient list, under "Reply All".
Feb 9 2017, 6:33 PM · Restricted Project, Mail, Feature Request
epriestley added a revision to T12237: Amazon SES has suspended outbound mail from secure.phabricator.com: Unknown Object (Differential Revision).
Feb 9 2017, 6:08 PM · Mail, Phacility, Ops
epriestley added a comment to T12237: Amazon SES has suspended outbound mail from secure.phabricator.com.

A sub-issue here is that we're bouncing a lot of email like this, for an exciting product called "Penisole" from reputable domain "bloggay.com":

Feb 9 2017, 4:33 PM · Mail, Phacility, Ops
epriestley added a comment to T12237: Amazon SES has suspended outbound mail from secure.phabricator.com.

Add some kind of notification to user accounts like "some email you would have been sent was dropped because you haven't verified your address yet"?

Feb 9 2017, 4:18 PM · Mail, Phacility, Ops
epriestley added a comment to T12237: Amazon SES has suspended outbound mail from secure.phabricator.com.

My plan here is:

Feb 9 2017, 4:12 PM · Mail, Phacility, Ops
epriestley added a comment to T12237: Amazon SES has suspended outbound mail from secure.phabricator.com.

My guess is that this is just something dumb and mostly out of our control, and we fell through the cracks because the email volume we send from this install is tiny. We sent 41,877 messages in January at a cost of $0.00 -- this is too few messages to even qualify for charges, which start once you send 2,000 messages in a single day.

Feb 9 2017, 3:55 PM · Mail, Phacility, Ops
epriestley created T12238: Write a script to populate a Phacility instance with the "Locations" scenario.
Feb 9 2017, 3:14 PM · Phacility
epriestley added a comment to T12234: Add a "Duplicates" tab to the "Related Objects" section on task page.

Yeah: if it's important to identify duplicates because you use duplicates as a priority signal, making it easier to see a list of duplicates on the task detail isn't a very powerful approach.

Feb 9 2017, 1:44 PM · Customer Impact, Feature Request
epriestley added a comment to T12237: Amazon SES has suspended outbound mail from secure.phabricator.com.

Although I'm somewhat confused by this because it came to the address for my personal AWS account.

Feb 9 2017, 12:56 PM · Mail, Phacility, Ops
epriestley added a comment to T12237: Amazon SES has suspended outbound mail from secure.phabricator.com.

I appealed this, but the FAQ says "Due to the way spamtrap sending is reported, it will take a minimum of three weeks before we can confirm that a fix you have put in place has succeeded.".

Feb 9 2017, 11:35 AM · Mail, Phacility, Ops
epriestley added a comment to T12237: Amazon SES has suspended outbound mail from secure.phabricator.com.

@chad, just to make sure my ducks are in a row, you aren't using noreply@phabricator.com in association with any marketing mail, right? I don't want to claim "we only send transactional mail" if that isn't true.

Feb 9 2017, 10:30 AM · Mail, Phacility, Ops
epriestley added a comment to T12237: Amazon SES has suspended outbound mail from secure.phabricator.com.

SES is definitely rejecting mail, though:

Feb 9 2017, 10:22 AM · Mail, Phacility, Ops
epriestley added a comment to T12237: Amazon SES has suspended outbound mail from secure.phabricator.com.

Although I'm somewhat confused by this because it came to the address for my personal AWS account.

Feb 9 2017, 10:21 AM · Mail, Phacility, Ops
epriestley created T12237: Amazon SES has suspended outbound mail from secure.phabricator.com.
Feb 9 2017, 10:18 AM · Mail, Phacility, Ops
epriestley added a comment to T12235: Differential wrongly says I "Must Review" reviews rejected by group.

Revisions in the "Needs Revision" state (i.e., following the reject in step (2)) should never appear in "Must Review". I think the steps are missing a step "2a", where the author updates the revision with new changes?

Feb 9 2017, 3:37 AM · Differential, Bug Report
epriestley added a comment to T12234: Add a "Duplicates" tab to the "Related Objects" section on task page.

Why is it important to see all the duplicates at a glance?

Feb 9 2017, 1:27 AM · Customer Impact, Feature Request
epriestley added a revision to T10881: git diff parsing fails with --submodule=log: Unknown Object (Differential Revision).
Feb 9 2017, 12:52 AM · Contributor Onboarding, Arcanist, Bug Report
epriestley added a comment to T10390: Dashboards v2 (UX).

There's currently no way to query that, since the dashboardPHID is in a JSON blob in the PhabricatorProfileMenuItemConfiguration table.

Feb 9 2017, 12:12 AM · Dashboards (v2)

Feb 8 2017

epriestley added a comment to T9363: improve handling of panels that do not always return results.

T12233 is an essentially identical case, although it discusses other analogous use cases (hide/shrink "Audits" if empty; hide/shrink "Reviews" if empty).

Feb 8 2017, 10:06 PM · Dashboards (v2), ApplicationSearch, Restricted Project, Restricted Project
epriestley merged T12233: Allow dashboard panels to be "hidden" when considered "empty" into T9363: improve handling of panels that do not always return results.
Feb 8 2017, 10:05 PM · Dashboards (v2), ApplicationSearch, Restricted Project, Restricted Project
epriestley merged task T12233: Allow dashboard panels to be "hidden" when considered "empty" into T9363: improve handling of panels that do not always return results.
Feb 8 2017, 10:05 PM · Dashboards, Feature Request
epriestley added a comment to E1370: Last-Minute Pup Adventures.

I just dropped her off at daycare but I will submit proof that she is alive and unharmed after I pick her up this evening.

Feb 8 2017, 7:23 PM
epriestley added a comment to T784: Allow Differential changesets to be marked with various attributes.

See Planning for help on status and timelines.

Feb 8 2017, 6:11 PM · Restricted Project, Restricted Project, Restricted Project, Differential, Arcanist
epriestley added a comment to T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails.

From elsewhere, it would also be nice if this tokenizer highlighted instance members of instances associated with the billing account. There isn't a straightforward way to determine which "joe" or whatever is correct right now that works better than "ask Joe what his account name is".

Feb 8 2017, 6:03 PM · Phortune, Phacility
epriestley added a comment to T12232: Phortune "add payment method" erroring out on submission.

Yeah I clicked "Delete File" and can't see it anywhere now.

Feb 8 2017, 5:26 PM · Phortune, Bug Report
epriestley added a project to T12232: Phortune "add payment method" erroring out on submission: Phortune.
Feb 8 2017, 5:15 PM · Phortune, Bug Report
epriestley merged task T12158: Possible JS error in Phortune when adding new card into T12232: Phortune "add payment method" erroring out on submission.
Feb 8 2017, 5:15 PM · Phortune
epriestley merged T12158: Possible JS error in Phortune when adding new card into T12232: Phortune "add payment method" erroring out on submission.
Feb 8 2017, 5:15 PM · Phortune, Bug Report
epriestley added a comment to T12232: Phortune "add payment method" erroring out on submission.

You destroyed the original file in Files too, right?

Feb 8 2017, 5:15 PM · Phortune, Bug Report
epriestley added a comment to T12172: Better color scheme for diffs.

No problem, we're not in any rush.

Feb 8 2017, 5:11 PM · Accessibility, Feature Request
OCram awarded T12134: Develop a Nuance-based Phabricator reporting/support flow a Like token.
Feb 8 2017, 6:14 AM · Abuse
epriestley added a comment to T12227: Restrict ProfileMenuItem by location.

You should be able to implement canAddToObject() to do this. If you want a Home-only item, implement it like this:

Feb 8 2017, 3:18 AM · Profile Menu Item

Feb 7 2017

epriestley added a comment to T8937: Unclear exception when patching non-existant revision.

I'm going to fix this Real Soon, I absolutely Definitely Promise 100% ™ ®. But I'll accept a patch from a reputable contributor like @jcox any day.

Feb 7 2017, 9:00 PM · Arcanist
epriestley edited this Badge.
Feb 7 2017, 8:51 PM
epriestley added a comment to T10390: Dashboards v2 (UX).

Generally makes sense to me.

Feb 7 2017, 5:08 PM · Dashboards (v2)
epriestley created E1370: Last-Minute Pup Adventures.
Feb 7 2017, 4:32 PM
epriestley updated the task description for T12224: Phortune "Autopay" on View controller does not respect disabled payment methods.
Feb 7 2017, 3:23 PM · Phortune
epriestley created T12224: Phortune "Autopay" on View controller does not respect disabled payment methods.
Feb 7 2017, 3:22 PM · Phortune
epriestley reopened T12213: Task title is truncated in task graph, even if there is enough space as "Open".
Feb 7 2017, 2:09 PM · Maniphest, Bug Report
liuxinyu970226 awarded T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches a Like token.
Feb 7 2017, 12:01 AM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search

Feb 6 2017

epriestley added a comment to T2794: Implement Phage (like Hypershell).

Per T12218, the Phacility cluster is reaching a scale (~50 devices) where we need to improve tooling over "open a bunch of terminal windows". I want to look at implementing Phage for this use case and see how far I can get.

Feb 6 2017, 9:54 PM · Phage, Infrastructure
epriestley added a parent task for T2794: Implement Phage (like Hypershell): T12218: Reduce the operational cost of a larger Phacility cluster.
Feb 6 2017, 8:51 PM · Phage, Infrastructure
epriestley added a subtask for T12218: Reduce the operational cost of a larger Phacility cluster: T2794: Implement Phage (like Hypershell).
Feb 6 2017, 8:51 PM · Ops, Phacility
epriestley merged task T9374: Allow `bin/remote` commands to operate on a range of hosts into T12218: Reduce the operational cost of a larger Phacility cluster.
Feb 6 2017, 8:51 PM · Ops, Phacility
epriestley merged T9374: Allow `bin/remote` commands to operate on a range of hosts into T12218: Reduce the operational cost of a larger Phacility cluster.
Feb 6 2017, 8:51 PM · Ops, Phacility
epriestley changed the visibility for T2794: Implement Phage (like Hypershell).
Feb 6 2017, 8:51 PM · Phage, Infrastructure
epriestley added a comment to T12219: Some MP4 videos do not play in Chrome.

Yeah, same here. Both videos are of similar size (1.6MB vs 2.1MB) and both appear to legitimately be MP4 / H264 videos (neither is some kind of obviously spooky magic like an AVI named .mp4).

Feb 6 2017, 5:39 PM · Files
epriestley updated subscribers of T12219: Some MP4 videos do not play in Chrome.
Feb 6 2017, 5:34 PM · Files
epriestley added a comment to T12219: Some MP4 videos do not play in Chrome.

Here's what I see in Chrome at time of writing:

Feb 6 2017, 5:34 PM · Files
epriestley created T12219: Some MP4 videos do not play in Chrome.
Feb 6 2017, 5:33 PM · Files
epriestley closed T12209: "Services" application is a launchable, listed application but should be a sneaky stealth application as Resolved by committing Restricted Diffusion Commit.
Feb 6 2017, 5:32 PM · Applications, Phacility
epriestley added a revision to T12209: "Services" application is a launchable, listed application but should be a sneaky stealth application: Unknown Object (Differential Revision).
Feb 6 2017, 5:27 PM · Applications, Phacility
epriestley created T12218: Reduce the operational cost of a larger Phacility cluster.
Feb 6 2017, 5:14 PM · Ops, Phacility
epriestley added a comment to T12214: Navigation menus in applications have no maximum width.

(Maybe the real user report was something only indirectly related, like putting the query on a Dashboard? That would make sense given that the name talks about dashboards...)

Feb 6 2017, 4:58 PM · PHUI
epriestley added a comment to T12214: Navigation menus in applications have no maximum width.

I think it should use the same global/personal paradigm (let administrators save Global queries, supplementing the current ability for users to save personal queries).

Feb 6 2017, 4:55 PM · PHUI
epriestley closed T12215: Bad session URL in http://PHABRICATOR/people/logs/ as Resolved by committing Restricted Diffusion Commit.
Feb 6 2017, 4:38 PM · People, Bug Report
epriestley closed T12216: User can change userpic when account.editable is false (bad config description or restrictions mistake) as Resolved by committing Restricted Diffusion Commit.
Feb 6 2017, 4:37 PM · Profile, Config, Bug Report
epriestley created T12217: Reduce the hardware cost of Phacility free instances.
Feb 6 2017, 4:02 PM · Ops, Phacility
epriestley added a comment to T11760: Phacility Cluster: Ad-Hoc Query Log.

We queried a subset of instances for the date of the most recent session activity, to estimate the impact of requiring free instances to log in periodically to remain active:

Feb 6 2017, 3:17 PM · Phacility
epriestley added a revision to T12216: User can change userpic when account.editable is false (bad config description or restrictions mistake): Unknown Object (Differential Revision).
Feb 6 2017, 1:02 PM · Profile, Config, Bug Report