Page MenuHomePhabricator

Remarkup cannot properly link to Phriction pages with special characters in the title.
Closed, ResolvedPublic

Description

This is actually works differently when at phab.enlightenment.org and on secure.phabricator.com

phab.enlightenment.org

  1. Create a page in phriction (with a / or | in the title of that page.
  2. Create a Task in maniphest
  3. Attempt to link to that page you made...

Result : When I tried to link to this Arcanist and Review | Submission, remark ends up making the title Submission, and the link it generates points towards a nonexistent page.

secure.phabricator.com

  1. Create a page in phriction (with a / or | in the title of that page.
  2. Create a Task in maniphest
  3. Attempt to link to that page you made...

Result : When I tried to link to my Test Page | wPipe on here, remark up ends up making the wPipe and links to this : https://secure.phabricator.com/w/test_page/

Example : wPipe
Example at phab.enlightenment.org - You'll have to test it to reproduce it.

Related Objects

Event Timeline

Yomi raised the priority of this task from to Needs Triage.
Yomi updated the task description. (Show Details)
Yomi added a project: Remarkup.
Yomi updated the task description. (Show Details)
Yomi added a subscriber: Yomi.
chad triaged this task as Low priority.Aug 25 2014, 5:11 PM
chad updated the task description. (Show Details)
epriestley claimed this task.
epriestley added a subscriber: epriestley.

I belive this was effectively resolved by changes connected to T7691. Specifically, if you had a page titled "A" at location "x", you previously needed to type [[ x | A ]] to get it to render the right link text. If you omitted the ... | A ... part, the link would just be named x.

After changes connected to T7691, the default name of [[ x ]] is the page name. You might previously have tried something like this:

[[ arcanist/review ]] # Before T7691: links to the right page, but name of the link isn't helpful.
[[ arcanist/review | Arcanist | Review and Submission ]] # Doesn't parse.

However, [[ arcanist/review ]] should just do the sensible thing now. For example, [[ phacility_cluster ]] generates a link named "Phacility Cluster Documentation" now (the wiki page name at time of writing), not "phacility_cluster": Phacility Cluster Documentation

If there's a remaining issue here, feel free to file a new task with a specific reproduction case.

(It's still not possible to name a link X | Y, but I think we're no longer aware of any reasonable cases where this is important.)