Page MenuHomePhabricator
Feed Advanced Search

Jul 8 2016

epriestley closed T11295: Worker queue 404 page fails with invalid `$header` as Resolved by committing Restricted Diffusion Commit.
Jul 8 2016, 2:08 PM · Daemons, Bug Report
epriestley closed T11293: Show the repo name in the Owners app's "paths" editor as Resolved by committing Restricted Diffusion Commit.
Jul 8 2016, 2:08 PM · Owners, Bug Report
featherless added a comment to T11293: Show the repo name in the Owners app's "paths" editor.

Yay! Thank you.

Jul 8 2016, 1:36 PM · Owners, Bug Report
isfs added a comment to T11117: Links to hidden comments in the same task don't work.

As was mentioned, there was code already for detecting a hidden hash/anchor and loading older transactions/comments to allow it to be reached. Turned out it was a cinch to hook it up, which I've done in D16256.

Jul 8 2016, 1:22 PM · Wikimedia, PHUI, Bug Report
isfs added a revision to T11117: Links to hidden comments in the same task don't work: Restricted Differential Revision.
Jul 8 2016, 1:20 PM · Wikimedia, PHUI, Bug Report
epriestley added a comment to T11171: When clicking an image in the comment edit modal, the image modal gets under the edit modal.

We might have had some kind of dialog action from lightboxes in the past (or planned to have one -- like image inline comments?), but didn't have a lightbox action from dialogs until inline previews.

Jul 8 2016, 11:59 AM · Lightbox, Bug Report
epriestley closed T11296: Edit Queries/Advanced Search 404s from Settings page as Resolved.

This was fixed by D16238 (Tuesday, July 5). It's available at HEAD of master and will promote to stable and be available in the Phacility cluster in a little more than 24 hours.

Jul 8 2016, 11:53 AM · Bug Report
faulconbridge created T11296: Edit Queries/Advanced Search 404s from Settings page.
Jul 8 2016, 11:48 AM · Bug Report
epriestley added a comment to T11263: DarkConsole "`" keypress does not fire immediately on some systems or keyboard layouts.

A possible fix to this is to handle ` on keydown instead of keypress (as we do for some other other keystrokes) but since we can't reproduce it we can't test that.

Jul 8 2016, 11:43 AM · Bug Report (Needs Information)
epriestley renamed T11263: DarkConsole "`" keypress does not fire immediately on some systems or keyboard layouts from Keyboard bindings missing? to DarkConsole "`" keypress does not fire immediately on some systems or keyboard layouts.
Jul 8 2016, 11:38 AM · Bug Report (Needs Information)
epriestley added a revision to T11295: Worker queue 404 page fails with invalid `$header`: Restricted Differential Revision.
Jul 8 2016, 11:34 AM · Daemons, Bug Report
epriestley added projects to T11295: Worker queue 404 page fails with invalid `$header`: Bug Report, Daemons.
Jul 8 2016, 11:29 AM · Daemons, Bug Report
epriestley added a comment to T11291: Error while executing task (phd daemon).

Your database may not have proper column encodings configured. Run this command to verify them:

Jul 8 2016, 11:29 AM · Daemons, Bug Report
epriestley added a comment to T11293: Show the repo name in the Owners app's "paths" editor.

D16253 should fix this; a quasi-workaround in the meantime is to set "Short Names" on repositories.

Jul 8 2016, 11:19 AM · Owners, Bug Report
epriestley claimed T11293: Show the repo name in the Owners app's "paths" editor.
Jul 8 2016, 11:19 AM · Owners, Bug Report
chr86 added a comment to T11280: Archiving/Activating Pastes reflects wrong in Recent Activity Log.

Thanks for the quick replies and actions, this is greatly appreciated.

Jul 8 2016, 7:46 AM · Paste, Bug Report
chad added a comment to T11269: Repository update command fails on empty Git repositories.

I can't think of any reason it would ask that unless something changed locally. If you have no local changes to phabricator/, just reset to HEAD.

Jul 8 2016, 4:31 AM · Diffusion, Bug Report
• minishine added a comment to T11269: Repository update command fails on empty Git repositories.

@chad I don't know, I installed phabricator under the direction of doc and then resolved some setup Issues.

Jul 8 2016, 3:22 AM · Diffusion, Bug Report
epriestley added a comment to T11292: Permanent failure while executing Task ID <id>.

(Or likewise with the task ID.)

Jul 8 2016, 12:01 AM · Bug Report
epriestley added a comment to T11292: Permanent failure while executing Task ID <id>.

Is the commit ID exactly the same each time, or does it change?

Jul 8 2016, 12:01 AM · Bug Report

Jul 7 2016

jsturgeon added a comment to T11292: Permanent failure while executing Task ID <id>.

Correction, not hanging, but continuously re-scheduling that task in the queue (which is slowing up the queue significantly)

Jul 7 2016, 11:43 PM · Bug Report
jsturgeon updated subscribers of T11292: Permanent failure while executing Task ID <id>.
Jul 7 2016, 11:40 PM · Bug Report
jsturgeon created T11292: Permanent failure while executing Task ID <id>.
Jul 7 2016, 11:40 PM · Bug Report
jsturgeon added a comment to T11291: Error while executing task (phd daemon).

Follow up question, this task has failed 38022 times.. is there some way I can punt it from our queue?

Jul 7 2016, 11:21 PM · Daemons, Bug Report
jsturgeon updated subscribers of T11291: Error while executing task (phd daemon).
Jul 7 2016, 11:12 PM · Daemons, Bug Report
jsturgeon created T11291: Error while executing task (phd daemon).
Jul 7 2016, 11:12 PM · Daemons, Bug Report
epriestley added a comment to T11271: Inconsistency in project membership displaying.

No problem, thanks for the followup!

Jul 7 2016, 11:10 PM · Projects, People, Bug Report
20after4 closed T11271: Inconsistency in project membership displaying as Invalid.

@epriestley - this is caused by a downstream patch which intentionally excludes sprints from the displayed groups.

Jul 7 2016, 11:10 PM · Projects, People, Bug Report
epriestley closed T11092: Review comments lost or posted to wrong diff as Resolved.

Presuming this is resolved now, let us know if you're still seeing issues.

Jul 7 2016, 10:54 PM · Differential, Bug Report
avivey merged task T10936: arc feature error while creating a new feature branch into T8298: Fix Windows Escaping.
Jul 7 2016, 10:00 PM · Windows, Arcanist, Bug Report
avivey added a project to T10936: arc feature error while creating a new feature branch: Windows.
Jul 7 2016, 9:59 PM · Windows, Arcanist, Bug Report
epriestley closed T11285: PhabricatorApplicationTransactionPublishWorker fails on bad getURI call as Resolved by committing Restricted Diffusion Commit.
Jul 7 2016, 9:55 PM · Bug Report
epriestley added a revision to T11285: PhabricatorApplicationTransactionPublishWorker fails on bad getURI call: Restricted Differential Revision.
Jul 7 2016, 9:53 PM · Bug Report
epriestley added a comment to T11289: Missing avatar in Feed for Test Notifications.

I intend to remove them from feed, but it might have just been on a diff somewhere and not made it to a task.

Jul 7 2016, 7:43 PM · Bug Report
chad updated subscribers of T11289: Missing avatar in Feed for Test Notifications.

I can't find the task. I'm like 98% sure @epriestley made one because someone kept spamming it on us.

Jul 7 2016, 7:41 PM · Bug Report
chad added a comment to T11289: Missing avatar in Feed for Test Notifications.

test notifications

Jul 7 2016, 7:33 PM · Bug Report
aik099 added a comment to T11289: Missing avatar in Feed for Test Notifications.

We'll eventually not publish stories at all ...

Jul 7 2016, 7:32 PM · Bug Report
chad closed T11289: Missing avatar in Feed for Test Notifications as Wontfix.

We'll eventually not publish stories at all (i think there is another task, just can't find it). For now though this is working as intended.

Jul 7 2016, 6:53 PM · Bug Report
aik099 created T11289: Missing avatar in Feed for Test Notifications.
Jul 7 2016, 6:45 PM · Bug Report
eadler added a project to T10393: Differential revision's images cannot be viewed as raw files: Restricted Project.
Jul 7 2016, 5:21 PM · Restricted Project, Differential, Files, Bug Report
eadler added a project to T10725: Can't access binary files of differential revision: Restricted Project.
Jul 7 2016, 5:19 PM · Restricted Project, Differential, Bug Report
rencris updated the task description for T11285: PhabricatorApplicationTransactionPublishWorker fails on bad getURI call.
Jul 7 2016, 4:25 PM · Bug Report
rencris added a comment to T11285: PhabricatorApplicationTransactionPublishWorker fails on bad getURI call.

I've looked at the database, specifically the worker_activetask table. The bad transactions appear to be linked to profile panel objects (objectPHID like PHID-PANL-...).

Jul 7 2016, 4:22 PM · Bug Report
rencris created T11285: PhabricatorApplicationTransactionPublishWorker fails on bad getURI call.
Jul 7 2016, 3:41 PM · Bug Report
chad added a comment to T11269: Repository update command fails on empty Git repositories.

Why do you have local changes in your phabricator folder?

Jul 7 2016, 1:52 PM · Diffusion, Bug Report
• minishine added a comment to T11269: Repository update command fails on empty Git repositories.

Sorry to trouble you @epriestley , I have the same question(T11273) . After your committing rP5ffdb732735c, I tried to update my phabricator under the direction of doc(https://secure.phabricator.com/book/phabricator/article/upgrading/). While I executed git pull,the terminal shows

屏幕快照 2016-07-07 15.45.45.png (262×1 px, 61 KB)
. So should I commit local changes or checkout them?

Jul 7 2016, 7:49 AM · Diffusion, Bug Report

Jul 6 2016

chad added a comment to T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.

It was merged into master today.

Jul 6 2016, 7:33 PM · Daemons, Bug Report
ftdysa added a comment to T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.

Looks like this should be available in 7.1 btw: https://wiki.php.net/rfc/async_signals#proposed_voting_choices.

Jul 6 2016, 7:12 PM · Daemons, Bug Report
chad merged task T11283: Make Task Graph Collapsable into T4788: Allow "Edit Dependencies" both ways (blocking and depending).
Jul 6 2016, 6:28 PM · Maniphest, Bug Report
CodeMouse92 created T11283: Make Task Graph Collapsable.
Jul 6 2016, 6:06 PM · Maniphest, Bug Report
chad updated the image for Bug Report from Unknown Object (File) to Unknown Object (File).
Jul 6 2016, 4:41 PM
epriestley added a comment to T11280: Archiving/Activating Pastes reflects wrong in Recent Activity Log.

Thanks for the report! This should be resolved in HEAD of master.

Jul 6 2016, 2:21 PM · Paste, Bug Report
epriestley closed T11280: Archiving/Activating Pastes reflects wrong in Recent Activity Log as Resolved by committing Restricted Diffusion Commit.
Jul 6 2016, 2:17 PM · Paste, Bug Report
plehmkuhl added a comment to T10750: Cannot Edit Comment on Files.

We are also able to reproduce this on our installation.
Currently we are using Version 05699388804fc6ae1df5a17559917d218c4ec26d of phabricator.

Jul 6 2016, 11:15 AM · Files, Bug Report
epriestley added a revision to T11280: Archiving/Activating Pastes reflects wrong in Recent Activity Log: Restricted Differential Revision.
Jul 6 2016, 11:00 AM · Paste, Bug Report
epriestley claimed T11280: Archiving/Activating Pastes reflects wrong in Recent Activity Log.
Jul 6 2016, 10:59 AM · Paste, Bug Report
chr86 created T11280: Archiving/Activating Pastes reflects wrong in Recent Activity Log.
Jul 6 2016, 9:29 AM · Paste, Bug Report
hach-que closed T11279: Phabricator daemon fails when updating repository (daemon status Running -> Unknown -> Dead ) as Invalid.

Your answer is right here:

Jul 6 2016, 7:07 AM · Bug Report
• leeray created T11279: Phabricator daemon fails when updating repository (daemon status Running -> Unknown -> Dead ).
Jul 6 2016, 6:38 AM · Bug Report
• vanblaze added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

Thanks.

Jul 6 2016, 1:50 AM · Design, Diffusion
chad closed T11278: It's confusing to figure out in the UI how to import a repository now as Invalid.

https://secure.phabricator.com/book/phabricator/article/diffusion_uris/

Jul 6 2016, 1:47 AM · Design, Diffusion
• vanblaze created T11278: It's confusing to figure out in the UI how to import a repository now.
Jul 6 2016, 1:44 AM · Design, Diffusion

Jul 5 2016

epriestley closed T11275: Missing "Edit Queries..." and "Advanced Search" pages in User Settings as Resolved by committing Restricted Diffusion Commit.
Jul 5 2016, 11:55 PM · Bug Report
epriestley closed T11276: diffusion.uri.edit for creating an object fails depending on order of transactions in input as Resolved by committing Restricted Diffusion Commit.
Jul 5 2016, 11:45 PM · ApplicationEditor, Conduit, Bug Report
epriestley added a revision to T11275: Missing "Edit Queries..." and "Advanced Search" pages in User Settings: Restricted Differential Revision.
Jul 5 2016, 11:45 PM · Bug Report
epriestley added a revision to T11276: diffusion.uri.edit for creating an object fails depending on order of transactions in input: Restricted Differential Revision.
Jul 5 2016, 11:40 PM · ApplicationEditor, Conduit, Bug Report
epriestley added a comment to T11276: diffusion.uri.edit for creating an object fails depending on order of transactions in input.

A possible alternate approach would be to attachRepository() as a side-effect of validating the transaction instead of while applying the transaction, but then if something throws between the "validate" and "apply" steps we could end up with a URI in a weird state. That probably never actually matters, but feels a little more awkward to me than ordering the transactions.

Jul 5 2016, 11:34 PM · ApplicationEditor, Conduit, Bug Report
avivey added a comment to T11276: diffusion.uri.edit for creating an object fails depending on order of transactions in input.

ok, that makes sense.

Jul 5 2016, 11:32 PM · ApplicationEditor, Conduit, Bug Report
epriestley added a comment to T11276: diffusion.uri.edit for creating an object fails depending on order of transactions in input.

It's impossible to create a URI without a repository transaction (it doesn't make sense, since URI objects can't just exist), and we already give you an appropriate error when you try:

Jul 5 2016, 11:31 PM · ApplicationEditor, Conduit, Bug Report
avivey added a comment to T11276: diffusion.uri.edit for creating an object fails depending on order of transactions in input.

That kinda feels like a band-aid... Shouldn't we be able to not-crash for any input? Like if a user will only provide a uri transaction?

Jul 5 2016, 11:22 PM · ApplicationEditor, Conduit, Bug Report
epriestley added a comment to T11276: diffusion.uri.edit for creating an object fails depending on order of transactions in input.

My initial thought is that we should just reorder these transactions. We should use a stable sort, but that's relatively easy now that we have msortv(). There are probably a handful of other transactions with similar properties in other object types.

Jul 5 2016, 9:10 PM · ApplicationEditor, Conduit, Bug Report
avivey renamed T11276: diffusion.uri.edit for creating an object fails depending on order of transactions in input from diffusion.uri.edit fails depending on order of transactions in input to diffusion.uri.edit for creating an object fails depending on order of transactions in input.
Jul 5 2016, 8:43 PM · ApplicationEditor, Conduit, Bug Report
avivey created T11276: diffusion.uri.edit for creating an object fails depending on order of transactions in input.
Jul 5 2016, 8:42 PM · ApplicationEditor, Conduit, Bug Report
jack.chung added a comment to T10456: Conduit interprets all arguments from curl requests as strings.

if it helps anyone, the workaround "fix" is to place the following code in the file "src/applications/conduit/parametertype/ConduitBoolParameterType.php "

Jul 5 2016, 8:26 PM · Restricted Project, Conduit, Bug Report
aik099 created T11275: Missing "Edit Queries..." and "Advanced Search" pages in User Settings.
Jul 5 2016, 7:48 PM · Bug Report
epriestley added a comment to T11269: Repository update command fails on empty Git repositories.

Thanks for the report! I believe this should now be resolved in HEAD of master.

Jul 5 2016, 4:10 PM · Diffusion, Bug Report
epriestley closed T11269: Repository update command fails on empty Git repositories as Resolved by committing Restricted Diffusion Commit.
Jul 5 2016, 4:09 PM · Diffusion, Bug Report
epriestley added a comment to T10633: Render timezones explicitly in email.

T9854 is also vaguely related, but fairly separate.

Jul 5 2016, 4:06 PM · Calendar, Mail, Countdown, Bug Report
epriestley added a revision to T11269: Repository update command fails on empty Git repositories: Restricted Differential Revision.
Jul 5 2016, 3:30 PM · Diffusion, Bug Report
epriestley claimed T11269: Repository update command fails on empty Git repositories.
Jul 5 2016, 3:26 PM · Diffusion, Bug Report
epriestley merged T11273: Update error while Repository Updates into T11269: Repository update command fails on empty Git repositories.
Jul 5 2016, 3:26 PM · Diffusion, Bug Report
epriestley merged task T11273: Update error while Repository Updates into T11269: Repository update command fails on empty Git repositories.
Jul 5 2016, 3:26 PM · Bug Report
epriestley added a comment to T11273: Update error while Repository Updates .

I'm going to merge this into T11269, which I believe describes the same problem.

Jul 5 2016, 3:25 PM · Bug Report
epriestley added a comment to T11274: Task Graph has extra vertical space on tickets with titles that run onto multiple lines.

Thanks for the report! I think this should be fixed at HEAD of master. Let us know if you're still seeing issues after updating.

Jul 5 2016, 3:11 PM · Bug Report
epriestley closed T11274: Task Graph has extra vertical space on tickets with titles that run onto multiple lines as Resolved by committing Restricted Diffusion Commit.
Jul 5 2016, 3:00 PM · Bug Report
aubort added a comment to T11273: Update error while Repository Updates .

I'm having the same issue since I updated from week 21 to week 27, it happens on empty repositories.

Jul 5 2016, 2:54 PM · Bug Report
epriestley claimed T11274: Task Graph has extra vertical space on tickets with titles that run onto multiple lines.
Jul 5 2016, 1:55 PM · Bug Report
epriestley added a revision to T11274: Task Graph has extra vertical space on tickets with titles that run onto multiple lines: Restricted Differential Revision.
Jul 5 2016, 1:54 PM · Bug Report
trevorsummerssmith created T11274: Task Graph has extra vertical space on tickets with titles that run onto multiple lines.
Jul 5 2016, 1:46 PM · Bug Report
epriestley added a comment to T10745: Emails are sent out about restricted changes.

The support cost for the current behavior is very small. The behavior of the system is obvious. Users can file precise tasks like this one which clearly describe the problem (or find this task):

Jul 5 2016, 1:45 PM · Restricted Project, Bug Report
epriestley merged task T11272: Passphrases requires Editable By status for Read access into T4721: Improve user-facing documentation for Passphrase.
Jul 5 2016, 12:36 PM · Bug Report
epriestley added a comment to T11272: Passphrases requires Editable By status for Read access.

This behavior is intentional; it allows users to use a credential to configure other applications without actually having access to the plaintext.

Jul 5 2016, 12:36 PM · Bug Report
• minishine updated the task description for T11273: Update error while Repository Updates .
Jul 5 2016, 11:34 AM · Bug Report
• minishine updated the task description for T11273: Update error while Repository Updates .
Jul 5 2016, 11:28 AM · Bug Report
• minishine updated the task description for T11273: Update error while Repository Updates .
Jul 5 2016, 11:28 AM · Bug Report
• minishine created T11273: Update error while Repository Updates .
Jul 5 2016, 11:25 AM · Bug Report
vpetersson created T11272: Passphrases requires Editable By status for Read access.
Jul 5 2016, 11:24 AM · Bug Report
lucaro added a comment to T11267: Commit graph broken for Mercurial repositories.

Thanks for the quick response. I'll let you know as soon as the change gets merged into stable.

Jul 5 2016, 6:54 AM · Diffusion, Bug Report
Mnkras added a comment to T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.

Of course! Thanks for poking around!

Jul 5 2016, 5:55 AM · Daemons, Bug Report
MZMcBride added a comment to T10745: Emails are sent out about restricted changes.

I received this e-mail recently:

Jul 5 2016, 4:23 AM · Restricted Project, Bug Report