Page MenuHomePhabricator
Feed Advanced Search

May 22 2016

epriestley closed T10808: differential.querydiffs method does not provide "local:commits" as Resolved.

Presuming resolved by D15710.

May 22 2016, 1:11 PM · Differential, Bug Report
epriestley added a comment to T10850: Search revisions by "Repository Projects".

You can likely do this:

May 22 2016, 1:11 PM · Restricted Project, Restricted Project, Differential, Feature Request
epriestley moved T10953: Show maximal amount of context for the selected change in differential, rather than snapping it at the top of the screen from Backlog to Far Future Work on the Differential board.
May 22 2016, 1:06 PM · Differential, Feature Request
epriestley triaged T10953: Show maximal amount of context for the selected change in differential, rather than snapping it at the top of the screen as Wishlist priority.
May 22 2016, 1:05 PM · Differential, Feature Request
epriestley renamed T10954: Differential keyboard shortcut inline selection reticle is visually unclear (bad z-index?) from Differential keyboard inline selection reticle is visually unclear (bad z-index?) to Differential keyboard shortcut inline selection reticle is visually unclear (bad z-index?).
May 22 2016, 1:02 PM · Inline Comments, Differential, Feature Request
epriestley renamed T10954: Differential keyboard shortcut inline selection reticle is visually unclear (bad z-index?) from Make selected change more obvious to Differential keyboard inline selection reticle is visually unclear (bad z-index?).
May 22 2016, 1:02 PM · Inline Comments, Differential, Feature Request
epriestley renamed T10967: Move Differential reviewers back to a dedicated database storage table from Move Differential reviewers back to a dedicated table to Move Differential reviewers back to a dedicated database storage table.
May 22 2016, 1:01 PM · Restricted Project, Infrastructure, Differential
epriestley added a comment to M1464: Curtain v2.

One other possibly-bad idea I had was to show only one of these:

May 22 2016, 1:00 PM · PHUI
epriestley added a comment to M1464: Curtain v2.

I think it actually aligns in practice (e.g., see Differential).

May 22 2016, 12:33 AM · PHUI

May 21 2016

epriestley added a comment to M1464: Curtain v2.

Tokens being its own separate island seems conceptually fine to me, although I tend to agree that subscribe is maybe a little weird to disconnect.

May 21 2016, 8:19 PM · PHUI
epriestley added a comment to M1464: Curtain v2.

Yeah, should be no problem to do mobile magic if that seems like the most promising way forward.

May 21 2016, 8:14 PM · PHUI
epriestley added a comment to M1464: Curtain v2.

Oh, notable community member @avivey also raised a concern about hiding options in a dropdown in T8172#117058. :)

May 21 2016, 7:55 PM · PHUI
epriestley added a comment to M1464: Curtain v2.

I've historically pushed against hiding actions in a submenu, since I think it's a pretty big negative for usability. I'm not totally opposed to heading in that direction but I personally prefer the space being used for actions over any other content. At least today, some of the actions also communicate stateful information ("Automatically Subscribed" shows your subscription state, "Flag for Later" shows the current flag).

May 21 2016, 7:54 PM · PHUI
epriestley added a comment to M1464: Curtain v2.

The "pull the whole panel out as a curtain widget" approach might also work better for third-party extensions and Phrequent, which isn't enabled on this install but is technically part of the upstream. Maybe the pathway forward there is "delete Phrequent + no support for extending this", of course.

May 21 2016, 7:46 PM · PHUI
epriestley added a comment to M1464: Curtain v2.

These would become "Unsubscribe" and "Revoke Token" in the same spot?

May 21 2016, 7:43 PM · PHUI
epriestley added a comment to T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them.

D15961 adds a timezone correction workflow, including a temporary "ignore conflict" option. This flag is cleared after the next timezone change.

May 21 2016, 7:33 PM · Prioritized, Restricted Project, User Preferences
epriestley added a revision to T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them: Unknown Object (Differential Revision).
May 21 2016, 7:18 PM · Prioritized, Restricted Project, User Preferences
epriestley added a comment to T10512: Implement `user.search` Conduit API method.

After D15959, user.search should support "find all non-disabled human users", likely with parameters in this vein:

May 21 2016, 5:32 PM · Prioritized, Restricted Project, People, Conduit, Feature Request
epriestley added a revision to T10512: Implement `user.search` Conduit API method: Unknown Object (Differential Revision).
May 21 2016, 5:28 PM · Prioritized, Restricted Project, People, Conduit, Feature Request
epriestley added a comment to T10512: Implement `user.search` Conduit API method.

I think T5953 is a better fit for that in the upstream.

May 21 2016, 5:03 PM · Prioritized, Restricted Project, People, Conduit, Feature Request
epriestley closed T11005: Array as Spite.
May 21 2016, 3:37 PM
epriestley closed T11007: 这是一个测试 as Spite.
May 21 2016, 3:37 PM
epriestley closed T11006: 这是一个测试 as Spite.
May 21 2016, 3:37 PM
epriestley removed a project from T5000: Using Differential with plain Git, without requiring Arc: Prioritized.
May 21 2016, 2:37 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Differential, Arcanist
epriestley added a comment to T10691: Support GitHub-like forking of repositories.

If there's interest in prioritizing this directly or via T5000 I'm comfortable committing to an 80-hour estimate to support these use cases:

May 21 2016, 2:33 PM · Restricted Project, Diffusion, Feature Request
epriestley added a subtask for T5000: Using Differential with plain Git, without requiring Arc: T10691: Support GitHub-like forking of repositories.
May 21 2016, 2:15 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Differential, Arcanist
epriestley added a parent task for T10691: Support GitHub-like forking of repositories: T5000: Using Differential with plain Git, without requiring Arc.
May 21 2016, 2:15 PM · Restricted Project, Diffusion, Feature Request
epriestley added a comment to T5000: Using Differential with plain Git, without requiring Arc.

Another possibility is that we just build this behavior (intercept and react to ref changes) as an extension point prior to the Herald, and then you can implement whatever magic you want. I suspect very few installs want the default behavior of git push origin mybranch for arbitrarily named branches to be anything except "create a branch".

May 21 2016, 2:15 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Differential, Arcanist
epriestley added a comment to T5000: Using Differential with plain Git, without requiring Arc.

So your desired behavior is that git push origin develop should create a revision, instead of creating a new branch in the remote like a normal Git repository would? How would users create new branches in this model?

May 21 2016, 1:32 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Differential, Arcanist
epriestley added a comment to T5000: Using Differential with plain Git, without requiring Arc.

non-master branches in the repository would be Differential Revisions

May 21 2016, 11:56 AM · KDE, FreeBSD, Restricted Project, Haskell.org, Differential, Arcanist
epriestley added a comment to T11004: git URI normalization is not reliable.

Ugh.

May 21 2016, 12:55 AM · Diffusion, Bug Report
epriestley moved T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them from Backlog to Preflight on the Prioritized board.
May 21 2016, 12:53 AM · Prioritized, Restricted Project, User Preferences
epriestley moved T10512: Implement `user.search` Conduit API method from Backlog to Preflight on the Prioritized board.
May 21 2016, 12:53 AM · Prioritized, Restricted Project, People, Conduit, Feature Request
epriestley added a project to T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them: Prioritized.
May 21 2016, 12:53 AM · Prioritized, Restricted Project, User Preferences
epriestley added a project to T10512: Implement `user.search` Conduit API method: Prioritized.
May 21 2016, 12:53 AM · Prioritized, Restricted Project, People, Conduit, Feature Request
epriestley edited the content of Changelog.
May 21 2016, 12:06 AM
epriestley created 2016 Week 21 (Late May).
May 21 2016, 12:06 AM

May 20 2016

epriestley moved T5187: Make "Upload File" dialog have a vanilla file upload control from The Queue to Paused on the Prioritized board.

This is in master and live on this install. Let me know if you hit issues with it, especially on mobile. Seems fine on my iPhone 4 but I don't have a ton of devices on hand for testing.

May 20 2016, 11:41 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley added a comment to T5000: Using Differential with plain Git, without requiring Arc.

Phabricator doesn't give me an option to say "this commit depends on this other commit, so you can review it on its own but don't try to merge it yet".

May 20 2016, 11:04 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Differential, Arcanist
epriestley added a comment to T5000: Using Differential with plain Git, without requiring Arc.

Wow, good job! Check out your review at https://secure.example.com/D1234

May 20 2016, 10:41 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Differential, Arcanist
epriestley added a comment to T5000: Using Differential with plain Git, without requiring Arc.

IIRC, we copy/pasted at Facebook for quite a while -- maybe 6-12 months, circa 2007, before arc and related tools really got built out -- without ever running into wordwrap/whitespace issues.

May 20 2016, 10:14 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Differential, Arcanist
epriestley added a comment to T8629: Create some kind of queue of profile/settings action items for users.

To install:

May 20 2016, 10:07 PM · Restricted Project, People
epriestley added a comment to T8629: Create some kind of queue of profile/settings action items for users.

Alright, let me sketch out the "missing X account" thing.

May 20 2016, 9:40 PM · Restricted Project, People
epriestley added a comment to T8629: Create some kind of queue of profile/settings action items for users.

Maybe a good way to attack this is to discuss specific notifications. I think the use cases we're aware of are:

May 20 2016, 9:30 PM · Restricted Project, People
epriestley added a comment to T5000: Using Differential with plain Git, without requiring Arc.

Git protocol rewriting appears practical.

May 20 2016, 8:59 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Differential, Arcanist
epriestley added a revision to T5000: Using Differential with plain Git, without requiring Arc: Unknown Object (Differential Revision).
May 20 2016, 6:14 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Differential, Arcanist
epriestley added a comment to T5000: Using Differential with plain Git, without requiring Arc.

The Git wire format for PACK data is very special, here's how you read the length of an entry:

May 20 2016, 5:53 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Differential, Arcanist
epriestley created T10999: Expand MFA checks to all email operations.
May 20 2016, 4:48 PM · Contributor Onboarding, Security
epriestley added a comment to T5000: Using Differential with plain Git, without requiring Arc.

@fooishbar, this task will not address your use case. We will, as closely as possible, implement arc semantics without requiring arc. The primary upstream motivation for this workflow is to provide a stepping stone toward arc which is as similar as possible to the arc workfow, not to provide a new, entirely different workflow which would make adopting arc more confusing and difficult.

May 20 2016, 4:34 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Differential, Arcanist
epriestley added a comment to T5000: Using Differential with plain Git, without requiring Arc.

Major unknown here is the complexity of decoding the Git wire protocol. The D9599 workflow goes like this:

May 20 2016, 4:17 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Differential, Arcanist
epriestley added a comment to T10751: Make Phabricator Highly Available.

Two of the three issues discussed above (lock granularity, severity of device enrollment) got tackled. I think I have an attack on versioning hosted repositories, but I'm not going to try to squeeze it in before the release cut today.

May 20 2016, 2:47 PM · Restricted Project, Infrastructure, Prioritized
epriestley moved T5000: Using Differential with plain Git, without requiring Arc from Preflight to The Queue on the Prioritized board.
May 20 2016, 2:37 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Differential, Arcanist
epriestley added a comment to T5187: Make "Upload File" dialog have a vanilla file upload control.

D15953 played out more or less as described above. I'm not going to land it before cutting stable this week since it touches Workflow in a couple of ways that might have unforseen consequences, but I expect it to be available in master some time later tonight or tomorrow.

May 20 2016, 2:37 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley added a revision to T5187: Make "Upload File" dialog have a vanilla file upload control: Unknown Object (Differential Revision).
May 20 2016, 2:36 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley added a comment to T5187: Make "Upload File" dialog have a vanilla file upload control.

After D12066, we have an upload workflow which gracefully accommodates very large files (progress bars, resumable uploads, no server host needs to handle more than 4MB of data on disk or in memory at once). This flow is activated when you drag-and-drop, and we've successfully used it to transfer reasonably-sized cluster import/export files (1-2GB) for the better part of a year now.

May 20 2016, 1:12 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley closed T10995: 首页页码条显示错误 as Spite.
May 20 2016, 12:32 PM · Calendar, Bug Report
epriestley closed T10996: https://phabricator.wikimedia.org/ as Invalid.

Not sure if this was just a test or not, but it's doesn't look like a bug report. See Contributing Bug Reports for help writing good bug reports.

May 20 2016, 12:32 PM · Wikimedia, Bug Report
epriestley added a member for Community: qgil.
May 20 2016, 12:31 PM
benjumanji awarded T4214: Allow installs to change or supplement the "Phabricator" icon a Love token.
May 20 2016, 12:05 PM · Design
monsdar awarded T10978: Modernize Audit a Like token.
May 20 2016, 11:38 AM · Audit
epriestley closed T10993: `arc diff` uploads an update to the dependent Diff instead of creating a new diff as Resolved.
May 20 2016, 4:47 AM · Bug Report
epriestley added a comment to T10993: `arc diff` uploads an update to the dependent Diff instead of creating a new diff.

What does arc which say before you run the final arc diff?

May 20 2016, 1:31 AM · Bug Report

May 19 2016

epriestley moved T10939: Support for OWNERS files from The Queue to Paused on the Prioritized board.

That cleanup stuff should be cleaned up now, so I'm formally pausing this for feedback.

May 19 2016, 10:26 PM · Prioritized, Restricted Project, Owners
epriestley moved T10917: Build Glorious High-Security Notification/Audit Infrastructure from The Queue to Paused on the Prioritized board.

In HEAD of master, keys now have a detail screen which shows a transaction record. Clicking the key name will take you there:

May 19 2016, 10:20 PM · Auth, Prioritized, Security, Feature Request
epriestley added a revision to T10917: Build Glorious High-Security Notification/Audit Infrastructure: Unknown Object (Differential Revision).
May 19 2016, 10:13 PM · Auth, Prioritized, Security, Feature Request
epriestley closed T10991: Clustering Introduction links to non-existent Drydock Security documentation as Resolved by committing Restricted Diffusion Commit.
May 19 2016, 9:59 PM · Documentation, Bug Report
epriestley added a revision to T10939: Support for OWNERS files: Unknown Object (Differential Revision).
May 19 2016, 8:46 PM · Prioritized, Restricted Project, Owners
epriestley added a revision to T10939: Support for OWNERS files: Unknown Object (Differential Revision).
May 19 2016, 8:32 PM · Prioritized, Restricted Project, Owners
epriestley added a revision to T10991: Clustering Introduction links to non-existent Drydock Security documentation: Unknown Object (Differential Revision).
May 19 2016, 7:35 PM · Documentation, Bug Report
epriestley claimed T10991: Clustering Introduction links to non-existent Drydock Security documentation.
May 19 2016, 7:34 PM · Documentation, Bug Report
epriestley added a revision to T10917: Build Glorious High-Security Notification/Audit Infrastructure: Unknown Object (Differential Revision).
May 19 2016, 6:04 PM · Auth, Prioritized, Security, Feature Request
epriestley added a revision to T10917: Build Glorious High-Security Notification/Audit Infrastructure: Unknown Object (Differential Revision).
May 19 2016, 5:20 PM · Auth, Prioritized, Security, Feature Request
epriestley added a revision to T10917: Build Glorious High-Security Notification/Audit Infrastructure: Unknown Object (Differential Revision).
May 19 2016, 4:06 PM · Auth, Prioritized, Security, Feature Request
epriestley added a comment to T10990: Diffusion/Doc: add systemd Unit file to Diffusion_Hosting SSHD Documentation.

See some discussion of SELinux in T4947. We'd prefer to find a way to detect that SELinux or AppArmor are running, and warn the user only if they are affected. We've generally had much greater success with raising specific setup warnings during setup than with putting notes in documentation (which users often do not read). We do not currently have a test for SELinux / AppArmor, although it is possible that these tests are straightforward.

May 19 2016, 2:25 PM · Feature Request
epriestley added a comment to T10989: Moving task in the same column of the workboard causes its update.

Third-party applications which assume dateModified means "last 'meaningful' update" are written incorrectly. It does not mean that, it is not documented to mean that anywhere, and it is clear from the code that it doesn't have this behavior. It is unreasonable to assume that the only possible purpose of this field is metric extraction. This field is a low-level field which serves a different set of goals. It explicitly does not serve metric extraction goals.

May 19 2016, 1:46 PM · Workboards, Bug Report
epriestley added a comment to T10939: Support for OWNERS files.

Ah! Okay, cool. Not really PEBCAK, I need to fix that dashboard too and it's super confusing that it does something weird/different with no clues about it. I just wanted to see if anyone caught major issues with the new one before swapping it.

May 19 2016, 1:21 PM · Prioritized, Restricted Project, Owners
epriestley added a comment to T10989: Moving task in the same column of the workboard causes its update.

In fact it breaks various monitoring/statistics depending on last update

May 19 2016, 12:55 PM · Workboards, Bug Report
epriestley closed T10990: Diffusion/Doc: add systemd Unit file to Diffusion_Hosting SSHD Documentation as Wontfix.

System-specific configuration like SELinux and systemd is outside the scope of Phabricator. See T4200 for discussion.

May 19 2016, 12:27 PM · Feature Request
epriestley closed T10988: Unable to Import an Existing External Repository as Invalid.

https://secure.phabricator.com/book/phabricator/article/diffusion_uris/#observe-a-repository

May 19 2016, 12:24 PM · Bug Report
epriestley closed T10989: Moving task in the same column of the workboard causes its update as Invalid.

"Last Update" is low level, and includes some actions which do not appear in the task history. This is expected.

May 19 2016, 12:22 PM · Workboards, Bug Report

May 18 2016

epriestley closed T10985: Color change as Spite.
May 18 2016, 10:20 PM · Feature Request
epriestley moved T10694: Improve behavior of context for inline comments in mail from The Queue to Paused on the Prioritized board.

Inlined patches are now highlighted more nicely in HTML mail.

May 18 2016, 10:19 PM · Prioritized, Restricted Project, Differential, Mail
epriestley added a comment to T10939: Support for OWNERS files.

The default is still

May 18 2016, 7:45 PM · Prioritized, Restricted Project, Owners
epriestley added a comment to T10939: Support for OWNERS files.

That's not expected, but I can't immediately reproduce it. Here's my local install, note that D4 appears in "Ready to Review" even though I (admin) am only a reviewer via project membership in Stonework (a project):

May 18 2016, 7:43 PM · Prioritized, Restricted Project, Owners
epriestley closed T10980: Code coverage details on Phab as Invalid.
May 18 2016, 7:38 PM · Bug Report
epriestley closed T10984: arc diff to put Revision URI into clipboard as Wontfix.

I also agree with @chad in the general sense -- this use case seems pretty weird to me and is entirely unlike anything we're aware of in other installs. If email notifications are deficient in some way, we'd prefer to address that.

May 18 2016, 6:58 PM · Feature Request
epriestley added a comment to T10984: arc diff to put Revision URI into clipboard.

I suppose you can arc set-config browser <something>, where <something> is a script which copies argv[1] to the clipboard and then exits, then run arc diff --browse.

May 18 2016, 6:55 PM · Feature Request
epriestley added a revision to T10917: Build Glorious High-Security Notification/Audit Infrastructure: Unknown Object (Differential Revision).
May 18 2016, 4:46 PM · Auth, Prioritized, Security, Feature Request
epriestley added a comment to T10983: Make the !accept email command configurable such that it only works if the diff was inlined.

Roughly, you should be able to:

May 18 2016, 4:12 PM · Feature Request
epriestley added a comment to T10983: Make the !accept email command configurable such that it only works if the diff was inlined.

You can subclass MetaMTAEmailTransactionCommand, following DifferentialActionEmailCommand (which does Differential stuff) and ManiphestPriorityEmailCommand (which is a better example of implementing an individual command), to implement !hahaha-yes-i-definitely-reviewed-this-hahaha which applies !accept only for small diffs.

May 18 2016, 4:06 PM · Feature Request
epriestley added a comment to T10917: Build Glorious High-Security Notification/Audit Infrastructure.

Here's my technical plan on this:

May 18 2016, 3:26 PM · Auth, Prioritized, Security, Feature Request
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

We can't easily link to an #anchor from email because the transactions that render in email are different from the transactions that render on the web. For example, T10493 is a case that specifically shows a transaction in email but not on the web. Since it doesn't exist on the web, we can't easily generate an anchor to the corresponding transaction because no web version of that transaction exists. This behavior is not unique to that transaction type. Anchor generation is also more complex than this for other reasons (for example, transaction are grouped, aggregated and reordered at display time, and these changes affect which anchors are available).

May 18 2016, 2:30 PM · Prioritized, Transactions
epriestley added a comment to T10493: Task creation no longer lists projects added (neither the UI nor mail notifications).

D15942 restores the project tag transaction to the first mail about an object:

May 18 2016, 2:12 PM · Wikimedia, Notifications, Projects (v3), Bug Report
epriestley closed T10493: Task creation no longer lists projects added (neither the UI nor mail notifications) as Resolved by committing Restricted Diffusion Commit.
May 18 2016, 2:09 PM · Wikimedia, Notifications, Projects (v3), Bug Report
epriestley added a comment to T10493: Task creation no longer lists projects added (neither the UI nor mail notifications).

I guess this originally had several different parts. My thinking on the parts are:

May 18 2016, 2:07 PM · Wikimedia, Notifications, Projects (v3), Bug Report
epriestley added a revision to T10493: Task creation no longer lists projects added (neither the UI nor mail notifications): Unknown Object (Differential Revision).
May 18 2016, 1:59 PM · Wikimedia, Notifications, Projects (v3), Bug Report
epriestley added a comment to T10493: Task creation no longer lists projects added (neither the UI nor mail notifications).

I think we're mostly unsure what we want to do here.

May 18 2016, 1:51 PM · Wikimedia, Notifications, Projects (v3), Bug Report
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

Yes. I think this has two general components:

May 18 2016, 1:43 PM · Prioritized, Transactions
epriestley closed T10977: Unknown Object (User) in Conpherence as Invalid.

These tattered edges are an expected consquence of destroying objects, and the Phabricator upstream will not help you fix them. We strongly recomend disabling or archiving objects instead.

May 18 2016, 12:26 PM · Conpherence, Bug Report
epriestley added a comment to T10981: Expected a scalar or null for %Ls conversion. Query: user.phid.

Thanks, try HEAD?

May 18 2016, 12:45 AM · Conduit, Bug Report