Page MenuHomePhabricator
Create Task
Maniphest T10980

Code coverage details on Phab
Closed, InvalidPublic
Actions

Description

Server version:
phabricator 121e68e3adae4cd21731b79c07ca89676def7e19 (Mar 15 2016)
arcanist 3d7ac867f53892b8210339bbb0c5fd91e0e36d78 (Mar 14 2016)
phutil d20d6e725037538221b42a74b6dcb7a006834a7a (Mar 13 2016)

Client version:
arcanist 2234c8cacc21ce61c9c10e8e5918b6a63cc38fc8 (16 May 2016)
libphutil b25e0477b280ca3e8345bb97cd55e95bcb5023ec (11 May 2016)

I'm not seeing code coverage details on the online console. Arcanist correctly outputs the coverage details locally, and the generated json file looks valid (snippet below). There were no reported errors, running with --trace or in the apache error.log online

"0": {
  "namespace": null,
  "name": "hierarchy.test_get_filtered_loans",
  "link": null,
  "result": "pass",
  "duration": 0.015,
  "extra": null,
  "userData": "",
  "coverage": {
    "/Users/abeer/Documents/Projects/alpha/prosper/credentials.py": "CNCNNCNCC",
    "/Users/abeer/Documents/Projects/alpha/prosper/analysis/loan_organizer.py": "CNCNCNNCNNNNCNNNNNNNNNCCCCCCCNCNNNNNNCNCNNNCCCNCNNNCCNNNNCNCCCCNCNNNC",
    "/Users/abeer/Documents/Projects/alpha/prosper/base/access_data.py": "CCCCCCCNCCCCCCNCCNNNCNCNNCNNNNNCNNCNNCCCNNCNNCCNNCNNCNNCNNNNNNNNNNNNNCNNNNNCCNCCNCCNCCNNCCNNCCNNCCNNCCNNCCNNCCNNCUCCUNCNNCNNNNCNNCNNNNNUNNNCCCUNCNNNUNUUNCCNNCNNNNNNNNNNNNNNUNNNNUUUUNCNNCUNUCCNNCUCCNNCUUNNNNUNUCNNNUCUUNNCNNNCCNNNNNCNCNNNUUUCNCCNUUCUUNUNNUNNNNUNNNNCNCUNNNNCNCNNCNNCNCNNCCCCCCNNCNNUNNNCNNNCNNNCNNNNCNNCCNNNNCNNCNNCNNNCCCCNNCNNNNCCCCNNNNCNNNNNCCCCCCCCNNCCNNCCCNNCCNNCCCNNCC",
    "/Users/abeer/Documents/Projects/alpha/prosper/base/api_access.py": "NNNCNCCCCCCCNCNCCCCNCNCCCCCCCCCNNCNNCNNNCCNNNNNCNNNNNNNNNNCNNCCNNNNNNNNNNNCNNCNCNNCCCNNCNNNCNNCNNNCNNCNNCCCCNNCCNCNNNNNNNNNNCNNNNNNNNCCCCNCNNNCCCNCCCNCCNCCCCCCCCCNCNNNCNNNNNNNNNNCNCCCCNCNCCCCCNNNCCNNCCCCCCNCNCCCNCCCNNNNNNCNNCCCNCNCCCNCNNNNNNCCCCNCCNCNNNNNNNNNNNNNNCCCCNCCCNCNCCCNCUCCCCCNCCCCCNCCCCCCCNNNCCNNNNNNNNCNNNCNCCCCNCNNNCNCCCCNCCCNCCNNCNNNNNNNNNNNNNCCCCNNCCCNNCNCNCNNCCCCCNCCCNNCNNNNNCCCCCNCNNCNNNCCNCNNNNNNNNNNNCNNCCNCCNCCCNCNCNNNCNNCCCCCCNNCCUCCNCCNNNCCCNCCCCCCUNCCCUNUCCNCUNUCNCNCCNCUCUUCUCNNNCUCNNNNCUUNUUNNNUNUUUUUUUUCUNUUUUUNCNUNCUUUUNNNUUNNNUUUUNUUUU",
    "/Users/abeer/Documents/Projects/alpha/prosper/base/api_constants.py": "CNNNNNNNNNNNNNNNNNNCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCNCNNNNCCCCCCNCCCCCCCNNCNNC",
    "/Users/abeer/Documents/Projects/alpha/prosper/base/aws_utils.py": "CNCCCCCCNCNCNNCCNCCCNCNCNNNUUNNCNNNUUUUUUNNUUUUUUNUUNNCNNNNNNNUUUUUUNNCNNNNNNNUUUNNCNUNUUNNCNUNNNUUNNCNNNUUUNNNCNNNNNNUUUUUUNNNNCNNNNNNNNNUUUUUNUUUUNNCNNNCCCNCNNNNUUUU",
    "/Users/abeer/Documents/Projects/alpha/prosper/base/column_info.py": "NNNNCNNCCCNCNCNNCNNNNNNNNCNCNCCNCNCNCNCUCNCNNNNNNNNNNCCCCNNCNCCCCNNCCNNCCNNCCCCNCCCCCCNNCCNCNCCNNCCNCCNNCNNNNNNNNCCCCCCNNNNCNCCCCCCCCCCCCNCNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNN",
    "/Users/abeer/Documents/Projects/alpha/prosper/base/config.py": "CNCNCCCCNNNNNNNCCCCCCCNCNNNCNNNCNCCCCNNNCCNCCCCCNNCCCNCCNCCNCCNNNNNNNNNNNCNCNNNNNNNNNNNNNNNNNNNNN",
    "/Users/abeer/Documents/Projects/alpha/prosper/base/constants.py": "NNNNNNNNNNNNNCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCNNNCCCCCCCCCCCCCCCCCCNNNNNCCCCNNNCCCNNNNNNNNCCCCNNNCCCCNNCNCNCNCCNCNNCCCCCCNCCCCCCCCCCCCCNNCNNNNNNNNNNNNCCCNNCCCNNCNNCNNCCCCCC",
    "/Users/abeer/Documents/Projects/alpha/prosper/base/db_connection.py": "CCCCCCCNCCCCCCCCCNCCNNNCNNNCNCNNCNCNCNNCCNNCCNCNCNNNNNNNCCCCCCCCCCNNCNNNNCNNNCCCCCCCNCNNNCCCNNCNNNCCNCCNCNNNNCCCNCNNNNNNNNNCCCCUCNUUCCCCNCCNCNNNNNNNNNNNUUNCNNNNNNUCUUNNNCNNNNNNNUUNUCCUCNNCNNCCNNCNNNNNNNCCNCNCCCUNCNUCCNNNCNNNNNNNUNNCNNNCNCNNNNNNNCNNCNNNCNCNNNCNCNNNNCNNCNNNNNNNNCCNNCNNNCNNNNNNNNCNCCNNCCCCCNCNCNCNNNCCCNUNNNNUUNCNNNNNNNNNNCNNCNCCNNCCNNNNNNUUUUUNNCCUUUNNCNNNNNNNNNNUNNUNUUNNCNUUUNUNNNNUUNNCNNCCNCCNU",
    "/Users/abeer/Documents/Projects/alpha/prosper/base/file_locking.py": "CNCNNCNNNNNNNNNNCCUCNNCNNNNNNCNNCNNNNCNNCNNNNNNNNNNNNNNNNNCCCCCCCNCCCCNCCC",
    "/Users/abeer/Documents/Projects/alpha/prosper/base/file_throttler.py": "CCCCNCNCNNNCCCNCNNNNNNNNNCCCCNCCNCCNCNCNCNNCCNNCNNCCCCNC",
    "/Users/abeer/Documents/Projects/alpha/prosper/base/filtering.py": "CCNCNCNCNCNNNNNNNNNNNNNNNNNNNNNNNNNNNCNCCCCUNCNNCNNNNNCCCCNCCCCN

Related Objects

Event Timeline

abeer created this task.May 17 2016, 11:12 PM
epriestley added a subscriber: epriestley.May 17 2016, 11:32 PM

Please include reproduction steps when filing a bug report. See Providing Reproduction Steps for help.

epriestley added a comment.May 17 2016, 11:33 PM

You're also two months out of date, see Contributing Bug Reports.

abeer added a comment.May 18 2016, 12:02 AM

Updated version information:

phabricator de1a30efc7404dd02f14b6afd98cf5ba3cb701f0 (Tue, May 17)
arcanist 2234c8cacc21ce61c9c10e8e5918b6a63cc38fc8 (Mon, May 16)
phutil b25e0477b280ca3e8345bb97cd55e95bcb5023ec (Wed, May 11)

Reproduction Steps:

  1. Run arc diff for new patch/update

Expected result:
Patch is uploaded and code coverage information available on diff screen in Maniphest

Actual result:
Patch is uploaded and code coverage information is NOT available on diff screen in Maniphest

avivey added a subscriber: avivey.May 18 2016, 12:21 AM

Whatever's generating your coverage information (A unit-test engine) needs to provide file names relative to the root of the repository; The snippet you have is showing the filenames are absolute.

epriestley added a comment.May 18 2016, 12:27 AM

arc diff is not expected to upload coverage information without additional configuration.

You need to submit complete reproduction steps which allow the issue to be reproduced against a clean install. This includes configuration. I (or any other user) should be able to follow the steps you provide to reproduce the issue locally. Please read Providing Reproduction Steps carefully.

abeer added a comment.May 18 2016, 7:11 PM

I have been unable to repro on a clean install. Its probably appropriate to close the bug. I apologize for being unclear.

epriestley closed this task as Invalid.May 18 2016, 7:38 PM
Phabricator · Built by Phacility