Page MenuHomePhabricator
Create Task
Maniphest T10984

arc diff to put Revision URI into clipboard
Closed, WontfixPublic
Actions

Description

My team loves to send each other private messages asking them to look at code reviews rather than rely on the email notifications. The previous code review solution (Rietveld) had a command line interface that would put the URL of the code review just submitted/updated into the user's clipboard, which made this flow simple, skipping the manual select & copy from terminal.

We're committed to not maintaining a fork of Phabricator so looking only at tweaks that will be carried by upstream.

Would this be something Phabricator would allow? I'm thinking an .arcrc config setting which enables this behavior. I know the project is against a bunch of config options and against config toggles that change the behavior, but I feel this doesn't affect behavior in a way that would disrupt any tooling using it.

I'm happy to build this, if the approach is acceptable.

If not, I'm open to alternatives.

Related Objects

Event Timeline

allixsenos created this task.May 18 2016, 5:15 PM
epriestley added a subscriber: epriestley.May 18 2016, 6:55 PM

I suppose you can arc set-config browser <something>, where <something> is a script which copies argv[1] to the clipboard and then exits, then run arc diff --browse.

Broadly, I think this behavior is too niche and the value too marginal for this to be a good candidate for inclusion in the upstream. It will likely be possible to implement it as an extension behavior more cleanly after T10329 if the browser approach isn't satisfactory.

chad added a subscriber: chad.May 18 2016, 6:55 PM

I think it's better to understand the deficiency of Phabricator's notification system than to build out something like this. It's not something I recall anyone previously needing or asking for, and seems completely undiscoverable.

epriestley closed this task as Wontfix.May 18 2016, 6:58 PM
epriestley claimed this task.

I also agree with @chad in the general sense -- this use case seems pretty weird to me and is entirely unlike anything we're aware of in other installs. If email notifications are deficient in some way, we'd prefer to address that.

See also T8227 for discussion of the extraordinarily high barrier "just add a config setting" options face in reaching the upstream.

chad added a comment.May 18 2016, 6:58 PM

Or maybe a better way to think about this, we'd prefer looking at absolute, programmatic solutions, not solutions that rely on users discovering and consistently applying them (they won't).

Phabricator · Built by Phacility