Page MenuHomePhabricator
Feed Advanced Search

Dec 4 2015

epriestley closed T6226: Conduit-created task always results in [Reopened] tag in the email subject as Resolved.

Task creation slightly ahead of HEAD through maniphest.edit now hit essentially the exact same code as the web UI, and no longer appear to do this "[Reopened]" stuff.

Dec 4 2015, 8:04 PM · Restricted Project, Maniphest, Conduit
epriestley renamed T7303: Provide OAuth access to Conduit from Provide a way to create/edit tasks through the OAuth API to Provide OAuth access to Conduit.
Dec 4 2015, 7:58 PM · Restricted Project, Conduit, Restricted Project
epriestley closed T8289: project parameter for task creation should accept hashtags and project IDs (numbers) not just canonical names as Resolved.

This hasn't hit HEAD yet, but will be resolved indirectly as part of changes in connection with T9132 shortly as that rolls out.

Dec 4 2015, 7:57 PM · Wikimedia, Maniphest
epriestley closed T8289: project parameter for task creation should accept hashtags and project IDs (numbers) not just canonical names, a subtask of T4777: Allow passing a "project(s)" URL parameter to "Create Task" form, as Resolved.
Dec 4 2015, 7:57 PM · Maniphest
epriestley created T9902: Phacility invite flow incorrectly associates "x@y.com" with user who previously accepted that invite, even if they have removed the address.
Dec 4 2015, 7:52 PM · Phacility
epriestley closed T6408: Allow users (or at least admins) to share saved queries as Resolved.

See T4103 (or create a wiki page or dashboard).

Dec 4 2015, 7:37 PM · Maniphest
epriestley closed T6288: Projects - when creating project from Maniphest, icon doesn't show as Wontfix.

I'm removing this "Create Project" workflow entirely in connection with T9132, obsoleting this task.

Dec 4 2015, 7:36 PM · Projects, Maniphest
epriestley moved T6226: Conduit-created task always results in [Reopened] tag in the email subject from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:33 PM · Restricted Project, Maniphest, Conduit
epriestley moved T6205: Replace "Associate Projects" action in task editing form with "Edit Projects" from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:33 PM · Projects, Transactions, Maniphest
epriestley updated subscribers of T6205: Replace "Associate Projects" action in task editing form with "Edit Projects".

This is now fairly easy to implement and the race stuff isn't a problem anymore, but I'm not sure it's worthwhile from a product perspective. We could pursue these things fairly easily now:

Dec 4 2015, 7:33 PM · Projects, Transactions, Maniphest
epriestley moved T5158: Maniphest custom field refuses to use non-empty default value from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:19 PM · Maniphest, Custom Fields, Transactions
epriestley added a comment to T9901: Provide self-contained Arcanist executable.

See T4200.

Dec 4 2015, 7:18 PM · Arcanist
epriestley closed T9901: Provide self-contained Arcanist executable as Wontfix.
Dec 4 2015, 7:17 PM · Arcanist
epriestley closed T4699: Improve email interaction with Maniphest as Resolved.

I think this is mostly either resolved or obsoleted by "Email Commands" (Help → Email Commands in Maniphest). We also backed away from hashtags implying project associations, and that seems like it was a good call.

Dec 4 2015, 7:17 PM · Mail, Maniphest
epriestley closed T4623: Allow system agents to create tasks they can't edit afterwards as Wontfix.

We haven't seen other use cases for this. OAuth or Nuance are more likely approaches from an upstream viewpoint.

Dec 4 2015, 7:14 PM · Conduit, Maniphest
epriestley moved T4580: Auto saving forms doesn't save dynamic form visibility state from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:13 PM · Maniphest
epriestley moved T4316: Allow a comment to be added on the Maniphest edit interface from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:13 PM · Maniphest
epriestley moved T5622: "copy" attribute for custom fields is not working, at least for text fields from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:13 PM · Maniphest, Custom Fields
epriestley moved T6815: Creating a cyclic task dependency in Maniphest no longer produces a nice error dialog from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:12 PM · Maniphest
epriestley moved T7303: Provide OAuth access to Conduit from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:11 PM · Restricted Project, Conduit, Restricted Project
epriestley moved T7250: Actions in wrong order after merging duplicates + reopening from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:11 PM · Maniphest
epriestley moved T7661: Object creation is often accompanied by transaction records which aren't of much use from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:10 PM · Transactions, Maniphest
epriestley moved T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:09 PM · Maniphest, Herald
epriestley moved T8055: "copy":true does not work in Maniphest custom field configuration from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:09 PM · Maniphest
epriestley moved T8289: project parameter for task creation should accept hashtags and project IDs (numbers) not just canonical names from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:08 PM · Wikimedia, Maniphest
epriestley moved T8903: Removing projects by editing a task in-place from a query result list doesn't refresh properly from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:07 PM · Maniphest
epriestley moved T9238: Field-level policy controls are not made clear in the UI from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:06 PM · Maniphest
epriestley moved T9496: Allow Maniphest custom statuses (and priorities) to be disabled from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:06 PM · Maniphest
epriestley moved T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:06 PM · Modernization, Maniphest
epriestley moved T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:06 PM · Maniphest, Installing & Upgrading
epriestley edited projects for T9652: Request for test case management application, added: Unnamed Manual Test Case Application; removed Roadmap, Maniphest.
Dec 4 2015, 7:06 PM · Restricted Project, Unnamed Manual Test Case Application
epriestley created Unnamed Manual Test Case Application.
Dec 4 2015, 7:06 PM
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 4 2015, 6:59 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 4 2015, 6:17 PM · Restricted Project, ApplicationEditor, Transactions
epriestley placed T9889: Object selector dialog does not work in Elasticsearch 2.0 up for grabs.
Dec 4 2015, 4:50 PM · Elasticsearch
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 4 2015, 3:59 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 4 2015, 3:34 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 4 2015, 3:13 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 4 2015, 3:00 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a comment to T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed.

Actually, you probably also don't really care about removing the comment event anyway, since it can't change policies and you can't comment on objects when creating them, and I think your listener doesn't actually end up doing anything special for the actions that are available? So this might be mostly moot anyway, but in an ideal world I'll get through the main "edit" event shortly too.

Dec 4 2015, 2:56 PM · Maniphest, Installing & Upgrading
epriestley added a comment to T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed.

Quick update here: ApplicationEditor/EditEngine have caught up with this, so the current plan is to indirectly remove this event in at least some cases (currently: changes made from the "Comments" area) after the stable cut on Saturday. You can upgrade to this week's stable safely but we should make sure things are in a good place before you move beyond that.

Dec 4 2015, 2:54 PM · Maniphest, Installing & Upgrading
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 4 2015, 2:43 PM · Restricted Project, ApplicationEditor, Transactions
epriestley renamed T9898: `git branch --contains X` has cost in the realm of O(commits * branches) from git:branch-unique() is absurdly slow to `git branch --contains X` has cost in the realm of O(commits * branches).
Dec 4 2015, 2:03 PM · Restricted Project, Restricted Project, Arcanist
epriestley added a comment to T9898: `git branch --contains X` has cost in the realm of O(commits * branches).

pretty big rough edges for the workflows it intends to enable

Dec 4 2015, 1:48 PM · Restricted Project, Restricted Project, Arcanist
epriestley triaged T9899: Chatbot requires access to the database as Wishlist priority.

I think there are two issues here:

Dec 4 2015, 1:16 PM · Phabot
epriestley renamed T9900: Figlet does not properly render apostrophes with some characters from Figlet does not properly render apostrophe's with some characters to Figlet doe's not properly render apostrophe's with some character's.
Dec 4 2015, 1:03 PM · Contributor Onboarding, Remarkup
epriestley triaged T9900: Figlet does not properly render apostrophes with some characters as Wishlist priority.
Dec 4 2015, 12:37 PM · Contributor Onboarding, Remarkup
epriestley added a comment to T9900: Figlet does not properly render apostrophes with some characters.

I think this is a problem only with the default font, it seems OK in other fonts:

Dec 4 2015, 12:36 PM · Contributor Onboarding, Remarkup
epriestley added a comment to T4209: Multiserver / High-Availability Configuration.

I think the first SSH connection is still more expensive than several HTTP connections, and we can't easily just pool all traffic from a host over a single connection because a host may run multiple instances of Phabricator -- and we already built all the HTTP stuff anyway.

Dec 4 2015, 12:20 PM · Restricted Project, Phacility
epriestley closed T9873: arc alias outputs a confusing message when adding a shell command alias as Resolved by committing Restricted Diffusion Commit.
Dec 4 2015, 2:31 AM · Arcanist
epriestley added a comment to T9898: `git branch --contains X` has cost in the realm of O(commits * branches).

(I think that --not construct is wrong, and we'd just have to enumerate every branch explicitly.)

Dec 4 2015, 2:08 AM · Restricted Project, Restricted Project, Arcanist
epriestley added a comment to T9898: `git branch --contains X` has cost in the realm of O(commits * branches).

It's also possible that we can run git log --all --format='%H %P' and git for-each-ref and implement --contains ourselves in less than 2 seconds in PHP, although this is hugely ridiculous and clearly a problem with Git if true.

Dec 4 2015, 2:01 AM · Restricted Project, Restricted Project, Arcanist
epriestley added a comment to T9898: `git branch --contains X` has cost in the realm of O(commits * branches).

If you run those commands on their own, they're also slow? Even just this?

Dec 4 2015, 1:57 AM · Restricted Project, Restricted Project, Arcanist
epriestley added a comment to T9898: `git branch --contains X` has cost in the realm of O(commits * branches).

I can't reproduce this. Here's what I did:

Dec 4 2015, 1:34 AM · Restricted Project, Restricted Project, Arcanist

Dec 3 2015

epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 3 2015, 11:19 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a comment to T9360: Unbeta Phame.

Yeah, let me dig into that a bit and come up with some options. I have to go look at what the skin code is doing.

Dec 3 2015, 9:40 PM · Phame
epriestley added a comment to T9360: Unbeta Phame.

I don't think it costs us very much to keep it around, and it does make some stuff nicer/easier. For example, we'd have no way to link to the live blog or live post if we don't know what domain it's on, and I like checking the live post after publishing something.

Dec 3 2015, 9:36 PM · Phame
epriestley added a comment to T9360: Unbeta Phame.

Some thoughts from banging on this, not sure how much you want to deal with:

Dec 3 2015, 9:09 PM · Phame
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 3 2015, 7:38 PM · Restricted Project, ApplicationEditor, Transactions
epriestley reopened T9893: Support ElasticSearch 2.0 - 5.1 as "Open".
Dec 3 2015, 3:53 PM · Elasticsearch, Search
epriestley reopened T9890: Version and lock search index rebuilds to reduce the cost of runaway writes as "Open".
Dec 3 2015, 3:53 PM · Search
epriestley reopened T9891: Verify WMF use cases are accommodated after Herald Outbound Rules resolves as "Open".
Dec 3 2015, 3:53 PM · Mail, Differential
epriestley closed T5031: Draft Comment Persists After Submission as Resolved by committing Restricted Diffusion Commit.
Dec 3 2015, 3:07 PM · Restricted Project, Support Impact, Mobile
epriestley closed T5031: Draft Comment Persists After Submission, a subtask of T5811: Phriction does not correctly save and restore document drafts of in-progress edits, as Resolved.
Dec 3 2015, 3:07 PM · Phriction
epriestley closed T5031: Draft Comment Persists After Submission, a subtask of T7794: Differential revision list "draft notification" bubble should ignore deleted drafts, as Resolved.
Dec 3 2015, 3:07 PM · Differential, Audit
epriestley added a comment to T9855: DifferentialChangesSinceLastUpdateField may fail policy checks and prevent mail from sending.

It would be helpful to understand how to reproduce this. Specifically, I think what's happening is something like this:

Dec 3 2015, 2:54 PM · Daemons, Differential
epriestley renamed T9855: DifferentialChangesSinceLastUpdateField may fail policy checks and prevent mail from sending from Perpetually failing daemon task to DifferentialChangesSinceLastUpdateField may fail policy checks and prevent mail from sending.
Dec 3 2015, 2:50 PM · Daemons, Differential
epriestley closed T9867: Articulate meaningful corporate values as Wontfix.

I'm just going to close this, I can dig it up later if I want to reference it.

Dec 3 2015, 2:48 PM · Phacility
epriestley added a subtask for T9640: Make Phabricator compatible with PHP7: T9888: Provide guidance in the documentation about PHP7.
Dec 3 2015, 2:47 PM · Prioritized, Restricted Project, Infrastructure
epriestley added a parent task for T9888: Provide guidance in the documentation about PHP7: T9640: Make Phabricator compatible with PHP7.
Dec 3 2015, 2:47 PM · Documentation
epriestley triaged T9889: Object selector dialog does not work in Elasticsearch 2.0 as Low priority.
Dec 3 2015, 2:47 PM · Elasticsearch
epriestley added a parent task for T5791: Write Herald rules for outbound mail: T9891: Verify WMF use cases are accommodated after Herald Outbound Rules resolves.
Dec 3 2015, 2:46 PM · Restricted Project, Restricted Project, FreeBSD, Mail
epriestley added a subtask for T9891: Verify WMF use cases are accommodated after Herald Outbound Rules resolves: T5791: Write Herald rules for outbound mail.
Dec 3 2015, 2:46 PM · Mail, Differential
epriestley renamed T9891: Verify WMF use cases are accommodated after Herald Outbound Rules resolves from Differential notification emails lack headers for repository and state change to Verify WMF use cases are accommodated after Herald Outbound Rules resolves.
Dec 3 2015, 2:46 PM · Mail, Differential
epriestley added a comment to T9891: Verify WMF use cases are accommodated after Herald Outbound Rules resolves.

This is basically all reasonable but entangled with the giant mess in T5791 and T9161.

Dec 3 2015, 2:46 PM · Mail, Differential
epriestley added a project to T9893: Support ElasticSearch 2.0 - 5.1: Elasticsearch.
Dec 3 2015, 2:21 PM · Elasticsearch, Search
epriestley renamed T9889: Object selector dialog does not work in Elasticsearch 2.0 from Phabricator search is not working perfectly after upgrading search features to elasticsearch to Object selector dialog does not work in Elasticsearch 2.0.
Dec 3 2015, 2:21 PM · Elasticsearch
epriestley added a comment to T9893: Support ElasticSearch 2.0 - 5.1.

Broadly, to set expectations, this is a very low priority for the upstream and neither of us really have any familiarity with Elasticsearch, so I don't expect to move this forward for a long time.

Dec 3 2015, 2:21 PM · Elasticsearch, Search
epriestley added a comment to T9889: Object selector dialog does not work in Elasticsearch 2.0.

We don't currently support ElasticSearch 2.0. I'm collecting issues we've seen with it in T9893.

Dec 3 2015, 2:17 PM · Elasticsearch
epriestley updated the task description for T5282: Provide documentation on setting up ElasticSearch.
Dec 3 2015, 2:16 PM · Elasticsearch, Documentation
epriestley added a comment to T9893: Support ElasticSearch 2.0 - 5.1.

As an alternative, I'd like to consider dropping upstream support for ElasticSearch entirely. We originally implemented it because Facebook wanted it and the project was more willing to implement and maintain things. However:

Dec 3 2015, 2:16 PM · Elasticsearch, Search
epriestley added a comment to T9670: Conflicting field mappings for phabricator index when upgrading to Elasticsearch 2.0.

@ru31337, that issue isn't related to this one and isn't "wontfix". Please see Contributing Bug Reports for instructions on how to report bugs. Choosing an existing similar task, changing it to "wontfix" and dumping your issue into it won't get it fixed.

Dec 3 2015, 2:09 PM · Elasticsearch
epriestley added a parent task for T9670: Conflicting field mappings for phabricator index when upgrading to Elasticsearch 2.0: T9893: Support ElasticSearch 2.0 - 5.1.
Dec 3 2015, 2:08 PM · Elasticsearch
epriestley added a subtask for T9893: Support ElasticSearch 2.0 - 5.1: T9670: Conflicting field mappings for phabricator index when upgrading to Elasticsearch 2.0.
Dec 3 2015, 2:08 PM · Elasticsearch, Search
epriestley added a parent task for T9779: ./bin/search init error with elasticsearch 2.0: T9893: Support ElasticSearch 2.0 - 5.1.
Dec 3 2015, 2:08 PM · Elasticsearch
epriestley added subtasks for T9893: Support ElasticSearch 2.0 - 5.1: T9889: Object selector dialog does not work in Elasticsearch 2.0, T9779: ./bin/search init error with elasticsearch 2.0.
Dec 3 2015, 2:08 PM · Elasticsearch, Search
epriestley added a parent task for T9889: Object selector dialog does not work in Elasticsearch 2.0: T9893: Support ElasticSearch 2.0 - 5.1.
Dec 3 2015, 2:08 PM · Elasticsearch
epriestley created T9893: Support ElasticSearch 2.0 - 5.1.
Dec 3 2015, 2:07 PM · Elasticsearch, Search
epriestley claimed T9873: arc alias outputs a confusing message when adding a shell command alias.
Dec 3 2015, 2:04 PM · Arcanist
epriestley added a revision to T9873: arc alias outputs a confusing message when adding a shell command alias: Unknown Object (Differential Revision).
Dec 3 2015, 2:04 PM · Arcanist
epriestley closed T9876: Arcanist filename linter's regex should be configurable as Wontfix.

I don't think telling users that their filenames must match a complicated regexp and expecting them to figure it out is a reasonable behavior for a linter to have. I think I'm fairly comfortable with regular expressions and not confident I could figure out what the message meant quickly, and I know at least some engineers just don't have regexp literacy as part of their toolset.

Dec 3 2015, 1:42 PM · Lint, Arcanist
epriestley renamed T9887: Builds do not recover properly if a build step has an invalid build plan (e.g., a removed class) from When a build encounters an "Unexpected Error", the buildable remains in a "Building" state to Builds do not recover properly if a build step has an invalid build plan (e.g., a removed class).
Dec 3 2015, 1:15 PM · Restricted Project, Harbormaster
epriestley updated the task description for T9890: Version and lock search index rebuilds to reduce the cost of runaway writes.
Dec 3 2015, 1:11 PM · Search
epriestley added a comment to T9890: Version and lock search index rebuilds to reduce the cost of runaway writes.

I suppose the "version number" I propose is a little tricky, because it won't be incremented if a user edits a comment -- this does not apply a new transaction. We could use a <MAX(transactionID), MAX(commentID)> version instead to catch edits.

Dec 3 2015, 1:08 PM · Search
epriestley renamed T9890: Version and lock search index rebuilds to reduce the cost of runaway writes from Make parallel taskmaster daemons efficient by not letting them executing the same tasks to Version and lock search index rebuilds to reduce the cost of runaway writes.
Dec 3 2015, 1:07 PM · Search
epriestley added a comment to T9890: Version and lock search index rebuilds to reduce the cost of runaway writes.

Ah! That could definitely explain it.

Dec 3 2015, 1:06 PM · Search
epriestley added a comment to T6549: Backup codes for multi-factor authentication.

See also T9515 and T7639 for "choose some other users to trust, if you lose your phone they can vote to strip your MFA".

Dec 3 2015, 12:03 AM · Restricted Project, Auth

Dec 2 2015

epriestley added a comment to T9657: Upgrading: arc land flow has been rewritten in git.

This was an intentional change in response to requests by other users in T4333 and elsewhere.

Dec 2 2015, 11:55 PM · Installing & Upgrading, Arcanist
epriestley added a comment to T9825: Remarkup is rendered literally in Diviner.

There isn't really one, all the applications that do it right are doing comments, and you can't do the same thing they're doing very easily. Audit does something but it's a mess. It should really just get restructured, I think.

Dec 2 2015, 9:28 PM · Diviner
epriestley added a comment to T5031: Draft Comment Persists After Submission.

I've marked D14637 as fixing this.

Dec 2 2015, 8:59 PM · Restricted Project, Support Impact, Mobile