Page MenuHomePhabricator
Create Task
Maniphest T9887

Builds do not recover properly if a build step has an invalid build plan (e.g., a removed class)
Open, WishlistPublic
Actions

Description

See:

pasted_file (372×1 px, 35 KB)

pasted_file (33×1 px, 8 KB)

The buildable should move to the failed state instead.

Event Timeline

hach-que created this task.Dec 2 2015, 9:50 AM
hach-que raised the priority of this task from to Needs Triage.
hach-que updated the task description. (Show Details)
hach-que added a project: Harbormaster.
hach-que added subscribers: hach-que, epriestley.
joshuaspence added a subscriber: joshuaspence.Dec 2 2015, 10:01 AM
epriestley closed this task as Invalid.Dec 2 2015, 3:57 PM
epriestley claimed this task.

I don't know how to reproduce the behavior this report describes. See Contributing Bug Reports.

hach-que reopened this task as Open.Dec 2 2015, 8:52 PM

This happens after upgrading Phabricator and having a build step implementation no longer exist; when the build plan runs you get an unexpected error. Getting the unexpected error isn't what's wrong - but that the buildable doesn't get marked as failed is incorrect.

You can replicate this issue by making a build plan and deleting one of the build step implementations it uses.

epriestley triaged this task as Wishlist priority.Dec 2 2015, 8:54 PM
epriestley moved this task from Backlog to Far Future on the Harbormaster board.
epriestley renamed this task from When a build encounters an "Unexpected Error", the buildable remains in a "Building" state to Builds do not recover properly if a build step has an invalid build plan (e.g., a removed class).Dec 3 2015, 1:15 PM
eadler added a project: Restricted Project.Aug 5 2016, 4:44 PM
Herald added a subscriber: eadler. · View Herald TranscriptAug 5 2016, 4:44 PM
Phabricator · Built by Phacility