Page MenuHomePhabricator
Feed Advanced Search

Mar 21 2015

epriestley closed T7490: Asana authentication provider shows "Provider Implementation Missing" as Resolved.

This is, uh, a... test case? Of, uh, missing provider config? Completely intentional!

Mar 21 2015, 11:59 AM · Auth
epriestley assigned T7493: Buttons are not consistently greyed out in Passphrase to lpriestley.
Mar 21 2015, 11:57 AM · Passphrase
epriestley reassigned T7499: "New Build Plan" should be greyed out if not allowed by policy from joshuaspence to lpriestley.
Mar 21 2015, 11:56 AM · Policy, Harbormaster
epriestley assigned T7497: "Create Application" should be greyed out if not allowed by policy to lpriestley.
Mar 21 2015, 11:56 AM · OAuthServer
epriestley renamed T7516: Add git clone url to conduit repository.query from Feature request: add git clone url to conduit repository.query to Add git clone url to conduit repository.query.
Mar 21 2015, 11:55 AM · Restricted Project, Diffusion (v3), Conduit
epriestley closed T7547: Is there a way to specify a wildcard path in Owners? as Resolved.
Mar 21 2015, 11:54 AM · Owners
epriestley added a comment to T7598: Expected a numeric scalar or null for %Ld conversion.

Specifically, submitting ids: [[1]] will reproduce this:

Mar 21 2015, 11:51 AM · Conduit
epriestley closed T7598: Expected a numeric scalar or null for %Ld conversion as Wontfix.

I think we can only fix this by adding typechecking to Conduit, which will happen some day but is a larger project.

Mar 21 2015, 11:50 AM · Conduit
epriestley added a comment to T7611: Transaction type 'differential:action' is missing an internal apply implementation.

I'm not sure. Possibly, e.g., control-click the "Action" dropdown, type in a garbage key like "partytime", submit form normally? But it might be more clear if we knew the key.

Mar 21 2015, 11:47 AM · Transactions, Differential
epriestley added a revision to T7611: Transaction type 'differential:action' is missing an internal apply implementation: Unknown Object (Differential Revision).
Mar 21 2015, 11:43 AM · Transactions, Differential
epriestley added a comment to T7611: Transaction type 'differential:action' is missing an internal apply implementation.

It looks like this can happen if you try to apply an action which does not exist.

Mar 21 2015, 11:42 AM · Transactions, Differential
epriestley claimed T7625: Short hashtags ending in numbers will not be rendered.
Mar 21 2015, 11:39 AM
epriestley added a revision to T7625: Short hashtags ending in numbers will not be rendered: Unknown Object (Differential Revision).
Mar 21 2015, 11:38 AM
epriestley added a comment to T7636: How to create review of existing pushed commit?.

Try reading this, which is entirely about this topic:

Mar 21 2015, 11:31 AM · Documentation, Differential, Arcanist
epriestley claimed T7640: Add "number of commits" as order by option in search.
Mar 21 2015, 11:29 AM · Diffusion
epriestley added a revision to T7640: Add "number of commits" as order by option in search: Unknown Object (Differential Revision).
Mar 21 2015, 11:28 AM · Diffusion
epriestley added a comment to T7563: Dragging tasks on Maniphest appear in the wrong position (n+1).

This should be fixed in HEAD. I've pushed the change to this server if you want to try to catch any remaining issues before upgrading (we don't really use subpriority on this install, so don't worry about messing things up).

Mar 21 2015, 12:39 AM · Maniphest
epriestley closed T5201: Search result drag reordering in Maniphest is possible but not sticky? as Resolved by committing Restricted Diffusion Commit.
Mar 21 2015, 12:38 AM · Maniphest
epriestley closed T7563: Dragging tasks on Maniphest appear in the wrong position (n+1) as Resolved by committing Restricted Diffusion Commit.
Mar 21 2015, 12:38 AM · Maniphest
epriestley added a comment to T7563: Dragging tasks on Maniphest appear in the wrong position (n+1).

The behavior here was generally spooky and nondeterministic (see T5201, which had the same "spooky code" root cause), it just got even spookier recently. I think it should be more predictable after D12121.

Mar 21 2015, 12:27 AM · Maniphest
epriestley added a revision to T7563: Dragging tasks on Maniphest appear in the wrong position (n+1): Unknown Object (Differential Revision).
Mar 21 2015, 12:11 AM · Maniphest
epriestley added a revision to T5201: Search result drag reordering in Maniphest is possible but not sticky?: Unknown Object (Differential Revision).
Mar 21 2015, 12:11 AM · Maniphest

Mar 20 2015

epriestley added a revision to T7639: Figure out MFA in the cluster: Unknown Object (Differential Revision).
Mar 20 2015, 9:54 PM · Phacility
epriestley added a revision to T7627: Get test coverage on instance setup : Unknown Object (Differential Revision).
Mar 20 2015, 9:46 PM · Phacility
epriestley added a comment to T7639: Figure out MFA in the cluster.

I also guess I can build the actual instance-strip operation regardless of the central-account-strip operation, since if administrators configure only instance MFA then central MFA compromise likely allows an attacker some kind of access anyway (at a minimum, they can add an account they control to the instance as a member, which is likely nearly as bad as compromising an administrative account fully).

Mar 20 2015, 8:48 PM · Phacility
epriestley added a comment to T7639: Figure out MFA in the cluster.

No. We do perform MFA checks if they enable it, but we don't currently require it (and don't have UI hints to suggest that they configure it).

Mar 20 2015, 8:46 PM · Phacility
epriestley added a revision to T7627: Get test coverage on instance setup : Unknown Object (Differential Revision).
Mar 20 2015, 8:39 PM · Phacility
epriestley changed the edit policy for T7638: Archiving wiki pages in Phriction.
Mar 20 2015, 7:44 PM · Phriction
epriestley created T7639: Figure out MFA in the cluster.
Mar 20 2015, 7:42 PM · Phacility
epriestley added a comment to T5210: Support GitHub Enterprise as an OAuth Provider.

I don't believe it is practical to modularize OAuth more than it is already modularized. OAuth doesn't define how to get information about user accounts (like email, account ID, profile picture, etc)., so the GitHub vs Amazon vs Etc choice is irreducible.

Mar 20 2015, 7:27 PM · Auth
epriestley added a comment to T7629: Differentiate audience of Threads/Rooms with icon.
  • For isRoom threads, you should be able to use $policy->getIcon() (on PhabricatorPolicy) to select an icon matching the policy that's consistent with policy icons elsewhere in other applications.
    • For non-room threads, the $policy isn't meaningful but you can easily special-case the icons.
Mar 20 2015, 4:57 PM · Conpherence
epriestley closed T7637: Allow my own "planned changes" to be cancelled as Resolved.

Presuming resolved, yell if not.

Mar 20 2015, 3:59 PM · Differential
epriestley added a comment to T7637: Allow my own "planned changes" to be cancelled.

Yeah, unless differential.sticky-accept is off (which is intentional).

Mar 20 2015, 3:55 PM · Differential
epriestley added a comment to T7637: Allow my own "planned changes" to be cancelled.

I can't reproduce this, the revision immediately goes back into "Accepted" for me:

Mar 20 2015, 3:52 PM · Differential
epriestley added a comment to T7634: How to create a login method with a custom icon?.

There's no way to do this right now. You can use the "Generic" icon until we eventually build a modular way to provide icons. This isn't a priority; see T5447 for some rough context and timelines.

Mar 20 2015, 11:01 AM · Restricted Project, Auth
epriestley merged task T7633: Add create-object button to global search page into Restricted Maniphest Task.
Mar 20 2015, 10:58 AM · Maniphest
epriestley closed T7632: Support creating calendar events from the person page as Invalid.

Sorry, we don't accept feature requests for prototype applications like Calendar. This document explains prototype applications and why we don't accept feature requests for them in more detail:

Mar 20 2015, 10:44 AM · People, Calendar
epriestley added a comment to T7594: Having trouble with chunked uploads.

I wonder if there's a way we can detect it. From the report and patch, it's not obvious to me how we could trigger it (to see if it segfaults), and we probably can't usually read /var/log/syslog (to see if there are logs of a segfault). I can't immediately find it in the PHP changelog, either, to just blacklist affected versions.

Mar 20 2015, 10:42 AM · Files
epriestley added a comment to T7566: Implement "Rooms" in Conpherence.

As specified, totally disconnected. It's just a room with "Visible to: Members of Project X", like any other object.

Mar 20 2015, 2:01 AM · Wikimedia, Conpherence
epriestley created T7631: User reporting unbounded memory usage by TriggerDaemon.
Mar 20 2015, 1:52 AM · Daemons

Mar 19 2015

btrahan awarded T7627: Get test coverage on instance setup a Mountain of Wealth token.
Mar 19 2015, 7:19 PM · Phacility
epriestley created T7627: Get test coverage on instance setup .
Mar 19 2015, 6:51 PM · Phacility
epriestley added a comment to T7626: Attaching files to a Phame post doesn't mark them as public.

Sorry, misread. Ignore me. This is probably a bug on our side.

Mar 19 2015, 6:34 PM · Phame
epriestley added a comment to T7626: Attaching files to a Phame post doesn't mark them as public.

If you're sure other users can't see them, update to HEAD.

Mar 19 2015, 6:33 PM · Phame
epriestley added a comment to T7620: git unable to pull after upgrading to latest.

Yeah, I'm not sure what's up. We're slightly ahead of you (rPb7fa55ff) but basically running the same code.

Mar 19 2015, 4:11 AM · Diffusion
epriestley added a comment to T7620: git unable to pull after upgrading to latest.

I changed it to require authentication, just in case that's the issue -- set a VCS password in Settings > VCS Password and try again?

Mar 19 2015, 3:59 AM · Diffusion
epriestley added a comment to T7620: git unable to pull after upgrading to latest.

Hmm, try this one?

Mar 19 2015, 3:56 AM · Diffusion
epriestley added a comment to T7620: git unable to pull after upgrading to latest.

What error do you get if you try this?

Mar 19 2015, 3:50 AM · Diffusion
epriestley added a comment to T7620: git unable to pull after upgrading to latest.

Try cloning this? Does that work?

Mar 19 2015, 3:43 AM · Diffusion
epriestley added a comment to T7621: Exception when uploading a GIF.

D12110 doesn't actually fix this, per se, it just gives you the correct error.

Mar 19 2015, 2:11 AM
epriestley closed T7621: Exception when uploading a GIF as Resolved by committing Restricted Diffusion Commit.
Mar 19 2015, 2:06 AM

Mar 18 2015

epriestley added a revision to T7594: Having trouble with chunked uploads: Unknown Object (Differential Revision).
Mar 18 2015, 11:40 PM · Files
epriestley closed T7624: Test Bug Report as Invalid.
Mar 18 2015, 11:34 PM
epriestley created T7624: Test Bug Report.
Mar 18 2015, 11:33 PM
epriestley added a revision to T7621: Exception when uploading a GIF: Unknown Object (Differential Revision).
Mar 18 2015, 11:30 PM
epriestley added a comment to T7617: Make it easier to know why herald adds reviewers.

Overall, we can definitely improve the transcript view, but it will never be an especially good solution to this problem:

Mar 18 2015, 11:06 PM · Restricted Project, Herald
epriestley added a comment to T7617: Make it easier to know why herald adds reviewers.

Suppose it worked like this:

Mar 18 2015, 10:31 PM · Restricted Project, Herald
epriestley added a comment to T7621: Exception when uploading a GIF.

it is a pretty cool GIF tho

Mar 18 2015, 10:18 PM
epriestley claimed T7621: Exception when uploading a GIF.

Chunk engine is being incorrectly selected as writable in non-chunking configs.

Mar 18 2015, 10:10 PM
epriestley added a comment to T7617: Make it easier to know why herald adds reviewers.

It sounds like lint is a much better fit for this problem than Herald (for example, it won't raise warnings in comments, and it points out exactly where issues are, engineers get a chance to see issues before they get sent for review, etc) -- are there reasons it isn't that I'm missing, or reasons that moving these review rules to lint rules has been slow or impossible?

Mar 18 2015, 10:09 PM · Restricted Project, Herald
epriestley closed T7610: provide sitemap[.xml] [for search engines] as Invalid.

We're happy to solve problems you encounter, but want to wait until there's a specific problem. There's currently no reason to believe that there is a problem, and no reason to believe that a sitemap.xml is the best solution to any problem.

Mar 18 2015, 8:33 PM
epriestley added a comment to T7149: Allow users to import data into a new Phacility instance.

One thing I missed:

Mar 18 2015, 3:35 PM · Phacility
epriestley added a comment to T7618: Owners application unable to enter into details of owned packages.

This should be fixed in HEAD. Thanks for the report, and let us know if you run into anything else.

Mar 18 2015, 2:10 PM · Owners
epriestley closed T7618: Owners application unable to enter into details of owned packages as Resolved by committing Restricted Diffusion Commit.
Mar 18 2015, 2:08 PM · Owners
epriestley added a revision to T7522: Add tooling to backpopulate instance accounts into the cluster: Unknown Object (Differential Revision).
Mar 18 2015, 11:40 AM · Phacility
epriestley closed T7619: arcanist: Minor spelling linter addition as Wontfix.

I don't think this is a good addition because retires is a correctly spelled English word.

Mar 18 2015, 11:33 AM
epriestley added a comment to T7617: Make it easier to know why herald adds reviewers.

In particular, at Facebook:

Mar 18 2015, 10:58 AM · Restricted Project, Herald
epriestley claimed T7618: Owners application unable to enter into details of owned packages.
Mar 18 2015, 10:37 AM · Owners
epriestley added a revision to T7618: Owners application unable to enter into details of owned packages: Unknown Object (Differential Revision).
Mar 18 2015, 10:37 AM · Owners
epriestley added a comment to T7617: Make it easier to know why herald adds reviewers.

Do you think the majority of these blocking reviewer rules are good, or is figuring out why blocking reviewers were added more-than-occasionally the first step in removing them? If these rules added normal reviewers -- instead of blocking reviewers -- would this be a problem?

Mar 18 2015, 10:30 AM · Restricted Project, Herald
epriestley added a comment to T7522: Add tooling to backpopulate instance accounts into the cluster.

I think I have this working locally and am nearly ready to give it a shot in the cluster.

Mar 18 2015, 12:50 AM · Phacility
epriestley added a comment to T7149: Allow users to import data into a new Phacility instance.

Rough notes for eventually formalizing this:

Mar 18 2015, 12:40 AM · Phacility

Mar 17 2015

epriestley added a revision to T7149: Allow users to import data into a new Phacility instance: Unknown Object (Differential Revision).
Mar 17 2015, 11:46 PM · Phacility
epriestley added a comment to T7607: Invoicing emails probably need some work.

Yeah, Phortune is generally a bit under-designed and dense-feeling.

Mar 17 2015, 10:42 PM · Phortune, Phacility
epriestley added a comment to T7607: Invoicing emails probably need some work.

Here's an example order detail:

Mar 17 2015, 10:41 PM · Phortune, Phacility
epriestley added a comment to T7607: Invoicing emails probably need some work.

https://admin.phacility.com/phortune/1/

Mar 17 2015, 10:41 PM · Phortune, Phacility
epriestley added a comment to T7607: Invoicing emails probably need some work.

Oh, that's the payment account (not the merchant account). The merchant account lets you refund charges, etc. I'll add you to the payment account.

Mar 17 2015, 10:40 PM · Phortune, Phacility
epriestley added a comment to T7607: Invoicing emails probably need some work.

Do you want to be part of the merchant account, or do you want to be able to pay for our instances?

Mar 17 2015, 10:35 PM · Phortune, Phacility
epriestley updated subscribers of T5187: Make "Upload File" dialog have a vanilla file upload control.
Mar 17 2015, 10:25 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley merged task T7613: Find a way to upload images to a task without drag n drop into T5187: Make "Upload File" dialog have a vanilla file upload control.
Mar 17 2015, 10:25 PM
epriestley lowered the priority of T7613: Find a way to upload images to a task without drag n drop from Unbreak Now! to Normal.
Mar 17 2015, 10:25 PM
epriestley closed T7612: Task to test the interface. as Invalid.
Mar 17 2015, 10:24 PM
epriestley added a comment to T7613: Find a way to upload images to a task without drag n drop.

I unlocked this task administratively. Please don't lock tasks.

Mar 17 2015, 10:24 PM
epriestley closed T7614: See if there are phabricator plugins for Atom, Netbeans, emacs, or vim, a subtask of T7613: Find a way to upload images to a task without drag n drop, as Resolved.
Mar 17 2015, 10:23 PM
epriestley closed T7614: See if there are phabricator plugins for Atom, Netbeans, emacs, or vim as Resolved.

There are not.

Mar 17 2015, 10:23 PM
epriestley added a comment to T7566: Implement "Rooms" in Conpherence.

Some stuff I've left out, but which may be worth thinking about as the product gets more concrete or in a future update:

Mar 17 2015, 9:40 PM · Wikimedia, Conpherence
epriestley added a comment to T7594: Having trouble with chunked uploads.

Okay, let me fix the fallback behavior and get it printing whatever the chunk upload throws and we'll see where that gets us.

Mar 17 2015, 9:22 PM · Files
epriestley added a comment to T7594: Having trouble with chunked uploads.

Hmm, anything in the error log on the server?

Mar 17 2015, 9:20 PM · Files
epriestley added a revision to T7607: Invoicing emails probably need some work: Unknown Object (Differential Revision).
Mar 17 2015, 8:42 PM · Phortune, Phacility
epriestley added a revision to T7522: Add tooling to backpopulate instance accounts into the cluster: Unknown Object (Differential Revision).
Mar 17 2015, 8:42 PM · Phacility
epriestley added a comment to T7606: Arc Diff displays file comparison backwards after a merge resolution.

If you run git diff abd09676fb35c063..HEAD, do you get the diff you expect?

Mar 17 2015, 8:33 PM · Arcanist, Differential
epriestley added a revision to T7522: Add tooling to backpopulate instance accounts into the cluster: Unknown Object (Differential Revision).
Mar 17 2015, 7:39 PM · Phacility
epriestley added a comment to T7607: Invoicing emails probably need some work.

It can't hurt to have a mock available, but it's unlikely that I can implement logos for merchants in less than an hour (because of T6670, this may actually be a day or more of work).

Mar 17 2015, 7:12 PM · Phortune, Phacility
epriestley added a comment to T7607: Invoicing emails probably need some work.

We can make these look different from other transactional email (but still general to Phortune) with a moderate amount of time, work, and ongoing maintenance cost.

Mar 17 2015, 7:01 PM · Phortune, Phacility
epriestley added a comment to T7607: Invoicing emails probably need some work.

For reference, here's what they look like today:

Mar 17 2015, 6:41 PM · Phortune, Phacility
epriestley merged task T7608: arcanist - allow untracked files into T7521: `arc land` should work even when the repo has untracked files.
Mar 17 2015, 6:32 PM · Subversion, Arcanist
epriestley updated subscribers of T7521: `arc land` should work even when the repo has untracked files.
Mar 17 2015, 6:32 PM · Restricted Project, Arcanist
epriestley added a comment to T7606: Arc Diff displays file comparison backwards after a merge resolution.

Can you show me the output of arc which, when run in a working copy in the same state from which you ran arc diff and got unexpected results?

Mar 17 2015, 6:23 PM · Arcanist, Differential
epriestley updated the task description for T7607: Invoicing emails probably need some work.
Mar 17 2015, 6:12 PM · Phortune, Phacility
epriestley created T7607: Invoicing emails probably need some work.
Mar 17 2015, 6:09 PM · Phortune, Phacility