Buttons are not consistently greyed out in Passphrase
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	joshuaspence
	Mar 7 2015, 2:21 AM

Description

When looking at K27, some buttons are greyed out and other buttons are not greyed out. Clicking on the not-greyed-out buttons gives me a "You Shall Not Pass" dialog.

Revisions and Commits

rP Phabricator
	D12558	rPf347c002a6c6 Passphrase credentials should correctly grey out disallowed actions.

Related Objects

Mentioned In: T7499: "New Build Plan" should be greyed out if not allowed by policy
T7497: "Create Application" should be greyed out if not allowed by policy
T7496: "Add Providers" should be greyed out if not allowed

Event Timeline

joshuaspence created this task.Mar 7 2015, 2:21 AM

joshuaspence raised the priority of this task from to Needs Triage.

joshuaspence updated the task description. (Show Details)

joshuaspence added a project: Design.

joshuaspence added a subscriber: joshuaspence.

I don't follow what is incorrect here.

Clicking on "Edit Credential" (which is greyed out) returns the "You Shall Not Pass" dialog.
Clicking on "Allow Conduit Access" (which is not greyed out) also returns the "You Shall Not Pass" dialog.
So shouldn't "Allow Conduit Access" be greyed out as well?

In the screenshot above, the user does not have access to any items on that list, when clicking Lock Permanently it shows a dialog that says you shall not pass, which is correct, but that item should also be greyed out, there are several places that have this inconsistency.

Yeah, I don't think this is unique to Passphrase.

chad renamed this task from Buttons are not consistently greyed out to Buttons are not consistently greyed out in Passphrase.Mar 7 2015, 2:41 AM

chad edited projects, added Passphrase; removed Design.

Yea, its in multiple applications

Imma presume this specific task is to fix Passphrase. Developers specifically needing to check permissions and setting disabled on the button if access won't be granted. I understand it may also be incorrect in other applications, but we have to one-off fix them, it's not a global thing.