Page MenuHomePhabricator

Owners application unable to enter into details of owned packages
Closed, ResolvedPublic

Description

Since a pull this morning, I am getting the following problem:

[2015-03-18 14:54:44] EXCEPTION: (InvalidArgumentException) Argument 1 passed to PHUIHeaderView::addActionLink() must be an instance of PHUIButtonView, instance of PhutilSafeHTML given, called in /var/www/phabricator/src/applications/owners/controller/PhabricatorOwnersDetailController.php on line 204 and defined at [<phutil>/src/error/PhutilErrorHandler.php:200]
 arcanist(head=master, ref.master=b961869edac9), libphalias(), libphremoteuser(head=master, ref.master=1def4e2d7f07), phabricator(head=master, ref.master=1e4be36484af, custom=2), phutil(head=master, ref.master=ce3959b4046f)
 #0 PhutilErrorHandler::handleError(integer, string, string, integer, array) called at [<phabricator>/src/view/phui/PHUIHeaderView.php:76]
 #1 PHUIHeaderView::addActionLink(PhutilSafeHTML) called at [<phabricator>/src/applications/owners/controller/PhabricatorOwnersDetailController.php:204]
 #2 PhabricatorOwnersDetailController::processRequest() called at [<phabricator>/src/aphront/AphrontController.php:33]
 #3 AphrontController::handleRequest(AphrontRequest) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:196]
 #4 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:121]
 #5 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phabricator>/webroot/index.php:19]

Last pull was about a week ago, but Owners isn't a frequently used application, so it may have gone unnoticed longer than that...

Event Timeline

jasonrumney raised the priority of this task from to Needs Triage.
jasonrumney updated the task description. (Show Details)
jasonrumney added a project: Owners.
jasonrumney updated the task description. (Show Details)
jasonrumney added a subscriber: jasonrumney.
epriestley triaged this task as Normal priority.

This should be fixed in HEAD. Thanks for the report, and let us know if you run into anything else.

(The error specifically required that there be open audits affecting the package, which is probably why it went uncaught.)