How to create review of existing pushed commit?
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	devurandom
	Mar 20 2015, 2:37 PM

Description

I am trying to create a review of an existing and pushed commit.

It appears that arc's automagic considers only non-pushed commits [^1]. So I need to overwrite that somehow and force it to create a revision from the commit I point it to, no matter whether it is included in any remote branch or not. I find myself unable to do so. The [arc diff documentation](https://secure.phabricator.com/book/phabricator/article/arcanist_diff/) does not seem to cover this.

[^1]: I needed to push, to get the change out of the machine where I was writing it originally.

$ arc which
REPOSITORY
To identify the repository associated with this working copy, arc followed this process:

    Configuration value "repository.callsign" is empty.

    Configuration value "project.name" is set to "phabricator"; this project
    is associated with the "P" repository.

    Found a unique matching repository.

This working copy is associated with the P repository.

COMMIT RANGE
If you run 'arc diff', changes between the commit:

    010dcf6afe0c4f4b  Allow the LDAP authentication provider to hide its login form

...and the current working copy state will be sent to Differential, because
it is the merge-base of 'origin/feat/ldap-hide-loginform' (the Git upstream
of the current branch) HEAD.

You can see the exact changes that will be sent by running this command:

    $ git diff 010dcf6afe0c4f4b..HEAD

These commits will be included in the diff:

    (No commits.)


MATCHING REVISIONS
These Differential revisions match the changes in this working copy:

    (No revisions match.)

Since there are no revisions in Differential which match this working copy, a
new revision will be created if you run 'arc diff'.

Event Timeline

devurandom created this task.Mar 20 2015, 2:37 PM

devurandom raised the priority of this task from to Needs Triage.

devurandom updated the task description. (Show Details)

devurandom added projects: Arcanist, Differential, Documentation.

devurandom added a subscriber: devurandom.

Differential is our pre-commit workflow, Audit is the post-commit workflow. If you need to review something that is already committed, it's expected that you'll use Audit, unless I'm completely misunderstanding your question.

In general, we want the community to use IRC for questions on using Phabricator, as many other admins are available there to answer questions. https://secure.phabricator.com/book/phabricator/article/feedback/#irc

It's pushed to the origin remote, but not my upstream remote. I.e. I have been working on this internally, but now I want to officially submit it. For two reasons: (1) It needs review first (2) I do not have write access to the upstream repository.

Try reading this, which is entirely about this topic:

https://secure.phabricator.com/book/phabricator/article/arcanist_commit_ranges/

Presuming resolved.

urzds added a subscriber: urzds.Jul 12 2017, 11:11 AM

Herald added a subscriber: eadler. · View Herald TranscriptJul 12 2017, 11:11 AM

How to create review of existing pushed commit?Closed, ResolvedPublicActions

Description

Event Timeline

How to create review of existing pushed commit?
Closed, ResolvedPublic
Actions