Page MenuHomePhabricator
Create Task
Maniphest T7621

Exception when uploading a GIF
Closed, ResolvedPublic
Actions

Assigned To
epriestley
Authored By
champo
Mar 18 2015, 5:02 PM
Tags
None
Referenced Files
F341429: kh40Erv.gif
Mar 18 2015, 10:05 PM
F341430: o4tdvofznzw3hdxa9psk.gif
Mar 18 2015, 10:04 PM
F341290: Screen_Shot_2015-03-18_at_14.01.10.png
Mar 18 2015, 5:02 PM
Subscribers
chad
champo
epriestley

Description

I'm trying to upload a 11MB gif in Macros and I get a really nice exception:

All storage engines failed to write file:
    - PhabricatorChunkedFileStorageEngine: PhutilMethodNotImplementedException: Method writeFile in class PhabricatorChunkedFileStorageEngine is not implemented!
`

My storage engines look like:

Screen_Shot_2015-03-18_at_14.01.10.png (216×1 px, 45 KB)

Revisions and Commits

rP Phabricator
D12110rPb7fa55ff9396 Fix improper selection of the chunk engine as a writable engine

Related Objects

Event Timeline

champo created this task.Mar 18 2015, 5:02 PM
champo raised the priority of this task from to Needs Triage.
champo updated the task description. (Show Details)
champo added a subscriber: champo.
chad added a subscriber: chad.Mar 18 2015, 9:56 PM

This gif sounds awesome. Can we see it?

champo added a comment.Mar 18 2015, 10:03 PM

http://i.imgur.com/kh40Erv.gif

(Sorry, should've added that before)

chad added a comment.Mar 18 2015, 10:04 PM

o4tdvofznzw3hdxa9psk.gif (240×320 px, 491 KB)

champo added a comment.Mar 18 2015, 10:05 PM

kh40Erv.gif9 MBDownload

Works here

epriestley claimed this task.Mar 18 2015, 10:10 PM
epriestley added a subscriber: epriestley.

Chunk engine is being incorrectly selected as writable in non-chunking configs.

epriestley added a comment.Mar 18 2015, 10:18 PM

it is a pretty cool GIF tho

epriestley added a revision: D12110: Fix improper selection of the chunk engine as a writable engine.Mar 18 2015, 11:30 PM
epriestley closed this task as Resolved by committing rPb7fa55ff9396: Fix improper selection of the chunk engine as a writable engine.Mar 19 2015, 2:06 AM
epriestley added a commit: rPb7fa55ff9396: Fix improper selection of the chunk engine as a writable engine.
epriestley added a comment.Mar 19 2015, 2:11 AM

D12110 doesn't actually fix this, per se, it just gives you the correct error.

T5187 discusses the real fix (using chunked uploads on vanilla inputs).

Until then, the maximum size of a macro is 8MB. Sorry.

champo added a comment.Mar 19 2015, 2:30 AM

Yeah I figured it wouldn't work anyway, but the exception seemed like something worth reporting.

Phabricator · Built by Phacility