Page MenuHomePhabricator
Create Task
Maniphest T7629

Differentiate audience of Threads/Rooms with icon
Closed, ResolvedPublic
Actions

Description

I'd like to return an icon with the title basically depicting audiences. I presume this should just align with Policies, but maybe people have other ideas?

1-1 Thread
1-many Thread
Project based Room (private)
Project based Room (public)

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit

Event Timeline

chad created this task.Mar 19 2015, 9:53 PM
chad raised the priority of this task from to Needs Triage.
chad updated the task description. (Show Details)
chad added a project: Conpherence.
chad added subscribers: chad, btrahan, epriestley.
btrahan added a comment.Mar 19 2015, 9:55 PM

Policy sounds good. Its basically the full policy control so I think there's more options than you've delineated like "custom".

chad moved this task from Backlog to v2 on the Conpherence board.Mar 20 2015, 1:59 AM
johnny-bit awarded a token.Mar 20 2015, 4:55 PM
johnny-bit added a subscriber: johnny-bit.

This looks awesome. Icons make sense and relate to description perfectly.

epriestley added a comment.Mar 20 2015, 4:57 PM

Specifically:

  • For isRoom threads, you should be able to use $policy->getIcon() (on PhabricatorPolicy) to select an icon matching the policy that's consistent with policy icons elsewhere in other applications.
  • For non-room threads, the $policy isn't meaningful but you can easily special-case the icons.
btrahan claimed this task.Mar 25 2015, 6:49 PM
btrahan triaged this task as Normal priority.
btrahan triaged this task as Normal priority.
btrahan added a revision: Restricted Differential Revision.Mar 25 2015, 10:24 PM
btrahan closed this task as Resolved by committing Restricted Diffusion Commit.Mar 26 2015, 7:24 PM
btrahan added a commit: Restricted Diffusion Commit.
Phabricator · Built by Phacility