Page MenuHomePhabricator

Differentiate audience of Threads/Rooms with icon
Closed, ResolvedPublic

Description

I'd like to return an icon with the title basically depicting audiences. I presume this should just align with Policies, but maybe people have other ideas?

1-1 Thread
1-many Thread
Project based Room (private)
Project based Room (public)

Event Timeline

chad raised the priority of this task from to Needs Triage.
chad updated the task description. (Show Details)
chad added a project: Conpherence.
chad added subscribers: chad, btrahan, epriestley.

Policy sounds good. Its basically the full policy control so I think there's more options than you've delineated like "custom".

johnny-bit added a subscriber: johnny-bit.

This looks awesome. Icons make sense and relate to description perfectly.

Specifically:

  • For isRoom threads, you should be able to use $policy->getIcon() (on PhabricatorPolicy) to select an icon matching the policy that's consistent with policy icons elsewhere in other applications.
  • For non-room threads, the $policy isn't meaningful but you can easily special-case the icons.
btrahan triaged this task as Normal priority.
btrahan triaged this task as Normal priority.