Perhaps too little too late: changing to ((?<!\w)\w{3,}://) also resolves the issue for me. Limiting the protocol to 32 characters seems sane either way.

Perhaps \w{3,}+ resolves the issue? (+ being a possessive quantifier here that prevents backtracking)

Thanks - I thought it was already filed but couldn't seem to find it.

I'd love folder shortcuts (for directories that only contain a single directory). Clicking through a few levels in various Java projects would be slightly more pleasant.

I understand why the behavior has changed, and I'm not particularly opposed to keeping it as-is. I can easily reach over the line number - it's just that it initially appeared as a regression so I had to note it here.

On mobile I very quickly get an inline comment box when scrolling which then takes focus so scrolling is aborted.

No worries, totally understandable.

See https://secure.phabricator.com/T10382. I've mitigated by downgrading to 3.4.2 (some other version will probably work too, this just was the first one I tried)

For reference, I use this small script to allow myself to easily use arc land with bookmarks:

I'm about to start implement full dereferencing support. Cases that are missing now:

($expr)[0];
SomeClass::BRILLIANT_CONSTANT[5];

This is almost definitely T8298, because % can't be properly escaped on Windows right now.

@epriestley I can add <script language="PHP">... support to XHPAST if you'd like, but since it's removed from PHP7 and never was really mainstream I don't believe it's worth the effort.

You can probably use bin/policy unlock to open up the policy.

In the extreme case where you have, say, a million tests, I'd expect there is probably little value in reporting each test into Harbormaster as a "pass", and your harness might want to summarize all passes into "999,998 additional tests passed" and submit two failures and one aggregate-pass.

Visit /config/module/versions on your install. If it does not exist, you're not running HEAD.

• You can obtain the versions at /config/module/versions/ on your install
• The max nesting level is set to PHP_INT_MAX (see libphutil/scripts/__init_script__.php:44), so you should never see this error.

FWIW, I've pretty much never looked at "Open Revisions Affecting These Files", and only look at "Local Commits" to check if the parent commit is already pushed.

I wouldn't have expected the issue to be in xhpast at all. Thanks for the quick resolution!

We mitigated with:

So the preview didn't show the text on multiple lines. :/

Hahaha I suddenly remembered this

https://wiki.php.net/phpng-upgrading should contain a lot of relevant information.

aww

I have email notifications disabled wherever possible. When I shut down my computer, it'd be super useful to be able to get push notifications to my phone.

Wouldn't setting the view policy to "nobody" achieve pretty much the same?

Missing finally support is now starting to affect a large portion of my colleagues.

You can do this:

1. Some
# Item

Works like a charm now. :-)

Sorry, I think that did not fully resolve the issue - I still get the same exception after upgrading.

(Probably occurs thanks to D13283)

As per IRC:

[20:56:34] <_richardJ> I have a commit for which an Owners package of which I'm an owner requires an audit because of "owners not involved". However, I reviewed the actual revision.

At least Python and Mercurial itself use tags extensively, and there are many more projects that do.

Somewhat already mentioned a few times, but these are the two things me and co-workers noticed after using this feature for a while:

• The comments seem way too large to me. (We have a lot of inline discussion, probably a lot more than happens on this install)
• The "older"/"newer" comments appear on wrong lines a large chunk of the time. This is the most annoying part, I'd say, because a lot of inlines are really specific about what happens on a line.

Those two points aside, this feature is a huge win.

These changes fix it:

diff --git a/support/xhpast/scanner.l b/support/xhpast/scanner.l
index 28cf40f..bbdde72 100644
--- a/support/xhpast/scanner.l
+++ b/support/xhpast/scanner.l
@@ -313,8 +313,8 @@ NEWLINE ("\r\n"|"\n"|"\r")
   "("{TABS_AND_SPACES}unset{TABS_AND_SPACES}")" tok(T_UNSET_CAST);
 }

Not directly related to replies, but to creating tasks via email.

No, this a private server in an internal network. For some context, here a some of the version number that seem relevant:

I had this same issue, but there was only one not-closed default branch. Maybe just not show closed branches?

Yeah, in 5.6 this works.

richard @dev[~]
-> php -v
PHP 5.6.2-1 (cli) (built: Oct 17 2014 17:15:37) 
Copyright (c) 1997-2014 The PHP Group
Zend Engine v2.6.0, Copyright (c) 1998-2014 Zend Technologies
    with Zend OPcache v7.0.4-dev, Copyright (c) 1999-2014, by Zend Technologies
    with Xdebug v2.2.5, Copyright (c) 2002-2014, by Derick Rethans

This has been discussed on the https://groups.google.com/forum/#!topic/nodejs/zF7GEoPccqw as well.

(tiny heads up - I know you're quite busy)

(the other link was the 2nd hit on Google, but this is the official documentation: https://docs.npmjs.com/getting-started/installing-npm-packages-globally)

The update went pretty well, and it seems to work just fine!

Yeah, it did indeed. D11268 does solve the issue correctly for me in all cases I tested.

FWIW, this patch fixes it for me

diff --git a/support/xhpast/parser.y b/support/xhpast/parser.y
index 1697c26..e07704b 100644
--- a/support/xhpast/parser.y
+++ b/support/xhpast/parser.y
@@ -1176,7 +1176,7 @@ class_statement:
     yyextra->expecting_xhp_class_statements = yyextra->old_expecting_xhp_class_statements;

How about adding the $sort_flag to msort as a parameter? It could very well be useful to explicitly sort things numerically?

Diff that very hackily implements desktop notifications on top of standard notifications: https://secure.phabricator.com/differential/diff/27013/

I would like a configuration option, but I'm fine either way. I took me some time to get used to.

After installing bcrypt, did you restart the web server?

I'm not entirely sure that no highlighting by default is always reasonable. For example, the company I work at developers mainly PHP, and pretty much all code snippets we write in comments, tasks, etc. are PHP.

It was removed in {rPace1feb70220a589386d0fa7fd9163998e13f631}, for what it's worth.

Is there any interest in the fix I described in T6112? The downside is that it is a lot slower, but it at least works.

I did my best to find an existing task, but I couldn't find it. I even replied on it, so I should have known.

Ohhh. I think I'd prefer indigo indeed :-)