This should be fixed by changes in T13024.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Nov 30 2017
This should be fixed by changes in T13024.
Nov 29 2017
(I'm also open to improvements to the XHProf UI in Phabricator if you plan to use that to store and review profiles. Many obvious features like tagging and API access which would make it more usable for handling profiles of projects other than Phabricator itself are likely very easy to implement. But I'm not sure there's tons of room for real integrations, even if you used everything else in Phabricator, and you may imagine tooling which can't realistically exist in the scope of Phabricator.)
For general context:
In PHI231, a more experienced user went through this workflow:
Nov 28 2017
Another variation of this is that "Mailing List" users' addresses also can't be edited from the web UI.
I fumbled the task ID in D18793, but this should be resolved by that change.
I don't plan to pursue this.
Nov 27 2017
Nov 25 2017
Nov 22 2017
I backed out the earlier changes since I'm not sure when this will move forward, but:
After spending a couple hours on this, I more or less understand what we have to do, but it isn't entirely straightforward.
This can be "fixed" like this:
Nov 21 2017
In theory, you could require --config appear between hg and foo in hg foo .... This is already a valid position for --config (for example, hg --config x=y foo is valid), and already not a valid position for foo flags (for example, hg --branch default log is not valid).
Nov 18 2017
Nov 17 2017
Nov 16 2017
Nov 15 2017
I think the current state of things is:
Nov 14 2017
Nov 13 2017
We'll use the hardened mode once it's available, but I don't think we expect to take any further action here until then.
Nov 11 2017
The tools to perform this export are available in that project already. We don't plan to run the tools for you, since this just makes the workflow more complicated: you already have access to the tools you need to do this yourself.
Nov 10 2017
This is now in master so I've made the task public.
I don't want to leave RCE in Phabricator for 3 weeks, so I'm planning to land, deploy and disclose some version of the patch above today.
(I change visibility for this to @epriestley, @amckinley and @durin42 for now -- note that I intend to eventually make this issue public once the fix hits the commit log, so don't stockpile all your 0-days here.)
This doesn't seem to have caused any issues.
Nov 9 2017
The other major thing I tried was throwing exceptions when the values for %s, etc., contained --debugger or --config while constructing Mercurial commands.
I have a not-so-great patch for this ready when Mercurial makes a decision. This isn't great, but it's the best I could come up with after trying a few things.