Page MenuHomePhabricator
Feed Advanced Search

Nov 30 2017

epriestley closed T12592: User awaiting approval has no image as Resolved.

This should be fixed by changes in T13024.

Nov 30 2017, 9:43 PM · Bug Report, Auth
epriestley closed T12657: Add Authentication Factor fails silently for users without a verified email address as Resolved.

This should be fixed by changes in T13024.

Nov 30 2017, 9:43 PM · Auth, Bug Report
epriestley merged T12570: Installs without `gd` are unable to reach the setup warning telling them to install `gd` into T10405: Phabricator should generally work properly even if "gd" is not installed.
Nov 30 2017, 9:42 PM · Setup, Restricted Project
epriestley merged task T12570: Installs without `gd` are unable to reach the setup warning telling them to install `gd` into T10405: Phabricator should generally work properly even if "gd" is not installed.
Nov 30 2017, 9:42 PM · Setup, Bug Report
epriestley added a revision to T12855: In PHP7, "Throwable" and "Error" are exciting new exception classes: Unknown Object (Differential Revision).
Nov 30 2017, 7:29 PM · Infrastructure
epriestley added a member for Community: dho.
Nov 30 2017, 7:15 PM
epriestley added a revision to T10233: arc error message unclear for accepted revision in "plan change" state: Unknown Object (Differential Revision).
Nov 30 2017, 4:26 PM · Restricted Project, Bug Report
epriestley added a revision to T10233: arc error message unclear for accepted revision in "plan change" state: Unknown Object (Differential Revision).
Nov 30 2017, 3:53 PM · Restricted Project, Bug Report
epriestley added a revision to T10268: "Batch Edit" from workboards uses "?ids=X,Y,Z" which can exceed "Location" header or URL byte limits for large task sets: Unknown Object (Differential Revision).
Nov 30 2017, 3:28 PM · Customer Impact, Workboards, Maniphest
epriestley added a revision to T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support: Unknown Object (Differential Revision).
Nov 30 2017, 3:28 PM · Transactions, ApplicationEditor
epriestley renamed T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support from Update batch editor to Update bulk editor.
Nov 30 2017, 3:23 PM · Transactions, ApplicationEditor
epriestley added a revision to T10005: Implement an ApplicationEditor-based Bulk Editor: Unknown Object (Differential Revision).
Nov 30 2017, 1:40 PM · ApplicationEditor
epriestley added a revision to T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support: Unknown Object (Differential Revision).
Nov 30 2017, 1:40 PM · Transactions, ApplicationEditor
epriestley added a revision to T11286: make it possible to remove tasks from a batch edit tasks workflow: Unknown Object (Differential Revision).
Nov 30 2017, 1:40 PM · Maniphest, Feature Request
epriestley added a revision to T10152: Allow uri.allowed-protocols to be configured in the Phacility cluster: Unknown Object (Differential Revision).
Nov 30 2017, 12:34 PM · Phacility
epriestley added a revision to T11413: Support renaming Phacility instances: Unknown Object (Differential Revision).
Nov 30 2017, 12:34 PM · Phacility

Nov 29 2017

epriestley added a comment to T9805: XHProf will not build on PHP7.

(I'm also open to improvements to the XHProf UI in Phabricator if you plan to use that to store and review profiles. Many obvious features like tagging and API access which would make it more usable for handling profiles of projects other than Phabricator itself are likely very easy to implement. But I'm not sure there's tons of room for real integrations, even if you used everything else in Phabricator, and you may imagine tooling which can't realistically exist in the scope of Phabricator.)

Nov 29 2017, 9:05 PM · XHProf
epriestley added a comment to T9805: XHProf will not build on PHP7.

For general context:

Nov 29 2017, 8:58 PM · XHProf
epriestley added a comment to T10233: arc error message unclear for accepted revision in "plan change" state.

In PHI231, a more experienced user went through this workflow:

Nov 29 2017, 7:24 PM · Restricted Project, Bug Report

Nov 28 2017

epriestley added a comment to T11860: Bot email addresses can't be edited.

Another variation of this is that "Mailing List" users' addresses also can't be edited from the web UI.

Nov 28 2017, 7:20 PM · Setup, People
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Nov 28 2017, 7:09 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Nov 28 2017, 6:45 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley closed T8918: Header shows number of notifications and various other controls on the 2FA auth screen as Resolved.

I fumbled the task ID in D18793, but this should be resolved by that change.

Nov 28 2017, 6:05 PM · Security, Auth
epriestley closed T8918: Header shows number of notifications and various other controls on the 2FA auth screen, a subtask of T8442: Build Space switching UI, as Resolved.
Nov 28 2017, 6:05 PM · Restricted Project, Spaces, Wikimedia, Policy
epriestley added a revision to T8918: Header shows number of notifications and various other controls on the 2FA auth screen: Unknown Object (Differential Revision).
Nov 28 2017, 6:05 PM · Security, Auth
epriestley closed T13024: Fix various session initialization order issues as Resolved by committing Restricted Diffusion Commit.
Nov 28 2017, 6:02 PM · Auth
epriestley closed T8335: Email verification link doesn't let you verify on first click as Resolved by committing Restricted Diffusion Commit.
Nov 28 2017, 6:00 PM · FreeBSD, Auth
epriestley triaged T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support as Normal priority.
Nov 28 2017, 5:14 PM · Transactions, ApplicationEditor
epriestley closed T6064: One-Click Add Task on Workboard Columns as Wontfix.

I don't plan to pursue this.

Nov 28 2017, 5:07 PM · Restricted Project, Workboards
epriestley added a revision to T12646: Reduce the impact of "admin" backups on instances: Unknown Object (Differential Revision).
Nov 28 2017, 3:51 PM · Phacility, Ops
epriestley added a revision to T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile: Unknown Object (Differential Revision).
Nov 28 2017, 3:51 PM · XHProf, Ops, Phacility
epriestley added a revision to T11413: Support renaming Phacility instances: Unknown Object (Differential Revision).
Nov 28 2017, 3:51 PM · Phacility
epriestley added a revision to T12801: Simplify Almanac services in the Phacility production cluster: Unknown Object (Differential Revision).
Nov 28 2017, 3:51 PM · Almanac, Ops, Phacility
epriestley added a revision to T11413: Support renaming Phacility instances: Unknown Object (Differential Revision).
Nov 28 2017, 2:43 PM · Phacility
epriestley added a revision to T11413: Support renaming Phacility instances: Unknown Object (Differential Revision).
Nov 28 2017, 2:31 PM · Phacility
epriestley added a revision to T12101: Phabricator PHP 7 Compatibility: Unknown Object (Differential Revision).
Nov 28 2017, 2:05 PM · Infrastructure, Guides
epriestley added a revision to T12855: In PHP7, "Throwable" and "Error" are exciting new exception classes: Unknown Object (Differential Revision).
Nov 28 2017, 2:05 PM · Infrastructure
epriestley added a revision to T12190: In PHP7, include-time warnings from source files are ignored: Unknown Object (Differential Revision).
Nov 28 2017, 2:05 PM · Infrastructure
epriestley added a revision to T11413: Support renaming Phacility instances: Unknown Object (Differential Revision).
Nov 28 2017, 1:28 PM · Phacility
epriestley added a revision to T11413: Support renaming Phacility instances: Unknown Object (Differential Revision).
Nov 28 2017, 1:06 PM · Phacility
epriestley added a revision to T11413: Support renaming Phacility instances: Unknown Object (Differential Revision).
Nov 28 2017, 1:02 PM · Phacility
epriestley added a revision to T13024: Fix various session initialization order issues: Unknown Object (Differential Revision).
Nov 28 2017, 1:59 AM · Auth
epriestley added a revision to T13024: Fix various session initialization order issues: Unknown Object (Differential Revision).
Nov 28 2017, 1:36 AM · Auth
epriestley closed T9150: Users without access to any spaces cannot use welcome link to set their password as Wontfix.

I don't think this or T12421 are valid use cases, for reasons described in T12421, and don't plan to support them.

Nov 28 2017, 1:34 AM · Auth, Spaces
epriestley added a revision to T8335: Email verification link doesn't let you verify on first click: Unknown Object (Differential Revision).
Nov 28 2017, 1:26 AM · FreeBSD, Auth
epriestley added a revision to T13024: Fix various session initialization order issues: Unknown Object (Differential Revision).
Nov 28 2017, 1:26 AM · Auth
epriestley added a revision to T13024: Fix various session initialization order issues: Unknown Object (Differential Revision).
Nov 28 2017, 1:05 AM · Auth
epriestley added a revision to T13024: Fix various session initialization order issues: Unknown Object (Differential Revision).
Nov 28 2017, 12:55 AM · Auth
epriestley added a revision to T13024: Fix various session initialization order issues: Unknown Object (Differential Revision).
Nov 28 2017, 12:53 AM · Auth
epriestley added a revision to T13024: Fix various session initialization order issues: Unknown Object (Differential Revision).
Nov 28 2017, 12:43 AM · Auth
epriestley added a revision to T13024: Fix various session initialization order issues: Unknown Object (Differential Revision).
Nov 28 2017, 12:12 AM · Auth

Nov 27 2017

epriestley updated the task description for T13024: Fix various session initialization order issues.
Nov 27 2017, 10:36 PM · Auth
epriestley triaged T13024: Fix various session initialization order issues as Normal priority.
Nov 27 2017, 10:36 PM · Auth

Nov 25 2017

epriestley edited the content of Changelog.
Nov 25 2017, 1:16 PM
epriestley created 2017 Week 47 (Very Late November).
Nov 25 2017, 1:16 PM

Nov 22 2017

epriestley added a comment to T13018: Support Discourse's specific dialect of OpenGraph metadata tags to enrich Discourse "OneBox" previews.

I backed out the earlier changes since I'm not sure when this will move forward, but:

Nov 22 2017, 11:31 PM
epriestley added a revision to T13018: Support Discourse's specific dialect of OpenGraph metadata tags to enrich Discourse "OneBox" previews: Unknown Object (Differential Revision).
Nov 22 2017, 10:30 PM
epriestley closed T13022: Picture of a dog as Resolved.
Nov 22 2017, 10:26 PM
epriestley closed T13021: Task with no description as Resolved.
Nov 22 2017, 10:26 PM
epriestley created T13022: Picture of a dog.
Nov 22 2017, 10:18 PM
epriestley created T13021: Task with no description.
Nov 22 2017, 10:16 PM
epriestley triaged T13018: Support Discourse's specific dialect of OpenGraph metadata tags to enrich Discourse "OneBox" previews as Wishlist priority.

After spending a couple hours on this, I more or less understand what we have to do, but it isn't entirely straightforward.

Nov 22 2017, 9:05 PM
mihaim awarded T4752: Daemons may not have permission to remove files from local disk storage engine a Like token.
Nov 22 2017, 8:33 PM · Files
epriestley added a revision to T13018: Support Discourse's specific dialect of OpenGraph metadata tags to enrich Discourse "OneBox" previews: Unknown Object (Differential Revision).
Nov 22 2017, 7:27 PM
epriestley added a revision to T13018: Support Discourse's specific dialect of OpenGraph metadata tags to enrich Discourse "OneBox" previews: Unknown Object (Differential Revision).
Nov 22 2017, 5:25 PM
epriestley triaged T13019: Build Status is integrated into Diffusion in a hacky way as Low priority.
Nov 22 2017, 5:05 PM · Diffusion, Harbormaster
epriestley added a comment to T13019: Build Status is integrated into Diffusion in a hacky way.

This can be "fixed" like this:

Nov 22 2017, 5:05 PM · Diffusion, Harbormaster
epriestley added a revision to T13020: Migrate Maniphest transactions to improve consistency: Restricted Differential Revision.
Nov 22 2017, 2:15 PM · Transactions, Facts, Maniphest
epriestley created T13020: Migrate Maniphest transactions to improve consistency.
Nov 22 2017, 2:09 PM · Transactions, Facts, Maniphest

Nov 21 2017

epriestley added a comment to T13012: Mercurial "--config" and "--debugger" command injection vulnerability.

In theory, you could require --config appear between hg and foo in hg foo .... This is already a valid position for --config (for example, hg --config x=y foo is valid), and already not a valid position for foo flags (for example, hg --branch default log is not valid).

Nov 21 2017, 9:26 PM · Mercurial, Security

Nov 18 2017

epriestley edited the content of Changelog.
Nov 18 2017, 2:56 PM
epriestley created 2017 Week 46 (Late November).
Nov 18 2017, 2:55 PM

Nov 17 2017

epriestley added members for Community: mcote, skaufmann.
Nov 17 2017, 6:02 PM

Nov 16 2017

epriestley added a comment to T13016: Modulerize FileImageTransform implementation.

See also T6445 (SVG files) and T5258 (additional legacy cruft).

Nov 16 2017, 6:03 PM · Modernization

Nov 15 2017

epriestley added a comment to T7789: Support Git Large File Storage.

I think the current state of things is:

Nov 15 2017, 6:02 PM · Customer Impact, Restricted Project, Files, Diffusion

Nov 14 2017

epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Nov 14 2017, 8:13 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
avivey awarded T13015: Improve color readability for change age in Diffusion blame view a Like token.
Nov 14 2017, 8:04 PM · Design, Diffusion
epriestley created T13015: Improve color readability for change age in Diffusion blame view.
Nov 14 2017, 4:04 PM · Design, Diffusion
epriestley added a project to T13014: Improve design of "Owns No Changed Paths" flag in Differential: Differential.
Nov 14 2017, 4:02 PM · Differential, Design
epriestley created T13014: Improve design of "Owns No Changed Paths" flag in Differential.
Nov 14 2017, 4:02 PM · Differential, Design

Nov 13 2017

epriestley closed T13012: Mercurial "--config" and "--debugger" command injection vulnerability as Resolved.

We'll use the hardened mode once it's available, but I don't think we expect to take any further action here until then.

Nov 13 2017, 9:01 PM · Mercurial, Security
epriestley closed T13013: Regularly update i18n JSON localisation files , a subtask of T5267: Localize Phabricator, as Resolved.
Nov 13 2017, 9:00 PM · Prioritized, Localization
epriestley closed T13013: Regularly update i18n JSON localisation files as Resolved.
Nov 13 2017, 9:00 PM · Prioritized, Localization

Nov 11 2017

epriestley added a comment to T13013: Regularly update i18n JSON localisation files .

The tools to perform this export are available in that project already. We don't plan to run the tools for you, since this just makes the workflow more complicated: you already have access to the tools you need to do this yourself.

Nov 11 2017, 5:36 PM · Prioritized, Localization

Nov 10 2017

epriestley updated the task description for T13012: Mercurial "--config" and "--debugger" command injection vulnerability.
Nov 10 2017, 5:04 PM · Mercurial, Security
epriestley updated the task description for T13012: Mercurial "--config" and "--debugger" command injection vulnerability.
Nov 10 2017, 5:03 PM · Mercurial, Security
epriestley updated the task description for T13012: Mercurial "--config" and "--debugger" command injection vulnerability.
Nov 10 2017, 4:58 PM · Mercurial, Security
epriestley updated the task description for T13012: Mercurial "--config" and "--debugger" command injection vulnerability.
Nov 10 2017, 4:46 PM · Mercurial, Security
epriestley edited the content of Changelog.
Nov 10 2017, 4:46 PM
epriestley created 2017 Week 45 (Mid November).
Nov 10 2017, 4:45 PM
epriestley added a comment to T13012: Mercurial "--config" and "--debugger" command injection vulnerability.

This is now in master so I've made the task public.

Nov 10 2017, 4:42 PM · Mercurial, Security
epriestley changed the visibility for T13012: Mercurial "--config" and "--debugger" command injection vulnerability.
Nov 10 2017, 4:42 PM · Mercurial, Security
epriestley added a revision to T13012: Mercurial "--config" and "--debugger" command injection vulnerability: Unknown Object (Differential Revision).
Nov 10 2017, 4:22 PM · Mercurial, Security
epriestley added a comment to T13012: Mercurial "--config" and "--debugger" command injection vulnerability.

I don't want to leave RCE in Phabricator for 3 weeks, so I'm planning to land, deploy and disclose some version of the patch above today.

Nov 10 2017, 4:05 PM · Mercurial, Security
epriestley added a comment to T13012: Mercurial "--config" and "--debugger" command injection vulnerability.

(I change visibility for this to @epriestley, @amckinley and @durin42 for now -- note that I intend to eventually make this issue public once the fix hits the commit log, so don't stockpile all your 0-days here.)

Nov 10 2017, 3:50 PM · Mercurial, Security
epriestley shifted T13012: Mercurial "--config" and "--debugger" command injection vulnerability from the Restricted Space space to the S1 Core space.
Nov 10 2017, 3:48 PM · Mercurial, Security
epriestley renamed T13012: Mercurial "--config" and "--debugger" command injection vulnerability from Mercurial "--config" command injection vulnerability to Mercurial "--config" and "--debugger" command injection vulnerability.
Nov 10 2017, 3:42 PM · Mercurial, Security
epriestley closed T12680: Convert Audit to use UNION to improve the performance of the dashboard bucketing query as Resolved.

This doesn't seem to have caused any issues.

Nov 10 2017, 3:20 PM · Customer Impact, Restricted Project, Performance, Audit

Nov 9 2017

epriestley added a comment to T13012: Mercurial "--config" and "--debugger" command injection vulnerability.

The other major thing I tried was throwing exceptions when the values for %s, etc., contained --debugger or --config while constructing Mercurial commands.

Nov 9 2017, 4:08 PM · Mercurial, Security
epriestley added a comment to T13012: Mercurial "--config" and "--debugger" command injection vulnerability.

I have a not-so-great patch for this ready when Mercurial makes a decision. This isn't great, but it's the best I could come up with after trying a few things.

Nov 9 2017, 3:43 PM · Mercurial, Security