Page MenuHomePhabricator

Improve color readability for change age in Diffusion blame view
Closed, ResolvedPublic

Description

Currently, the blame view of Diffusion colors commits by age, with light green for more recent changes and dark green for older ones. However:

  • It uses absolute age to pick a brightness, so if a file was changed once long ago and then many times recently (which, on average, is most files in active/growing projects) we get a few darker greens and many very bright greens. Better might be to divide the spectrum evenly by the number of changes.
  • Changing both hue and brightness (e.g., dark orange to bright green) might make the different colors much easier to distinguish.

See also PHI174.

Revisions and Commits

Restricted Differential Revision

Event Timeline

This feels a bit like a return to the era of "epriestley design", but I think it's an improvement overall:

Screen Shot 2018-04-09 at 6.02.42 AM.png (370×322 px, 52 KB)

epriestley added a revision: Restricted Differential Revision.Apr 9 2018, 1:09 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Apr 9 2018, 1:11 PM
epriestley added a commit: Restricted Diffusion Commit.