Maniphest T13024

Fix various session initialization order issues
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	epriestley
	Nov 27 2017, 10:36 PM

Tags

Referenced Files

None

Subscribers

Description

Sessions have a few minor initialization order issues, where different flags interact negatively or awkwardly. These aren't exactly dependent, but the testing mostly overlaps.

PHI223: Required legalpad documents conflict with required MFA.
T8918: Header shows number of notifications and various other controls on the 2FA auth screen
https://discourse.phabricator-community.org/t/activation-link-in-welcome-mail-only-works-if-new-user-isnt-semi-logged-in/740/4 I haven't really evaluated this yet but it might be an adjacent issue here. This might be the same as T8335.
I'll mention T12421/T9150 here; while I still don't really consider those to be valid use cases, they may be easy to fix.

Revisions and Commits

rP Phabricator
	D18840	rPad4db9b2f3f8 Separate "Set/Reset Password" from "Change Password"
	D18793	rPe919233b3182 Don't show personalized menu items until users establish a full session
	D18792	rPdc62d18b4736 Allow MFA enrollment before email verification
	D18791	rPab0f61aa323d Tell users to "Wait Patiently" for admin account verification later in the…
	D18790	rPc7718d3a2126 Ask users to sign Legalpad documents before requiring they enroll in MFA
	D18789	rPe850bc6b957a When requiring login signatures, order documents from oldest to newest
	D18788	rPba4b9f71849f Refactor on-login Legalpad document signature requirement
	D18786	rP71406ca93bf4 Lightly modernize LegalpadDocumentSearchEngine
	D18785	rP3d742eb50baf Lightly modernize LegalpadDocumentQuery

Related Objects

Mentioned In: T13310: Users with no access to Spaces can not log out
T13154: Public tasks not displayed when logged in under a not-yet-approved user account
rP50d5fa87a3fc: (stable) Restore the "Log In" menubar action
rP4f8340c05f2b: Restore the "Log In" menubar action
D18818: Restore the "Log In" menubar action
T12592: User awaiting approval has no image
T12657: Add Authentication Factor fails silently for users without a verified email address
Mentioned Here: T8335: Email verification link doesn't let you verify on first click
T8918: Header shows number of notifications and various other controls on the 2FA auth screen
T9150: Users without access to any spaces cannot use welcome link to set their password
T12421: Can't verify email address if user doesn't have view policy for any space

Event Timeline

epriestley triaged this task as Normal priority.Nov 27 2017, 10:36 PM

epriestley created this task.

Herald added a subscriber: eadler. · View Herald TranscriptNov 27 2017, 10:36 PM

epriestley updated the task description. (Show Details)Nov 27 2017, 10:36 PM

storrgie added a subscriber: storrgie.Nov 27 2017, 11:07 PM

epriestley added a revision: D18785: Lightly modernize LegalpadDocumentQuery.Nov 28 2017, 12:12 AM

epriestley added a revision: D18786: Lightly modernize LegalpadDocumentSearchEngine.Nov 28 2017, 12:43 AM

epriestley added a revision: D18788: Refactor on-login Legalpad document signature requirement.Nov 28 2017, 12:53 AM

epriestley added a revision: D18789: When requiring login signatures, order documents from oldest to newest.Nov 28 2017, 12:55 AM

epriestley added a revision: D18790: Ask users to sign Legalpad documents before requiring they enroll in MFA.Nov 28 2017, 1:05 AM

epriestley added a revision: D18791: Tell users to "Wait Patiently" for admin account verification later in the registration process.Nov 28 2017, 1:26 AM

epriestley added a revision: D18792: Allow MFA enrollment before email verification.Nov 28 2017, 1:36 AM

epriestley added a revision: D18793: Don't show personalized menu items until users establish a full session.Nov 28 2017, 1:59 AM

epriestley added a commit: rP3d742eb50baf: Lightly modernize LegalpadDocumentQuery.Nov 28 2017, 5:56 PM

epriestley added a commit: rP71406ca93bf4: Lightly modernize LegalpadDocumentSearchEngine.

epriestley added a commit: rPba4b9f71849f: Refactor on-login Legalpad document signature requirement.Nov 28 2017, 5:58 PM

epriestley added a commit: rPe850bc6b957a: When requiring login signatures, order documents from oldest to newest.

epriestley added a commit: rPc7718d3a2126: Ask users to sign Legalpad documents before requiring they enroll in MFA.

epriestley added a commit: rPab0f61aa323d: Tell users to "Wait Patiently" for admin account verification later in the….

epriestley closed this task as Resolved by committing rPe919233b3182: Don't show personalized menu items until users establish a full session.Nov 28 2017, 6:01 PM

epriestley added a commit: rPdc62d18b4736: Allow MFA enrollment before email verification.

epriestley added a commit: rPe919233b3182: Don't show personalized menu items until users establish a full session.

epriestley mentioned this in T12657: Add Authentication Factor fails silently for users without a verified email address.Nov 30 2017, 9:43 PM

epriestley mentioned this in T12592: User awaiting approval has no image.

epriestley mentioned this in D18818: Restore the "Log In" menubar action.Dec 5 2017, 1:47 PM

epriestley mentioned this in rP4f8340c05f2b: Restore the "Log In" menubar action.Dec 5 2017, 8:13 PM

epriestley mentioned this in rP50d5fa87a3fc: (stable) Restore the "Log In" menubar action.

epriestley added a revision: D18840: Separate "Set/Reset Password" from "Change Password".Dec 22 2017, 8:11 PM

epriestley added a commit: rPad4db9b2f3f8: Separate "Set/Reset Password" from "Change Password".Dec 26 2017, 4:34 PM

epriestley mentioned this in T13154: Public tasks not displayed when logged in under a not-yet-approved user account.Jun 19 2018, 8:33 PM

epriestley mentioned this in T13310: Users with no access to Spaces can not log out.Jun 13 2019, 11:49 PM