Page MenuHomePhabricator
Feed Advanced Search

Sep 6 2017

chad committed rPa903388d4f89: Update EditEngine pages to take a page header separate (authored by chad).
Update EditEngine pages to take a page header separate
Sep 6 2017, 3:07 AM
chad closed D18527: Update EditEngine pages to take a page header separate.
Sep 6 2017, 3:07 AM
chad updated the diff for D18527: Update EditEngine pages to take a page header separate.
  • rebase
Sep 6 2017, 3:06 AM
chad committed rP6e25d4c67b1a: Update Settings for WHITE_CONFIG style boxes (authored by chad).
Update Settings for WHITE_CONFIG style boxes
Sep 6 2017, 2:42 AM
chad closed D18526: Update Settings for WHITE_CONFIG style boxes.
Sep 6 2017, 2:42 AM
chad updated the diff for D18526: Update Settings for WHITE_CONFIG style boxes.
  • fix rebase
Sep 6 2017, 2:41 AM
chad updated the diff for D18526: Update Settings for WHITE_CONFIG style boxes.
  • rebase?
Sep 6 2017, 2:25 AM
chad committed rPfc893658b8b6: Update menu item names for Applications -> Favorites (authored by chad).
Update menu item names for Applications -> Favorites
Sep 6 2017, 2:05 AM
chad closed D18524: Update menu item names for Applications -> Favorites.
Sep 6 2017, 2:05 AM
chad committed rPe1fd74ddb545: Update Repository Management pages to new fixed UI (authored by chad).
Update Repository Management pages to new fixed UI
Sep 6 2017, 2:01 AM
chad closed D18523: Update Repository Management pages to new fixed UI.
Sep 6 2017, 2:01 AM
chad updated the diff for D18523: Update Repository Management pages to new fixed UI.
  • rebase?
Sep 6 2017, 1:57 AM
chad accepted D18541: Fix a similar lint rendering issue when trimming identical lines out of patches.
Sep 6 2017, 12:11 AM

Sep 5 2017

chad accepted D18540: Add Ferret engine index support to Differential.
Sep 5 2017, 11:43 PM
chad accepted D18539: Add support for relevance-ranking Ferret engine results.
Sep 5 2017, 11:33 PM
chad committed rPaf7c92f2c64e: Config re-design (authored by chad).
Config re-design
Sep 5 2017, 10:24 PM
chad closed D18519: Config re-design.
Sep 5 2017, 10:24 PM
chad updated the diff for D18519: Config re-design.
  • double check diff by hand
Sep 5 2017, 10:22 PM
chad updated the diff for D18519: Config re-design.
  • Add back crumbs, icons
Sep 5 2017, 10:04 PM
chad accepted D18538: Fix a prefix/suffix counting issue in Arcanist lint rendering.
Sep 5 2017, 8:04 PM
chad accepted D18537: Fix credential control logic for restricted credentials.
Sep 5 2017, 6:50 PM
chad planned changes to D18519: Config re-design.

Will update with crumbs and icons.

Sep 5 2017, 6:31 PM
chad accepted D18536: Move Ferret engine "title:..." field definitions to the engine itself.
Sep 5 2017, 6:31 PM
chad created T12975: Unable to update Credential on URI when credential policy is set to other user.
Sep 5 2017, 6:27 PM · Passphrase, Diffusion
chad committed rP5ceca721cce3: Minor bug fix with PHUIInfoView (authored by chad).
Minor bug fix with PHUIInfoView
Sep 5 2017, 5:42 PM
chad closed D18522: Minor bug fix with PHUIInfoView.
Sep 5 2017, 5:42 PM
chad committed rP33b4de9acff2: Update Setup Issue UI (authored by chad).
Update Setup Issue UI
Sep 5 2017, 5:40 PM
chad closed D18521: Update Setup Issue UI.
Sep 5 2017, 5:40 PM
chad committed rP0efad0276a8d: Vertical align header buttons (authored by chad).
Vertical align header buttons
Sep 5 2017, 5:40 PM
chad closed D18520: Vertical align header buttons.
Sep 5 2017, 5:40 PM
chad accepted D18534: Reduce the number of magic strings in the Ferret implementation.
Sep 5 2017, 5:19 PM
chad accepted D18533: Consolidate more Ferret engine code into FerretEngine.
Sep 5 2017, 5:15 PM
chad added a comment to D18519: Config re-design.

This is the search thing in Discourse and it works super well. As a first time admin, I used it like 50 times to find all the stuff I wanted to change without feeling overwhelmed by 500 options. I thinkkkkkk I could build a typeahead datasource and do this?

Sep 5 2017, 4:44 PM
chad added a comment to D18519: Config re-design.

Icons: I can add back icons, I'm sort of on the fence of how useful they are.

Sep 5 2017, 4:33 PM
chad added a comment to D18524: Update menu item names for Applications -> Favorites.

I definitely understand that thinking and if we were building a new product today, do that. At least, I think we generally do that? Renaming applications comes with legacy baggage, and I'm not convinced the cost of the baggage plus the engineering cost outweigh a basic solution that could easily be rolled back. When you have very limited resources, how do you budget changes that are "correct, but highly expensive" vs "incorrect, but very cheap". Outside of an engineering organization, do you make that same decision? I gave serious consideration to renaming them this weekend, and that path seemed in the 1-2 month range for me, even if you agreed to it. I can't in good conscience allocate that much time to a single point of polish.

Sep 5 2017, 4:16 PM
chad added a comment to D18524: Update menu item names for Applications -> Favorites.

I strongly dislike this change and think it solves a non-problem that only a few users experience and which we've already given them tools to deal with.

Sep 5 2017, 2:30 PM
chad created D18532: Update Drydock to new Edit UI.
Sep 5 2017, 1:27 AM

Sep 4 2017

chad created D18531: Update Phriction with new Edit UI.
Sep 4 2017, 11:58 PM
chad created D18530: Update Pholio Edit pages to new UI.
Sep 4 2017, 11:50 PM
chad created D18529: Update Create Diff page for new Edit UI.
Sep 4 2017, 11:45 PM
chad created D18528: Update Dashboards for new Edit UI.
Sep 4 2017, 11:40 PM
chad updated the diff for D18526: Update Settings for WHITE_CONFIG style boxes.
  • update two separate panels
Sep 4 2017, 11:21 PM
chad updated the diff for D18527: Update EditEngine pages to take a page header separate.
  • remove unused var
Sep 4 2017, 11:15 PM
chad updated the test plan for D18527: Update EditEngine pages to take a page header separate.
Sep 4 2017, 10:35 PM
chad created D18527: Update EditEngine pages to take a page header separate.
Sep 4 2017, 10:33 PM
chad added a comment to T12923: Settings Forms, EditEngine instructions are visually confusing.

I'd probably lean towards just increasing the padding under the text to make sure the field is clearly separate from the one below it.

Sep 4 2017, 10:14 PM · Design
chad created D18526: Update Settings for WHITE_CONFIG style boxes.
Sep 4 2017, 7:59 PM
chad created D18524: Update menu item names for Applications -> Favorites.
Sep 4 2017, 4:27 PM
chad updated the test plan for D18523: Update Repository Management pages to new fixed UI.
Sep 4 2017, 12:28 AM
chad created D18523: Update Repository Management pages to new fixed UI.
Sep 4 2017, 12:27 AM

Sep 3 2017

chad added inline comments to D18519: Config re-design.
Sep 3 2017, 5:57 PM
chad updated the diff for D18519: Config re-design.
  • back out phui-info-view tweaks
Sep 3 2017, 4:48 PM
chad created D18522: Minor bug fix with PHUIInfoView.
Sep 3 2017, 4:41 PM
chad updated the diff for D18519: Config re-design.
  • move header css change
  • back out setup issue CSS
Sep 3 2017, 4:08 PM
chad created D18521: Update Setup Issue UI.
Sep 3 2017, 4:05 PM
chad created D18520: Vertical align header buttons.
Sep 3 2017, 3:56 PM
chad updated the diff for D18519: Config re-design.
  • add todo for crumbs
Sep 3 2017, 3:14 AM
chad retitled D18519: Config re-design from [WIP] Config re-design to Config re-design.
Sep 3 2017, 3:10 AM
chad updated the diff for D18519: Config re-design.
  • finished first pass
Sep 3 2017, 3:02 AM

Sep 2 2017

chad shifted P1887 Arcanist Installation Shell Script for Linux from the S3 Hyperspace space to the S1 Core space.
Sep 2 2017, 11:57 PM · libphutil, Arcanist
chad created D18519: Config re-design.
Sep 2 2017, 4:11 AM
chad accepted D18518: Cheat our way through `arc version` on Windows for the moment.
Sep 2 2017, 1:05 AM

Sep 1 2017

chad awarded T12974: Upgrading: "Ferret" Fulltext Engine a 100 token.
Sep 1 2017, 5:08 PM · Installing & Upgrading, Search
chad accepted D18514: Create a virtual "core" field in the Ferret engine for "title and body together".
Sep 1 2017, 4:39 PM
chad accepted D18513: Separate fulltext engine extensions into "enrich" and "index" phases.
Sep 1 2017, 4:27 PM
chad updated the summary of D18513: Separate fulltext engine extensions into "enrich" and "index" phases.
Sep 1 2017, 4:27 PM

Aug 31 2017

chad accepted D18512: Restore ANSI highlighting of lint sections to lint output.
Aug 31 2017, 8:20 PM
chad accepted D18510: Render lint patches which have newlines in a less misleading way.
Aug 31 2017, 7:43 PM
chad accepted D18511: Restore the caret pointer ("^") for lint lines which only have a character offset.
Aug 31 2017, 7:40 PM
chad accepted D18509: Extract and cover the logic for "trimming" a lint message.
Aug 31 2017, 6:55 PM
chad accepted D18508: Add basic test coverage for lint console rendering.
Aug 31 2017, 3:49 PM
chad added a comment to T9295: Date chooser picket fence issue with next month.

@mna Please follow our bug reporting guidelines if you feel you've encountered a bug. This task is several years old and not relevant.

Aug 31 2017, 1:35 PM · Calendar
allixsenos awarded D18482: Clarify language when Autoclose is disabled for a repository a Party Time token.
Aug 31 2017, 12:51 AM

Aug 30 2017

chad committed rPab99222f28f5: Fix harbormaster ui on history view / mobile (authored by chad).
Fix harbormaster ui on history view / mobile
Aug 30 2017, 7:58 PM
chad closed D18507: Fix harbormaster ui on history view / mobile.
Aug 30 2017, 7:58 PM
chad created D18507: Fix harbormaster ui on history view / mobile.
Aug 30 2017, 7:57 PM
chad committed rP2ba5968b7639: Mobile layouts for Diffusion (authored by chad).
Mobile layouts for Diffusion
Aug 30 2017, 7:28 PM
chad closed D18505: Mobile layouts for Diffusion.
Aug 30 2017, 7:28 PM
chad updated the diff for D18505: Mobile layouts for Diffusion.
  • fix scope of CSS rule in ApplicationSearch
Aug 30 2017, 7:06 PM
chad updated the diff for D18505: Mobile layouts for Diffusion.
  • remove history specific code no longer needed
Aug 30 2017, 6:49 PM
chad committed rP67c658a7ed87: Use selected button state on blame button (authored by chad).
Use selected button state on blame button
Aug 30 2017, 6:33 PM
chad closed D18504: Use selected button state on blame button.
Aug 30 2017, 6:33 PM
chad accepted D18506: Limit the damage that degenerate project name typeahead queries can cause.
Aug 30 2017, 6:23 PM
chad created D18505: Mobile layouts for Diffusion.
Aug 30 2017, 6:21 PM
chad accepted D18503: Add "title:..." support to the Ferret engine.
Aug 30 2017, 5:26 PM
chad created D18504: Use selected button state on blame button.
Aug 30 2017, 5:24 PM
chad accepted D18502: Support "-term" in Ferret engine queries.
Aug 30 2017, 5:15 PM
chad committed rP11046d495dbf: Add a selected button ui state (authored by chad).
Add a selected button ui state
Aug 30 2017, 5:14 PM
chad closed D18501: Add a selected button ui state.
Aug 30 2017, 5:14 PM
chad updated the diff for D18501: Add a selected button ui state.
  • simpler
Aug 30 2017, 5:01 PM
chad created D18501: Add a selected button ui state.
Aug 30 2017, 4:54 PM
chad accepted D18500: Provide some "term vs substring" support for the Ferret engine.

I believe this is the right path forward, though the road may be bumpy.

Aug 30 2017, 4:40 PM
chad accepted D18499: Parse raw Ferret queries into tokens before processing them.
Aug 30 2017, 4:09 PM
chad accepted D18498: Add a "terms" corpus to Ferret fields.
Aug 30 2017, 2:59 PM
chad accepted D18497: Aggregate corpus data in Ferret field rows.
Aug 30 2017, 2:26 PM

Aug 29 2017

chad created T12973: Commit list changes based on hash in URL.
Aug 29 2017, 8:47 PM · Diffusion
chad accepted D18492: Add support for parsing more syntax in search queries.
Aug 29 2017, 6:59 PM
chad accepted D18490: Fix an issue where "Close Revision" did not appear in the UI.
Aug 29 2017, 4:57 PM
chad committed rPf3f671aa90ec: Align first nav item in settings (authored by chad).
Align first nav item in settings
Aug 29 2017, 4:40 PM
chad closed D18489: Align first nav item in settings.
Aug 29 2017, 4:40 PM