Page MenuHomePhabricator

Reduce the number of magic strings in the Ferret implementation
ClosedPublic

Authored by epriestley on Sep 5 2017, 4:48 PM.
Tags
None
Referenced Files
F15571238: D18534.id44513.diff
Mon, May 5, 4:55 AM
F15559829: D18534.id44513.diff
Tue, Apr 29, 11:15 AM
F15551088: D18534.diff
Sun, Apr 27, 3:17 PM
F15543369: D18534.id.diff
Fri, Apr 25, 10:07 PM
F15541140: D18534.id44500.diff
Fri, Apr 25, 10:59 AM
F15537679: D18534.diff
Thu, Apr 24, 3:03 PM
F15440595: D18534.id44513.diff
Mar 26 2025, 1:42 PM
F15438094: D18534.id.diff
Mar 25 2025, 11:21 PM
Subscribers
None

Details

Summary

Ref T12819. Push more of the magic ' ' stuff into the engine and simplify calls to ngram construction.

Also fixes a bug where a task with title "apple banana" and description "cherry doughnut" could match query "banana cherry" by separating separate term segments with newlines instead of spaces.

Test Plan
  • Indexed some objects.
  • Searched (term, substring, quoted terms).
  • Viewed index in database.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable