Page MenuHomePhabricator

Reduce the number of magic strings in the Ferret implementation
ClosedPublic

Authored by epriestley on Sep 5 2017, 4:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 1, 6:18 PM
Unknown Object (File)
Sat, Mar 1, 3:13 PM
Unknown Object (File)
Thu, Feb 27, 1:01 AM
Unknown Object (File)
Thu, Feb 27, 1:01 AM
Unknown Object (File)
Thu, Feb 27, 12:36 AM
Unknown Object (File)
Thu, Feb 27, 12:34 AM
Unknown Object (File)
Sun, Feb 23, 8:49 PM
Unknown Object (File)
Sun, Feb 9, 9:32 PM
Subscribers
None

Details

Summary

Ref T12819. Push more of the magic ' ' stuff into the engine and simplify calls to ngram construction.

Also fixes a bug where a task with title "apple banana" and description "cherry doughnut" could match query "banana cherry" by separating separate term segments with newlines instead of spaces.

Test Plan
  • Indexed some objects.
  • Searched (term, substring, quoted terms).
  • Viewed index in database.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable