Page MenuHomePhabricator

Reduce the number of magic strings in the Ferret implementation
ClosedPublic

Authored by epriestley on Sep 5 2017, 4:48 PM.
Tags
None
Referenced Files
F18745522: D18534.id44500.diff
Fri, Oct 3, 7:41 AM
F18608053: D18534.diff
Sun, Sep 14, 12:49 AM
F18509052: D18534.id.diff
Sep 5 2025, 3:11 AM
F18501511: D18534.diff
Sep 4 2025, 9:48 PM
F18167444: D18534.id44513.diff
Aug 15 2025, 11:49 AM
F18113004: D18534.id.diff
Aug 12 2025, 10:48 PM
F18111256: D18534.id44500.diff
Aug 12 2025, 9:47 AM
F18110043: D18534.diff
Aug 11 2025, 3:45 PM
Subscribers
None

Details

Summary

Ref T12819. Push more of the magic ' ' stuff into the engine and simplify calls to ngram construction.

Also fixes a bug where a task with title "apple banana" and description "cherry doughnut" could match query "banana cherry" by separating separate term segments with newlines instead of spaces.

Test Plan
  • Indexed some objects.
  • Searched (term, substring, quoted terms).
  • Viewed index in database.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable