Page MenuHomePhabricator

Reduce the number of magic strings in the Ferret implementation
ClosedPublic

Authored by epriestley on Sep 5 2017, 4:48 PM.
Tags
None
Referenced Files
F14055885: D18534.diff
Sat, Nov 16, 4:30 PM
F13960764: D18534.diff
Oct 15 2024, 1:15 AM
Unknown Object (File)
Oct 7 2024, 2:06 AM
Unknown Object (File)
Sep 13 2024, 2:26 AM
Unknown Object (File)
Sep 13 2024, 2:25 AM
Unknown Object (File)
Sep 13 2024, 2:25 AM
Unknown Object (File)
Sep 13 2024, 2:25 AM
Unknown Object (File)
Sep 1 2024, 12:04 AM
Subscribers
None

Details

Summary

Ref T12819. Push more of the magic ' ' stuff into the engine and simplify calls to ngram construction.

Also fixes a bug where a task with title "apple banana" and description "cherry doughnut" could match query "banana cherry" by separating separate term segments with newlines instead of spaces.

Test Plan
  • Indexed some objects.
  • Searched (term, substring, quoted terms).
  • Viewed index in database.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable