Page MenuHomePhabricator

Reduce the number of magic strings in the Ferret implementation
ClosedPublic

Authored by epriestley on Sep 5 2017, 4:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 3, 11:07 PM
Unknown Object (File)
Tue, Jun 28, 3:39 AM
Unknown Object (File)
Fri, Jun 17, 10:05 AM
Unknown Object (File)
Sat, Jun 11, 9:31 AM
Unknown Object (File)
Thu, Jun 9, 8:48 AM
Unknown Object (File)
Tue, Jun 7, 11:13 PM
Unknown Object (File)
Jun 4 2022, 5:27 PM
Unknown Object (File)
May 29 2022, 12:30 PM
Subscribers
None

Details

Summary

Ref T12819. Push more of the magic ' ' stuff into the engine and simplify calls to ngram construction.

Also fixes a bug where a task with title "apple banana" and description "cherry doughnut" could match query "banana cherry" by separating separate term segments with newlines instead of spaces.

Test Plan
  • Indexed some objects.
  • Searched (term, substring, quoted terms).
  • Viewed index in database.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable