Page MenuHomePhabricator

Reduce the number of magic strings in the Ferret implementation
ClosedPublic

Authored by epriestley on Sep 5 2017, 4:48 PM.
Tags
None
Referenced Files
F19015514: D18534.id.diff
Sun, Nov 23, 12:25 AM
F18804658: D18534.id.diff
Oct 18 2025, 10:25 AM
F18792228: D18534.id44513.diff
Oct 16 2025, 7:13 PM
F18759796: D18534.id44500.diff
Oct 6 2025, 5:57 AM
F18759079: D18534.diff
Oct 6 2025, 1:40 AM
F18745522: D18534.id44500.diff
Oct 3 2025, 7:41 AM
F18608053: D18534.diff
Sep 14 2025, 12:49 AM
F18509052: D18534.id.diff
Sep 5 2025, 3:11 AM
Subscribers
None

Details

Summary

Ref T12819. Push more of the magic ' ' stuff into the engine and simplify calls to ngram construction.

Also fixes a bug where a task with title "apple banana" and description "cherry doughnut" could match query "banana cherry" by separating separate term segments with newlines instead of spaces.

Test Plan
  • Indexed some objects.
  • Searched (term, substring, quoted terms).
  • Viewed index in database.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable