Page MenuHomePhabricator

Reduce the number of magic strings in the Ferret implementation
ClosedPublic

Authored by epriestley on Sep 5 2017, 4:48 PM.
Tags
None
Referenced Files
F15440595: D18534.id44513.diff
Wed, Mar 26, 1:42 PM
F15438094: D18534.id.diff
Tue, Mar 25, 11:21 PM
F15435892: D18534.id44500.diff
Tue, Mar 25, 10:46 AM
F15432316: D18534.diff
Mon, Mar 24, 5:28 PM
F15382135: D18534.id44500.diff
Fri, Mar 14, 10:52 AM
Unknown Object (File)
Mar 1 2025, 6:18 PM
Unknown Object (File)
Mar 1 2025, 3:13 PM
Unknown Object (File)
Feb 27 2025, 1:01 AM
Subscribers
None

Details

Summary

Ref T12819. Push more of the magic ' ' stuff into the engine and simplify calls to ngram construction.

Also fixes a bug where a task with title "apple banana" and description "cherry doughnut" could match query "banana cherry" by separating separate term segments with newlines instead of spaces.

Test Plan
  • Indexed some objects.
  • Searched (term, substring, quoted terms).
  • Viewed index in database.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable