Page MenuHomePhabricator

Consolidate more Ferret engine code into FerretEngine
ClosedPublic

Authored by epriestley on Sep 5 2017, 4:30 PM.
Tags
None
Referenced Files
F18732640: D18533.diff
Tue, Sep 30, 7:07 PM
F18656920: D18533.diff
Mon, Sep 22, 11:50 PM
F18591667: D18533.diff
Fri, Sep 12, 9:50 AM
F18509051: D18533.id.diff
Sep 5 2025, 3:11 AM
F18501510: D18533.diff
Sep 4 2025, 9:48 PM
F18447965: D18533.id.diff
Aug 31 2025, 11:07 PM
F18423137: D18533.diff
Aug 30 2025, 7:22 PM
F17989551: D18533.id44499.diff
Aug 1 2025, 11:49 PM
Subscribers
None

Details

Summary

Ref T12819. Earlier I separated some ngram code into an "ngram engine" hoping to share it across the simple Ngrams stuff and the full Ferret stuff, but they actually use slightly different rules. Just pull more of this stuff into FerretEngine to reduce the number of moving pieces and the amount of code duplication.

Test Plan

Searched for terms, rebuilt indexes.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Sep 5 2017, 5:15 PM
This revision was automatically updated to reflect the committed changes.