HomePhabricator

Update menu item names for Applications -> Favorites

Description

Update menu item names for Applications -> Favorites

Summary: Adds a MenuName method to applications that ProfileMenuItem uses instead of the application name if set. This improves the home/menu/new user experience at little cost. Also renamed the label from Applications to Favorites, since this menu gets altered to provide more than just applications. This also allows instances to set back to Maniphest if they so choose. Overall I think this direction resolves 95% of my concerns, with maybe a small potential downside which I don't really anticipate. We already name Dashboard panels by their object, and that hasn't really caused confusion. I think these links are similar. I click 'Tasks' and get presented a list of my tasks from Maniphest.

Test Plan: Review each of the name changes as a default new install and a modified install.

Reviewers: epriestley, amckinley

Reviewed By: epriestley

Spies: Korvin

Differential Revision: https://secure.phabricator.com/D18524

Details

Provenance
Chad Little <chad@phacility.com>Authored on Sep 4 2017, 4:20 PM
chadPushed on Sep 6 2017, 2:05 AM
Reviewer
epriestley
Differential Revision
D18524: Update menu item names for Applications -> Favorites
Parents
rPe1fd74ddb545: Update Repository Management pages to new fixed UI
Branches
Unknown
Tags
Unknown
Build Status
Buildable 18311
Build 24641: Run Core Tests