HomePhabricator

Update EditEngine pages to take a page header separate

Tags
None
Referenced Files
F5166181: image.png
Sep 6 2017, 3:07 AM
Subscribers
None

Description

Update EditEngine pages to take a page header separate

Summary: This simplifies EditEngine pages in general by removing the dual header, and extending to allow setting of a custom PHUIHeaderView if needed (like settings).

Test Plan:
Review all settings pages, review task, project pages. This should all be fine, but is a big change maybe some layouts I'm not considering. Tested these all mobile, destkop as well.

image.png (1×2 px, 228 KB)

Reviewers: epriestley

Reviewed By: epriestley

Spies: Korvin

Differential Revision: https://secure.phabricator.com/D18527

Details

Provenance
Chad Little <chad@phacility.com>Authored on Sep 6 2017, 3:02 AM
chadPushed on Sep 6 2017, 3:07 AM
Reviewer
epriestley
Differential Revision
D18527: Update EditEngine pages to take a page header separate
Parents
rP6e25d4c67b1a: Update Settings for WHITE_CONFIG style boxes
Branches
Unknown
Tags
Unknown
Build Status
Buildable 18316
Build 24649: Run Core Tests