Page MenuHomePhabricator

Fix an issue where "Close Revision" did not appear in the UI
ClosedPublic

Authored by epriestley on Aug 29 2017, 4:55 PM.
Tags
None
Referenced Files
F18848450: D18490.diff
Thu, Oct 30, 4:50 AM
F18768000: D18490.id.diff
Wed, Oct 8, 1:16 AM
F18732168: D18490.id.diff
Sep 30 2025, 4:43 PM
F18711792: D18490.diff
Sep 29 2025, 4:54 AM
F18509026: D18490.id.diff
Sep 5 2025, 3:10 AM
F18501470: D18490.diff
Sep 4 2025, 9:46 PM
F18421269: D18490.id.diff
Aug 30 2025, 4:56 PM
F18170397: D18490.id44417.diff
Aug 15 2025, 6:03 PM
Subscribers
None

Details

Summary

Ref T2543. When called from the UI to build the dropdown, there's no Editor, since we aren't actually in an edit flow.

This logic worked for actually performing the edits, just not for getting the option into the dropdown.

Test Plan

Used the dropdown to close an "Accepted" revision which I authored.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Aug 29 2017, 4:57 PM

Specifically, getEditor() would throw, and the caller would interpret that as "action isn't available".

I'm going to cherry-pick and hotfix this.

This revision was automatically updated to reflect the committed changes.