Page MenuHomePhabricator

Fix an issue where "Close Revision" did not appear in the UI
ClosedPublic

Authored by epriestley on Aug 29 2017, 4:55 PM.

Details

Summary

Ref T2543. When called from the UI to build the dropdown, there's no Editor, since we aren't actually in an edit flow.

This logic worked for actually performing the edits, just not for getting the option into the dropdown.

Test Plan

Used the dropdown to close an "Accepted" revision which I authored.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Aug 29 2017, 4:55 PM
chad accepted this revision.Aug 29 2017, 4:57 PM
This revision is now accepted and ready to land.Aug 29 2017, 4:57 PM

Specifically, getEditor() would throw, and the caller would interpret that as "action isn't available".

I'm going to cherry-pick and hotfix this.

This revision was automatically updated to reflect the committed changes.