Paths

Table of Contentst

Differential D18490

Fix an issue where "Close Revision" did not appear in the UI
ClosedPublic
Actions

Authored by epriestley on Aug 29 2017, 4:55 PM.

Details

Reviewers

chad

Maniphest Tasks

T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential

Commits

rP017125598631: (stable) Fix an issue where "Close Revision" did not appear in the UI
rPf49d103af5d3: Fix an issue where "Close Revision" did not appear in the UI

Summary

Ref T2543. When called from the UI to build the dropdown, there's no Editor, since we aren't actually in an edit flow.

This logic worked for actually performing the edits, just not for getting the option into the dropdown.

Test Plan

Used the dropdown to close an "Accepted" revision which I authored.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 29 2017, 4:55 PM

Harbormaster completed remote builds in B18202: Diff 44415.Aug 29 2017, 4:56 PM

chad accepted this revision.Aug 29 2017, 4:57 PM

This revision is now accepted and ready to land.Aug 29 2017, 4:57 PM

Specifically, getEditor() would throw, and the caller would interpret that as "action isn't available".

I'm going to cherry-pick and hotfix this.

Closed by commit rPf49d103af5d3: Fix an issue where "Close Revision" did not appear in the UI (authored by epriestley). · Explain WhyAug 29 2017, 4:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

xaction/

DifferentialRevisionCloseTransaction.php

10 lines

transactions/

storage/

PhabricatorModularTransactionType.php

4 lines

Diff 44417

View Options

src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php