Page MenuHomePhabricator

Parse raw Ferret queries into tokens before processing them
ClosedPublic

Authored by epriestley on Aug 30 2017, 3:40 PM.
Tags
None
Referenced Files
F18809020: D18499.id44445.diff
Sun, Oct 19, 10:31 AM
F18762054: D18499.diff
Mon, Oct 6, 5:24 PM
F18596291: D18499.diff
Sep 13 2025, 12:18 AM
F18586850: D18499.diff
Sep 11 2025, 7:52 PM
F18586849: D18499.diff
Sep 11 2025, 7:52 PM
F18509032: D18499.id.diff
Sep 5 2025, 3:10 AM
F18501479: D18499.diff
Sep 4 2025, 9:46 PM
F18449640: D18499.diff
Sep 1 2025, 12:41 AM
Subscribers
None

Details

Summary

Ref T12819. Depends on D18492. Instead of passing a raw query into the Query layer, parse it first.

This allows the query layer to figure out which parts should be substring vs term match, and would allow the SearchEngine layer to do author:... eventually by picking it out before sending it to the Ferret engine.

Test Plan

Ran some Ferret queries. They work like before, except that nonsense like -+"quack" raises an exception now.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable