Page MenuHomePhabricator

Update EditEngine pages to take a page header separate
ClosedPublic

Authored by chad on Sep 4 2017, 10:33 PM.
Tags
None
Referenced Files
F18108523: D18527.id44532.diff
Mon, Aug 11, 7:23 AM
F18107918: D18527.id.diff
Mon, Aug 11, 3:50 AM
F18106461: D18527.diff
Sun, Aug 10, 10:59 PM
F18090957: D18527.diff
Wed, Aug 6, 6:16 PM
F18048744: D18527.id44492.diff
Sun, Aug 3, 1:59 PM
F17678652: D18527.id44491.diff
Jul 13 2025, 1:32 PM
F17677031: D18527.id44492.diff
Jul 13 2025, 11:07 AM
F17652444: D18527.id44532.diff
Jul 12 2025, 6:44 AM
Subscribers

Details

Summary

This simplifies EditEngine pages in general by removing the dual header, and extending to allow setting of a custom PHUIHeaderView if needed (like settings).

Test Plan

Review all settings pages, review task, project pages. This should all be fine, but is a big change maybe some layouts I'm not considering. Tested these all mobile, destkop as well.

image.png (1×2 px, 228 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Sep 5 2017, 1:13 PM
This revision was automatically updated to reflect the committed changes.