Page MenuHomePhabricator

Update EditEngine pages to take a page header separate
ClosedPublic

Authored by chad on Sep 4 2017, 10:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 20, 3:59 PM
Unknown Object (File)
Sun, Nov 20, 2:27 PM
Unknown Object (File)
Thu, Nov 17, 12:51 AM
Unknown Object (File)
Sat, Nov 12, 10:05 AM
Unknown Object (File)
Sat, Nov 12, 6:39 AM
Unknown Object (File)
Sat, Nov 12, 6:38 AM
Unknown Object (File)
Sat, Nov 12, 6:38 AM
Unknown Object (File)
Sat, Nov 12, 6:38 AM
Subscribers

Details

Summary

This simplifies EditEngine pages in general by removing the dual header, and extending to allow setting of a custom PHUIHeaderView if needed (like settings).

Test Plan

Review all settings pages, review task, project pages. This should all be fine, but is a big change maybe some layouts I'm not considering. Tested these all mobile, destkop as well.

image.png (1×2 px, 228 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Sep 5 2017, 1:13 PM
This revision was automatically updated to reflect the committed changes.