Page MenuHomePhabricator

Update EditEngine pages to take a page header separate
ClosedPublic

Authored by chad on Sep 4 2017, 10:33 PM.
Tags
None
Referenced Files
F15530144: D18527.id44492.diff
Wed, Apr 23, 2:06 AM
F15512754: D18527.id44491.diff
Thu, Apr 17, 1:31 PM
F15484626: D18527.id44533.diff
Wed, Apr 9, 7:16 PM
F15482084: D18527.id44533.diff
Wed, Apr 9, 2:47 AM
F15482032: D18527.id44491.diff
Wed, Apr 9, 2:14 AM
F15481944: D18527.id44492.diff
Wed, Apr 9, 1:03 AM
F15473995: D18527.diff
Sun, Apr 6, 3:50 AM
F15466474: D18527.id44532.diff
Thu, Apr 3, 5:57 AM
Subscribers

Details

Summary

This simplifies EditEngine pages in general by removing the dual header, and extending to allow setting of a custom PHUIHeaderView if needed (like settings).

Test Plan

Review all settings pages, review task, project pages. This should all be fine, but is a big change maybe some layouts I'm not considering. Tested these all mobile, destkop as well.

image.png (1×2 px, 228 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Sep 5 2017, 1:13 PM
This revision was automatically updated to reflect the committed changes.