Page MenuHomePhabricator
Feed Advanced Search

Apr 12 2017

epriestley moved T9069: arc patch can't handle binary file correctly from Backlog to Active Impact on the Customer Impact board.
Apr 12 2017, 3:29 PM · Differential, Restricted Project, Arcanist
epriestley moved T12538: Search field in header doesn't show both tags and (disabled, bot, or mailing list) users with same name from Backlog to Active Impact on the Customer Impact board.
Apr 12 2017, 3:29 PM · Customer Impact, Typeahead, Bug Report
epriestley moved T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token from Backlog to Active Impact on the Customer Impact board.
Apr 12 2017, 3:29 PM · Search, Customer Impact, Bug Report
epriestley moved T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails from Backlog to Requests on the Customer Impact board.
Apr 12 2017, 3:28 PM · Phortune, Phacility
epriestley moved T12325: Dynamically adjust the display precision of countdowns to increase dramatic tension from Backlog to Requests on the Customer Impact board.
Apr 12 2017, 3:28 PM · Customer Impact, Countdown, Feature Request
epriestley moved T11336: Provide a stable address range for Phacility outbound requests from Backlog to Requests on the Customer Impact board.
Apr 12 2017, 3:28 PM · Customer Impact
epriestley edited projects for T11336: Provide a stable address range for Phacility outbound requests, added: Customer Impact; removed Phacility.
Apr 12 2017, 3:28 PM · Customer Impact
epriestley added a comment to T12537: Ambiguous display of commits in maniphest.

This is somewhat difficult because querying which branches a commit appears on is slow (in some cases, extremely slow; see T9898), and it is difficult to cache because a small write (pushing one new branch) can change the branches that millions of commits appear on. For example, if I do this:

Apr 12 2017, 3:25 PM · Feature Request
epriestley added a project to T12538: Search field in header doesn't show both tags and (disabled, bot, or mailing list) users with same name: Customer Impact.
Apr 12 2017, 3:13 PM · Customer Impact, Typeahead, Bug Report
epriestley edited projects for T12483: SAAS install reporting that they are unable to clone with "git svn", added: Customer Impact; removed Phacility.
Apr 12 2017, 3:13 PM · Customer Impact, Git, Subversion, Diffusion
epriestley edited projects for T12325: Dynamically adjust the display precision of countdowns to increase dramatic tension, added: Customer Impact; removed Phacility.
Apr 12 2017, 3:12 PM · Customer Impact, Countdown, Feature Request
epriestley edited projects for T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token, added: Customer Impact; removed Phacility.
Apr 12 2017, 3:12 PM · Search, Customer Impact, Bug Report
epriestley removed a project from T9069: arc patch can't handle binary file correctly: Phacility.
Apr 12 2017, 3:12 PM · Differential, Restricted Project, Arcanist
epriestley edited projects for T9069: arc patch can't handle binary file correctly, added: Customer Impact; removed Prioritized.
Apr 12 2017, 3:12 PM · Differential, Restricted Project, Arcanist
epriestley moved T12425: User-initiated search reindex tasks can end up stuck behind import tasks in the daemon queue from Backlog to Future on the Customer Impact board.
Apr 12 2017, 3:11 PM · Customer Impact, Daemons, Search, Diffusion
epriestley moved T8973: Encoding JSON for presentation could use more human-friendly escaping rules from Backlog to Future on the Customer Impact board.
Apr 12 2017, 3:11 PM · Customer Impact
epriestley edited projects for T12425: User-initiated search reindex tasks can end up stuck behind import tasks in the daemon queue, added: Customer Impact; removed Phacility.
Apr 12 2017, 3:10 PM · Customer Impact, Daemons, Search, Diffusion
epriestley edited projects for T12379: Instance reporting difficulty pushing the Linux kernel to a Phacility instance, added: Customer Impact; removed Phacility.
Apr 12 2017, 3:10 PM · Customer Impact, Diffusion, Ops
epriestley moved T12300: git push --mirror --force does not work on Phacility with repo that has refs/pull from Backlog to "Customers" on the Customer Impact board.
Apr 12 2017, 3:10 PM · Diffusion, Git
epriestley moved T12318: Loading Symbols in Phacility (Conduit) from Backlog to "Customers" on the Customer Impact board.
Apr 12 2017, 3:10 PM · Customer Impact, Symbols, Feature Request
epriestley edited projects for T12318: Loading Symbols in Phacility (Conduit), added: Customer Impact; removed Phacility.
Apr 12 2017, 3:10 PM · Customer Impact, Symbols, Feature Request
epriestley added a comment to T12538: Search field in header doesn't show both tags and (disabled, bot, or mailing list) users with same name.

Yeah, the user is struck through because they are "closed", which is because they are a bot. This isn't the best way to deal with this, but it dates from early 2014 (D8231) when everything was simpler.

Apr 12 2017, 3:09 PM · Customer Impact, Typeahead, Bug Report
epriestley edited projects for T12300: git push --mirror --force does not work on Phacility with repo that has refs/pull, added: Customer Impact; removed Phacility.
Apr 12 2017, 3:01 PM · Diffusion, Git
epriestley updated the image for Customer Impact from F4898879: fa-bug-yellow.png to F4898889: profile.
Apr 12 2017, 2:57 PM
epriestley archived Phacility Support.
Apr 12 2017, 2:56 PM
epriestley edited projects for T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails, added: Customer Impact; removed Phacility, Phacility Support.
Apr 12 2017, 2:56 PM · Phortune, Phacility
epriestley edited projects for T8973: Encoding JSON for presentation could use more human-friendly escaping rules, added: Customer Impact; removed Phacility Support.
Apr 12 2017, 2:56 PM · Customer Impact
epriestley created Customer Impact.
Apr 12 2017, 2:52 PM
epriestley archived Support Impact.
Apr 12 2017, 2:49 PM
epriestley archived High Support Impact.
Apr 12 2017, 2:49 PM
epriestley removed a project from T4411: Adding a CC to a Maniphest Task should give View rights for that user: Support Impact.
Apr 12 2017, 2:49 PM · Wikimedia, Policy
epriestley removed a project from T4752: Daemons may not have permission to remove files from local disk storage engine: Support Impact.
Apr 12 2017, 2:49 PM · Files
epriestley removed projects from T5554: arc fails with svn/git/hg non english locales: Support Impact, High Support Impact.
Apr 12 2017, 2:49 PM · Arcanist
epriestley edited projects for T5726: Add more information to story POSTs during the feed.http-hooks hook, added: Feed; removed Support Impact.
Apr 12 2017, 2:49 PM · Feed
epriestley removed a project from T5969: Add timeouts to service calls to external mailers (was: PhabricatorMetaMTAWorker may hang indefinitely if "sendmail" hangs indefinitely): Support Impact.
Apr 12 2017, 2:49 PM · Mail
epriestley removed a project from T6072: Improve usability of `arc diff`: Support Impact.
Apr 12 2017, 2:48 PM · Restricted Project, Documentation, Arcanist
epriestley removed a project from T6136: Improve behaviors around selecting a huge commit range in `arc`: Support Impact.
Apr 12 2017, 2:48 PM · Arcanist
epriestley removed a project from T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it: Support Impact.
Apr 12 2017, 2:48 PM · Search
epriestley removed a project from T8075: arc patch fails on Windows with SVN (because it uses "cd", not "setCWD"): Support Impact.
Apr 12 2017, 2:48 PM · Windows, Arcanist
epriestley edited projects for T12438: Project tokenizer functions like "any()" and "not()" do not include descendants, added: Typeahead; removed Search.
Apr 12 2017, 2:46 PM · Typeahead, Projects, Maniphest, Feature Request
epriestley edited projects for T5941: Show Phriction Pages in Search Typeahead, added: Phriction; removed Search.

Just kicking this out of Search since it's really Phriction specific.

Apr 12 2017, 2:46 PM · Phriction
epriestley closed T12493: Upgrading: Fulltext Search Services as Resolved.

This has been live for nearly two weeks without anything apparently exploding so we don't have any further acton planned upstream (although see T12450 for some followups). If you do run into issues, feel free to file new tasks describing them.

Apr 12 2017, 2:43 PM · Elasticsearch, Search, Guides
epriestley closed T8660: Top search bar is not consistent about searching open vs closed document types as Wontfix.

This has been open for about two years without a significant amount of additional confusion or interest, so I don't currently plan to change it.

Apr 12 2017, 2:42 PM · FreeBSD, Search, Restricted Project
epriestley merged T12500: Render highlighted search result body snippets in global search results views into T8646: Provide more context for search results, particularly wiki documents.
Apr 12 2017, 2:40 PM · Design, Search, Restricted Project
epriestley merged task T12500: Render highlighted search result body snippets in global search results views into T8646: Provide more context for search results, particularly wiki documents.
Apr 12 2017, 2:40 PM · Elasticsearch, Search, Feature Request
epriestley added a comment to T12500: Render highlighted search result body snippets in global search results views.

I'm just going to merge this into T8646 which broadly discusses richer search results.

Apr 12 2017, 2:40 PM · Elasticsearch, Search, Feature Request
epriestley moved T10315: Make it more clear to users how to rebuild search indexes after adding search support to custom fields from v2 to Future on the Search board.
Apr 12 2017, 2:38 PM · Custom Fields, Search, Documentation
epriestley renamed T7860: When users search for "#x y", treat "#x" as a project hashtag from Project tags can not be found via the fulltext search index to When users search for "#x y", treat "#x" as a project hashtag.
Apr 12 2017, 2:38 PM · Search
epriestley edited projects for T6906: Archived / closed objects don't have "closed" look in typeahead results, in global search typeahead only, added: Typeahead; removed Search.
Apr 12 2017, 2:36 PM · Typeahead, Contributor Onboarding, Design
epriestley moved T12493: Upgrading: Fulltext Search Services from Backlog to v2 on the Search board.
Apr 12 2017, 2:35 PM · Elasticsearch, Search, Guides
epriestley moved T12500: Render highlighted search result body snippets in global search results views from Backlog to v2 on the Search board.
Apr 12 2017, 2:35 PM · Elasticsearch, Search, Feature Request
epriestley closed T12244: Provide a crude way to selectively disable reads and writes of repository devices by setting flags on Almanac bindings as Wontfix.

DiffusionSSHWorkflow->execute() currently makes a proxying decision before it determines if a request is a read or write request. This needs to be reworked before we can support separate flags, since the host we'd choose to proxy the request will vary if only some hosts are readable/writable.

Apr 12 2017, 2:03 PM · Restricted Project, Almanac
epriestley added a comment to T12244: Provide a crude way to selectively disable reads and writes of repository devices by setting flags on Almanac bindings.

(For reference, see discussion elsewhere.)

Apr 12 2017, 1:34 PM · Restricted Project, Almanac
epriestley added a comment to T12538: Search field in header doesn't show both tags and (disabled, bot, or mailing list) users with same name.

My intended fix here is:

Apr 12 2017, 12:03 PM · Customer Impact, Typeahead, Bug Report
epriestley moved T12543: `phd` can't handle PID properly when there are multiple phabricator daemons. from Backlog to Future on the Daemons board.
Apr 12 2017, 11:53 AM · Daemons, Bug Report
epriestley triaged T12543: `phd` can't handle PID properly when there are multiple phabricator daemons. as Wishlist priority.

Running multiple different versions of Phabricator on a single host is not currently supported. We should probably handle this situation better than we do, and there is no technical reason we can't support this, but this use case is very rare.

Apr 12 2017, 11:53 AM · Daemons, Bug Report

Apr 11 2017

epriestley added a comment to T12542: Build a macro typeahead.

How about "i" for "image"?

Apr 11 2017, 11:29 PM · Macros, Remarkup
epriestley added a comment to T12542: Build a macro typeahead.

I am also keeping an eye on https://www.reddit.com/r/bonehurtingjuice/. It's still a small meme but if it takes off we're all going to be drinking bone hurting juice this time next month.

Apr 11 2017, 11:06 PM · Macros, Remarkup
epriestley added a comment to T12542: Build a macro typeahead.

Also our meme format is very outdated, the new meme format is:

Apr 11 2017, 10:58 PM · Macros, Remarkup
epriestley added a comment to T12541: Unable to resolve method 'describeAutomaticCapability'.

This should be fixed at HEAD of master, thanks for the report!

Apr 11 2017, 10:24 PM · Bug Report
epriestley closed T12541: Unable to resolve method 'describeAutomaticCapability' as Resolved by committing Restricted Diffusion Commit.
Apr 11 2017, 10:21 PM · Bug Report
epriestley added a revision to T12541: Unable to resolve method 'describeAutomaticCapability': Unknown Object (Differential Revision).
Apr 11 2017, 10:00 PM · Bug Report
matelich awarded T929: Allow two arbitrary revisions to be compared in Diffusion a Mountain of Wealth token.
Apr 11 2017, 9:00 PM · Diffusion (v3), Restricted Project
epriestley triaged T12538: Search field in header doesn't show both tags and (disabled, bot, or mailing list) users with same name as Low priority.
Apr 11 2017, 7:40 PM · Customer Impact, Typeahead, Bug Report
epriestley added a comment to T12538: Search field in header doesn't show both tags and (disabled, bot, or mailing list) users with same name.

D17656 is legitimately pretty hacky so this is now entangled with T11110, etc.

Apr 11 2017, 7:40 PM · Customer Impact, Typeahead, Bug Report
epriestley triaged T12539: Revision with an older "accept" showed up in "waiting on other reviewers" after "request review" as Low priority.

This is a legitimate bug but I think it's very long-standing and fixing it requires doing a lot of extra data loading to get the current diff PHID. Until someone else notices, I'd rather wait for diff PHIDs to be denormalized onto revisions.

Apr 11 2017, 7:23 PM · Differential
epriestley renamed T12538: Search field in header doesn't show both tags and (disabled, bot, or mailing list) users with same name from Search field in header doesn't show both tags and users with same name to Search field in header doesn't show both tags and (disabled, bot, or mailing list) users with same name.
Apr 11 2017, 7:13 PM · Customer Impact, Typeahead, Bug Report
epriestley added a revision to T12538: Search field in header doesn't show both tags and (disabled, bot, or mailing list) users with same name: Unknown Object (Differential Revision).
Apr 11 2017, 7:11 PM · Customer Impact, Typeahead, Bug Report
epriestley added a project to T12538: Search field in header doesn't show both tags and (disabled, bot, or mailing list) users with same name: Typeahead.

This is a sort-of-intended result of several different rules colliding to make a mess. Here's the primary rule:

Apr 11 2017, 7:09 PM · Customer Impact, Typeahead, Bug Report
epriestley created T12539: Revision with an older "accept" showed up in "waiting on other reviewers" after "request review".
Apr 11 2017, 6:44 PM · Differential
epriestley added a comment to T12536: `PhabricatorRepositoryGitCommitMessageParserWorker` fails with `Got unexpected parameters: isPartial`.

This should be fixed by D17654 and available at HEAD of master and stable. Thanks for the report!

Apr 11 2017, 6:43 PM · Bug Report
epriestley added a comment to T12535: Diffusion view to show the commits within a range..

This is technically supported, but not easy to find in the UI right now. Here's an example:

Apr 11 2017, 6:39 PM · Feature Request
epriestley added a comment to T12538: Search field in header doesn't show both tags and (disabled, bot, or mailing list) users with same name.

This reproduces for me locally. (??!?)

Apr 11 2017, 6:36 PM · Customer Impact, Typeahead, Bug Report
epriestley closed T12536: `PhabricatorRepositoryGitCommitMessageParserWorker` fails with `Got unexpected parameters: isPartial` as Resolved by committing Restricted Diffusion Commit.
Apr 11 2017, 6:29 PM · Bug Report
epriestley added a revision to T12536: `PhabricatorRepositoryGitCommitMessageParserWorker` fails with `Got unexpected parameters: isPartial`: Unknown Object (Differential Revision).
Apr 11 2017, 5:56 PM · Bug Report
epriestley added a comment to T11760: Phacility Cluster: Ad-Hoc Query Log.

A small subset of instances were queried with this script (below) to assess the impact/priority of T12137. This script examines fulltext search queries, but the only output is a ratio of potentially affected, unique queries first issued in the last 30 days, like this:

Apr 11 2017, 4:42 PM · Phacility
epriestley added a comment to T12534: Differential still appears in "responsible users" query after resigning as a reviewer.

This is currently expected, although we could consider changing it.

Apr 11 2017, 11:29 AM · Bug Report (Needs Information), Differential
epriestley changed the status of T12533: Reducing "Accept" action to not render a checkbox when only one package or project would be accepted is perhaps more confusing than not from Invalid to Resolved by committing Restricted Diffusion Commit.
Apr 11 2017, 12:28 AM · Owners, Restricted Project, Bug Report
epriestley added a revision to T12533: Reducing "Accept" action to not render a checkbox when only one package or project would be accepted is perhaps more confusing than not: Unknown Object (Differential Revision).
Apr 11 2017, 12:10 AM · Owners, Restricted Project, Bug Report
epriestley renamed T12533: Reducing "Accept" action to not render a checkbox when only one package or project would be accepted is perhaps more confusing than not from Reviewers are unable to accept for a subset of packages if they have all been rejected to Reducing "Accept" action to not render a checkbox when only one package or project would be accepted is perhaps more confusing than not.
Apr 11 2017, 12:08 AM · Owners, Restricted Project, Bug Report
epriestley added a comment to T12533: Reducing "Accept" action to not render a checkbox when only one package or project would be accepted is perhaps more confusing than not.

You should have sweeping janitorial powers as a member of Community now.

Apr 11 2017, 12:05 AM · Owners, Restricted Project, Bug Report
epriestley added a member for Community: lvital.
Apr 11 2017, 12:04 AM

Apr 10 2017

epriestley added a comment to T12533: Reducing "Accept" action to not render a checkbox when only one package or project would be accepted is perhaps more confusing than not.

It looks like before step (2), jmeador can only accept for one reviewer (the package), since he's already accepted for himself. The current rule is:

Apr 10 2017, 11:21 PM · Owners, Restricted Project, Bug Report
epriestley added a comment to T12515: Upgrading: File Integrity Hashing and SHA1.

T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0 discusses one side effect of these changes, it should be fixed in HEAD of master and stable now.

Apr 10 2017, 11:04 PM · Files, Guides, Security
epriestley awarded T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0 a Mountain of Wealth token.
Apr 10 2017, 11:03 PM · Arcanist, Files, Bug Report
epriestley closed T12503: Curtain sections may overflow boundaries in the UI as Resolved by committing Restricted Diffusion Commit.
Apr 10 2017, 11:02 PM · PHUI
epriestley closed T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0 as Resolved by committing Restricted Diffusion Commit.
Apr 10 2017, 11:01 PM · Arcanist, Files, Bug Report
epriestley added a comment to T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0.

Thanks for that catch in D17651, let me know if you're still seeing issues after updating. I'll cherry-pick that to stable too.

Apr 10 2017, 11:00 PM · Arcanist, Files, Bug Report
epriestley added a comment to T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0.

Yeah, that looks like it's consistent with the hypothesis above. I expect:

Apr 10 2017, 10:58 PM · Arcanist, Files, Bug Report
epriestley added a comment to T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0.

Yeah, pretty sure what's happening is:

Apr 10 2017, 10:52 PM · Arcanist, Files, Bug Report
epriestley added a comment to T11667: Default global syntax.filemap sets default filetypes to JavaScript for JSON configurations.

See also T12532 for related work.

Apr 10 2017, 10:49 PM · Contributor Onboarding, Bug Report
epriestley added a revision to T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0: Unknown Object (Differential Revision).
Apr 10 2017, 10:49 PM · Arcanist, Files, Bug Report
epriestley added a comment to T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0.

I think the first error is causing (maybe?) the chunk engine to fail, so we're falling back to the "upload the entire file in one shot" engine, which ain't great on 4GB files.

Apr 10 2017, 10:44 PM · Arcanist, Files, Bug Report
epriestley added a comment to T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0.

Alright, let me take a look. That exception is pretty specific and it may be obvious from the code.

Apr 10 2017, 10:39 PM · Arcanist, Files, Bug Report
epriestley added a comment to T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0.

(Actually maybe you need a 9MB file.)

Apr 10 2017, 10:37 PM · Arcanist, Files, Bug Report
epriestley added a comment to T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0.

Does this reproduce with a 5MB file?

Apr 10 2017, 10:37 PM · Arcanist, Files, Bug Report
epriestley moved T12453: Using `arc patch` will leave behind a bookmark when answering 'No' in attempt to apply to current state in Mercurial repository from Backlog to arc patch on the Arcanist board.
Apr 10 2017, 10:14 PM · Arcanist, Mercurial, Bug Report
epriestley moved T12501: `arc patch` blows up when the revision's parent has already landed from Backlog to arc patch on the Arcanist board.
Apr 10 2017, 10:14 PM · Arcanist, Restricted Project, Bug Report
epriestley added a revision to T12503: Curtain sections may overflow boundaries in the UI: Restricted Differential Revision.
Apr 10 2017, 10:09 PM · PHUI
epriestley closed T12504: Files "Temporary" badge is white-on-grey as Resolved by committing Restricted Diffusion Commit.
Apr 10 2017, 10:01 PM · Files, PHUI