Page MenuHomePhabricator
Feed Advanced Search

Dec 29 2016

chad added a comment to T12050: Ask a question: Only Herald-compliant file paths are shown in Mail or Diffusion .

As I mentioned over email, you'll have to update Phabricator before asking for help. That version looks at least 18-24 months old and there have been significant changes.

Dec 29 2016, 3:22 AM · Diffusion, Feature Request
ivan.wang added a comment to T12050: Ask a question: Only Herald-compliant file paths are shown in Mail or Diffusion .

thanks

Dec 29 2016, 3:22 AM · Diffusion, Feature Request
chad added a comment to T12050: Ask a question: Only Herald-compliant file paths are shown in Mail or Diffusion .

Please read Support Resources for where we take questions about Phabricator. This doesn't appear to be a feature request.

Dec 29 2016, 3:20 AM · Diffusion, Feature Request
chad closed T12050: Ask a question: Only Herald-compliant file paths are shown in Mail or Diffusion as Invalid.
Dec 29 2016, 3:19 AM · Diffusion, Feature Request
ivan.wang created T12050: Ask a question: Only Herald-compliant file paths are shown in Mail or Diffusion .
Dec 29 2016, 3:11 AM · Diffusion, Feature Request

Dec 22 2016

epriestley edited projects for T12033: Large diffs can still repeatedly fail to insert, added: Bug Report, Differential, Diffusion, Mail; removed Bug Report (Needs Information).
Dec 22 2016, 2:01 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report

Dec 21 2016

epriestley added a subtask for T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion: T12033: Large diffs can still repeatedly fail to insert.
Dec 21 2016, 10:03 PM · Diffusion (v3), Differential, Mail
mpickering added a project to T10093: When builds fail because the staging area was not pushed, make the cause clear: Haskell.org.
Dec 21 2016, 11:17 AM · Haskell.org, Restricted Project, Harbormaster (v3), Diffusion, Feature Request

Dec 20 2016

epriestley closed T12035: Diffusion URI without trailing slash redirects to login page as Resolved by committing Restricted Diffusion Commit.
Dec 20 2016, 3:48 PM · Diffusion, Bug Report
epriestley added a comment to T12035: Diffusion URI without trailing slash redirects to login page.

Thanks, I think D17097 should fix this. It isn't intended, and is just a curious artifact of some other behaviors.

Dec 20 2016, 1:54 PM · Diffusion, Bug Report
epriestley claimed T12035: Diffusion URI without trailing slash redirects to login page.
Dec 20 2016, 1:54 PM · Diffusion, Bug Report

Dec 16 2016

chad added a comment to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs.

cat is slow to appear

Dec 16 2016, 7:27 PM · Customer Impact, Diffusion, Bug Report
epriestley added a comment to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs.

I see cat :)

Dec 16 2016, 7:22 PM · Customer Impact, Diffusion, Bug Report
chad added a comment to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs.

ok now cat is in feed

Dec 16 2016, 7:22 PM · Customer Impact, Diffusion, Bug Report
chad added a comment to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs.

hmm, cat no show in feed

Dec 16 2016, 7:07 PM · Customer Impact, Diffusion, Bug Report
chad added a comment to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs.

frowncat

Dec 16 2016, 7:07 PM · Customer Impact, Diffusion, Bug Report
avivey added a comment to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs.

It's doing it again now...

Dec 16 2016, 6:35 PM · Customer Impact, Diffusion, Bug Report
epriestley updated the task description for T12010: Untangle the Gordian Knot of iterating on Differential/Diffusion/Arcanist.
Dec 16 2016, 6:20 PM · Diffusion (v3), Arcanist, Differential

Dec 14 2016

epriestley updated the task description for T12010: Untangle the Gordian Knot of iterating on Differential/Diffusion/Arcanist.
Dec 14 2016, 3:16 PM · Diffusion (v3), Arcanist, Differential

Dec 13 2016

rfreebern added a comment to T12012: Diffusion doesn't handle non-bare hosted git repos.

Okay, thanks!

Dec 13 2016, 7:39 PM · Git, Diffusion, Bug Report
epriestley closed T12012: Diffusion doesn't handle non-bare hosted git repos as Invalid.

Oh, I think the issue is this:

Dec 13 2016, 7:38 PM · Git, Diffusion, Bug Report
epriestley added a comment to T12012: Diffusion doesn't handle non-bare hosted git repos.

I also can't reproduce this:

Dec 13 2016, 7:33 PM · Git, Diffusion, Bug Report
rfreebern added a comment to T12012: Diffusion doesn't handle non-bare hosted git repos.

It's fine to consider it not a bug. Mainly I wanted to provide the info that it doesn't work for documentation purposes, in case anyone else runs into the same situation in the future. (We ran into this by trying to transition from a very old Phabricator installation to a new one with hosted repos, but with a legacy deployment setup that needs a non-bare repo copy, and didn't realize that Phabricator didn't fully support hosted non-bare repos.)

Dec 13 2016, 7:29 PM · Git, Diffusion, Bug Report
epriestley added a comment to T12012: Diffusion doesn't handle non-bare hosted git repos.

Why do you consider this to be a bug, then?

Dec 13 2016, 7:23 PM · Git, Diffusion, Bug Report
rfreebern added a comment to T12012: Diffusion doesn't handle non-bare hosted git repos.

No.

Dec 13 2016, 6:54 PM · Git, Diffusion, Bug Report
epriestley added a comment to T12012: Diffusion doesn't handle non-bare hosted git repos.

Do we tell you to do this in the documentation anywhere?

Dec 13 2016, 6:36 PM · Git, Diffusion, Bug Report
rfreebern created T12012: Diffusion doesn't handle non-bare hosted git repos.
Dec 13 2016, 6:32 PM · Git, Diffusion, Bug Report
epriestley added projects to T12010: Untangle the Gordian Knot of iterating on Differential/Diffusion/Arcanist: Differential, Diffusion, Arcanist.
Dec 13 2016, 5:07 PM · Diffusion (v3), Arcanist, Differential
epriestley added a project to T6522: "Commit's branches contains" condition is not re-evaluated for commits in multiple branches: Diffusion.
Dec 13 2016, 4:40 PM · Diffusion (v3), Restricted Project, Restricted Project, Herald
epriestley moved T11057: Allow installs to manage which cluster service new repositories allocate on from Backlog to Clusters on the Diffusion board.
Dec 13 2016, 4:40 PM · Diffusion, Clusters
epriestley moved T6008: Editing files and contributing changes via web from Backlog to Far Future on the Diffusion board.
Dec 13 2016, 4:37 PM · Restricted Project, Wikimedia, Diffusion, Differential
epriestley moved T10883: Allow repository cluster nodes to be read-only from Backlog to Clusters on the Diffusion board.
Dec 13 2016, 4:35 PM · Restricted Project, Diffusion, Clusters
epriestley moved T10968: File write failure during daemon operations caused daemons to populate a few too many diffs from Backlog to v3 (Infrastructure) on the Differential board.
Dec 13 2016, 4:21 PM · Files, Differential, Diffusion, Daemons
epriestley moved T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion from Backlog to Future Work on the Differential board.
Dec 13 2016, 4:13 PM · Diffusion (v3), Differential, Mail

Dec 12 2016

epriestley closed T2683: Improve the performance of Diffusion browse views as Resolved.

This is a billion years old now -- see, e.g., T11954 for more modern work.

Dec 12 2016, 9:21 PM · Diffusion
epriestley closed T2542: Provide a link from revisions that are blamees to their blamers as Resolved.

"Blame Revision" was a freeform text field at Facebook (from before DiffCamp, even) where you were ideally supposed to enter the revision or commit that introduced the bug you're fixing, if you were fixing a bug introduced by some known change.

Dec 12 2016, 9:18 PM · Differential, Audit, Diffusion
epriestley closed T2542: Provide a link from revisions that are blamees to their blamers, a subtask of T1751: Consider ways to improve revert handling, as Resolved.
Dec 12 2016, 9:18 PM · Restricted Project, Differential, Diffusion

Dec 8 2016

epriestley added a comment to T10691: Support GitHub-like forking of repositories.

I expect our forking to be much lighter-weight than GitHub's (ideally, I'd like it to work something like git push whatever/branch creates a fork called "whatever"), forking is just a familiar metaphor.

Dec 8 2016, 7:55 PM · Restricted Project, Diffusion, Feature Request
avivey updated subscribers of T10691: Support GitHub-like forking of repositories.

In T11535, @samking says forking "seems like a fairly heavyweight solution," and that users don't want their own GH-style fork as much as they want to create branches "somewhere".

Dec 8 2016, 7:22 PM · Restricted Project, Diffusion, Feature Request
epriestley created T11968: Decide the fate of FutureGraph.
Dec 8 2016, 3:09 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching: Restricted Differential Revision.
Dec 8 2016, 2:44 PM · Performance, Diffusion, Conduit, Infrastructure, Restricted Project, Arcanist
nileshgr added a comment to T11827: ssh-auth hangs on FreeBSD.

I upgraded my installation to

commit ad65d933fa75a2c417ba23f3684f0109de0f6ace
Merge: cfcc3b8 f0bf041
Author: epriestley <git@epriestley.com>
Date:   Sat Dec 3 02:39:57 2016 -0800
Dec 8 2016, 10:13 AM · Diffusion, Bug Report

Dec 6 2016

epriestley added a revision to T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching: Restricted Differential Revision.
Dec 6 2016, 5:37 PM · Performance, Diffusion, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching: Restricted Differential Revision.
Dec 6 2016, 2:15 PM · Performance, Diffusion, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching: Restricted Differential Revision.
Dec 6 2016, 1:12 PM · Performance, Diffusion, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching: Restricted Differential Revision.
Dec 6 2016, 1:10 PM · Performance, Diffusion, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching: Restricted Differential Revision.
Dec 6 2016, 12:35 PM · Performance, Diffusion, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching: Restricted Differential Revision.
Dec 6 2016, 12:19 PM · Performance, Diffusion, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching: Restricted Differential Revision.
Dec 6 2016, 12:15 PM · Performance, Diffusion, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching: Restricted Differential Revision.
Dec 6 2016, 12:13 PM · Performance, Diffusion, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching: Restricted Differential Revision.
Dec 6 2016, 12:08 PM · Performance, Diffusion, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching: Restricted Differential Revision.
Dec 6 2016, 12:03 PM · Performance, Diffusion, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley created T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching.
Dec 6 2016, 11:25 AM · Performance, Diffusion, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T929: Allow two arbitrary revisions to be compared in Diffusion: Restricted Differential Revision.
Dec 6 2016, 2:21 AM · Diffusion (v3), Restricted Project
epriestley added a revision to T929: Allow two arbitrary revisions to be compared in Diffusion: Restricted Differential Revision.
Dec 6 2016, 1:42 AM · Diffusion (v3), Restricted Project

Dec 2 2016

neilfitz added a comment to T11938: Running `git clone` against a Mercurial repository does not produce an error message with explicit guidance.

Damn, that was fast! This should be a perfect solution - thank you for your help.

Dec 2 2016, 7:02 PM · Diffusion, Feature Request
epriestley renamed T11938: Running `git clone` against a Mercurial repository does not produce an error message with explicit guidance from Type of repository visible in Diffusion repository page to Running `git clone` against a Mercurial repository does not produce an error message with explicit guidance.
Dec 2 2016, 3:30 PM · Diffusion, Feature Request
fooishbar added a comment to T11936: Editing Diffusion URIs does not update URI index.

@epriestley Thanks, that's fixed it! I'd not looked index engines at all before, so wasn't sure if I was just missing something stupid on that side.

Dec 2 2016, 9:01 AM · Diffusion, Bug Report

Dec 1 2016

epriestley closed T11936: Editing Diffusion URIs does not update URI index as Resolved by committing Restricted Diffusion Commit.
Dec 1 2016, 10:29 PM · Diffusion, Bug Report
epriestley added a comment to T11936: Editing Diffusion URIs does not update URI index.

I'm pretty sure this this was just a straightforward fix that escaped detection for this long because any other repository edit would rebuild the index. D16972 rebuilds the index on any repository URI edit. Let us know if you're seeing issues after that. Thanks for the report!

Dec 1 2016, 10:29 PM · Diffusion, Bug Report
epriestley added a revision to T11936: Editing Diffusion URIs does not update URI index: Restricted Differential Revision.
Dec 1 2016, 10:27 PM · Diffusion, Bug Report
epriestley added a comment to T11936: Editing Diffusion URIs does not update URI index.

Does making any other edit to the repository (e.g., changing the description) correct the issue?

Dec 1 2016, 9:57 PM · Diffusion, Bug Report
fooishbar added a comment to T11936: Editing Diffusion URIs does not update URI index.

OK, this is interesting: having tried reproducing it on a test Phacility instance, it works as expected there. Perhaps one difference is that my local installations don't have Diffusion serving repositories itself over, e.g., SSH? These repositories do not have any URIs other than a remote Git URI which Diffusion is observing.

Dec 1 2016, 8:30 PM · Diffusion, Bug Report
fooishbar created T11936: Editing Diffusion URIs does not update URI index.
Dec 1 2016, 8:14 PM · Diffusion, Bug Report

Nov 22 2016

cspeckmim added a comment to T11165: Changing a callsign throws a 404.

Heh, just ran into this today

Nov 22 2016, 2:02 AM · Diffusion (v3), Bug Report

Nov 16 2016

epriestley added a comment to T7789: Support Git Large File Storage.

No, there's no specific support for LFS mirroring yet.

Nov 16 2016, 1:13 PM · Customer Impact, Restricted Project, Files, Diffusion
Unknown Object (User) added a comment to T7789: Support Git Large File Storage.

This doesn't add any compatibility with mirroring, does it?

Nov 16 2016, 10:24 AM · Customer Impact, Restricted Project, Files, Diffusion

Nov 15 2016

djeauh added a comment to T11866: PhabricatorRepository->generateURI() has bad call to getPathURI() with missing argument.

It works, thank you!

Nov 15 2016, 5:41 PM · Diffusion, Bug Report
epriestley closed T11866: PhabricatorRepository->generateURI() has bad call to getPathURI() with missing argument as Resolved by committing Restricted Diffusion Commit.
Nov 15 2016, 3:15 PM · Diffusion, Bug Report
epriestley renamed T11866: PhabricatorRepository->generateURI() has bad call to getPathURI() with missing argument from Unhandled exception in Diffusion while trying to audit a commit to PhabricatorRepository->generateURI() has bad call to getPathURI() with missing argument.
Nov 15 2016, 2:54 PM · Diffusion, Bug Report
epriestley added a revision to T11866: PhabricatorRepository->generateURI() has bad call to getPathURI() with missing argument: Restricted Differential Revision.
Nov 15 2016, 2:53 PM · Diffusion, Bug Report
chr86 added a comment to T11866: PhabricatorRepository->generateURI() has bad call to getPathURI() with missing argument.

We have the same issue after the last update and we usually update once a week. I can confirm that the issue happens with any commit to a SVN repository that you want to view via Audit. Git commits display fine.
Might this be related to the change "Old", "New" and "Diff" tabs in the web UI from your latest changelog?

Nov 15 2016, 1:53 PM · Diffusion, Bug Report
djeauh updated the task description for T11866: PhabricatorRepository->generateURI() has bad call to getPathURI() with missing argument.
Nov 15 2016, 8:57 AM · Diffusion, Bug Report
djeauh updated the task description for T11866: PhabricatorRepository->generateURI() has bad call to getPathURI() with missing argument.
Nov 15 2016, 8:56 AM · Diffusion, Bug Report
djeauh updated the task description for T11866: PhabricatorRepository->generateURI() has bad call to getPathURI() with missing argument.
Nov 15 2016, 8:55 AM · Diffusion, Bug Report
djeauh created T11866: PhabricatorRepository->generateURI() has bad call to getPathURI() with missing argument.
Nov 15 2016, 8:53 AM · Diffusion, Bug Report

Nov 14 2016

• willson556 added a comment to T11835: Diffs/Patches should optionally not be generated for generated files until the item is expanded..

To answer @avivey's question more directly, it takes a long time for the yellow Loading... bars to expand to the diff for files I'm interested in because the server is spending all it's CPU time generating diffs of generated files that appear first on the page.

Nov 14 2016, 6:46 PM · Diffusion, Feature Request
• willson556 added a comment to T11835: Diffs/Patches should optionally not be generated for generated files until the item is expanded..

It's true that they're loaded in parallel using AJAX but there are enough generated files that it's tying up the server's CPU. And the generated files seem to end up first in the queue.

Nov 14 2016, 6:41 PM · Diffusion, Feature Request
epriestley removed a subtask for T9713: In Diffusion, show commit messages as parsed fields by default with an option to view them raw: T7443: Include full link to Maniphest tasks in commit messages.
Nov 14 2016, 6:02 PM · Diffusion (v3)
epriestley added a subtask for T9713: In Diffusion, show commit messages as parsed fields by default with an option to view them raw: T7443: Include full link to Maniphest tasks in commit messages.
Nov 14 2016, 6:01 PM · Diffusion (v3)
20after4 added a comment to T11087: Make permissions more granular in repositorys.

FWIW: I believe @paladox means well, he's just young/inexperienced and overly enthusiastic. The decision to ban him is entirely reasonable for upstream though, given the circumstances.

Nov 14 2016, 8:05 AM · Wikimedia, Diffusion, Feature Request

Nov 13 2016

epriestley closed T4245: Make repository URIs slightly prettier, a subtask of T9287: Working with many repositories, as Resolved.
Nov 13 2016, 8:42 PM · Restricted Project, Restricted Project, Diffusion

Nov 10 2016

epriestley removed a project from T7789: Support Git Large File Storage: Prioritized.

The driving install dropped off the grid a while ago, so this is no longer prioritized.

Nov 10 2016, 5:09 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T11835: Diffs/Patches should optionally not be generated for generated files until the item is expanded..

This is sort-of-maybe related to T11482 but I'm also not exactly sure what's step in the process is slow here.

Nov 10 2016, 12:59 AM · Diffusion, Feature Request
avivey added a comment to T11835: Diffs/Patches should optionally not be generated for generated files until the item is expanded..

Which interaction exactly is taking a long time?

Nov 10 2016, 12:44 AM · Diffusion, Feature Request
avivey closed T11792: Remove "No Highlighting" mode from Diffusion as Resolved by committing Restricted Diffusion Commit.
Nov 10 2016, 12:40 AM · Diffusion, Bug Report
avivey added a revision to T11792: Remove "No Highlighting" mode from Diffusion: Restricted Differential Revision.
Nov 10 2016, 12:33 AM · Diffusion, Bug Report

Nov 8 2016

• willson556 added a project to T11835: Diffs/Patches should optionally not be generated for generated files until the item is expanded.: Diffusion.
Nov 8 2016, 9:52 PM · Diffusion, Feature Request
nileshgr added a comment to T11827: ssh-auth hangs on FreeBSD.

I'll have to update my instance first to test your patch, since it seems to be for newer version as you said earlier. I installed this from FreeBSD ports system, have to first convert it to normal git based install.

Nov 8 2016, 12:57 PM · Diffusion, Bug Report

Nov 7 2016

epriestley triaged T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs as Wishlist priority.

This self-healed (probably after another commit was pushed) so I don't expect to look at it for a while unless it happens again.

Nov 7 2016, 11:45 PM · Customer Impact, Diffusion, Bug Report
epriestley added a comment to T11827: ssh-auth hangs on FreeBSD.

(mindrot.org is currently inaccessible for me so I wasn't able to read the details you linked, although I imagine they aren't too relevant to how we handle things.)

Nov 7 2016, 4:13 PM · Diffusion, Bug Report
epriestley added a comment to T11827: ssh-auth hangs on FreeBSD.

I'd prefer not to produce any output until we've generated everything, so we don't end up in a situation where we output half of the file and then fail if we can help it. Additionally, this script changed in D16744, a few weeks ahead of your version.

Nov 7 2016, 3:01 PM · Diffusion, Bug Report
nileshgr created T11827: ssh-auth hangs on FreeBSD.
Nov 7 2016, 8:31 AM · Diffusion, Bug Report

Nov 6 2016

epriestley added a comment to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs.
mysql> select * from repository_refcursor where repositoryPHID = 'PHID-REPO-9a38b7db1b795ae3e348'\G
*************************** 1. row ***************************
              id: 16859
            phid: PHID-RREF-2v6ff7fmx4p62ddr3x7w
  repositoryPHID: PHID-REPO-9a38b7db1b795ae3e348
         refType: branch
     refNameHash: fCKLrzDyaVYn
      refNameRaw: master
 refNameEncoding: utf8
commitIdentifier: e1566bef63c273404d3e8a3e8b4b4e23e387d772
        isClosed: 0
*************************** 2. row ***************************
              id: 16860
            phid: PHID-RREF-ev7y6ezkb4iqbbhpm3jp
  repositoryPHID: PHID-REPO-9a38b7db1b795ae3e348
         refType: branch
     refNameHash: fCKLrzDyaVYn
      refNameRaw: master
 refNameEncoding: utf8
commitIdentifier: e1566bef63c273404d3e8a3e8b4b4e23e387d772
        isClosed: 0
*************************** 3. row ***************************
              id: 16854
            phid: PHID-RREF-bu25xmjsnzlb5lvdux2g
  repositoryPHID: PHID-REPO-9a38b7db1b795ae3e348
         refType: branch
     refNameHash: fWcLw_rNrNJF
      refNameRaw: stable
 refNameEncoding: utf8
commitIdentifier: 111c63955155046bbd57c3836c78d460ebe13dfb
        isClosed: 0
3 rows in set (0.00 sec)
Nov 6 2016, 3:16 PM · Customer Impact, Diffusion, Bug Report

Nov 5 2016

avivey created T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs.
Nov 5 2016, 7:09 PM · Customer Impact, Diffusion, Bug Report

Nov 4 2016

cspeckmim added a comment to T9548: Support Mercurial's bundle2 wire protocol.

As a user of both Phabricator and Mercurial, opening up HTTP isn't an option we want to consider and would instead stick to having the repository hosted elsewhere.

Nov 4 2016, 3:50 AM · Diffusion, Mercurial
epriestley added a comment to T9548: Support Mercurial's bundle2 wire protocol.

Today, we already decode the SSH wire protocol and figure out what's going on inside it up to the bundle2 stuff -- here's the, uh, "protocol spec":

Nov 4 2016, 2:59 AM · Diffusion, Mercurial
indygreg added a comment to T9548: Support Mercurial's bundle2 wire protocol.

It should be possible to determine whether an operation is read or write by the command name: a command either performs writes or it doesn't. The only write commands you should see are unbundle and pushkey. While it might be possible for batch to contain pushkey operations, I don't think that's done today (but I'd have to audit the code to be sure). One thing you should be able to rely on is the HTTP method: GET requests should never perform any significant writes (although some cache files may be written to as a result of resolving data, but that shouldn't be important). It should be perfectly valid to treat GET and POST differently. Although if you route requests to different endpoints within the same TCP/HTTP stream, inconsistent state of a read-only mirror from a master could lead to race conditions (e.g. push fails because a mirror is out of sync). If you route by HTTP request method, you should not need to know anything about the Mercurial wire protocol.

Nov 4 2016, 2:23 AM · Diffusion, Mercurial

Nov 2 2016

epriestley renamed T11792: Remove "No Highlighting" mode from Diffusion from line-linking fails silently when user's set to "no highlighting" to Remove "No Highlighting" mode from Diffusion.
Nov 2 2016, 9:04 PM · Diffusion, Bug Report

Oct 31 2016

cspeckmim added a comment to T9548: Support Mercurial's bundle2 wire protocol.

@indygreg - Thanks for reaching out and discussing a way forward. I am not on the phabricator team but I do have an interest in its integration capabilities with mercurial. At best I might be able to summarize my understanding of some of phabricator's needs based on the history of this task, but I do not feel I could properly represent them on mercurial's mailing-list or wiki. For hosting repositories I believe this task would require needing to know if the mercurial operation is read or write -- the two primary reasons being read/write access control and cluster picking.

Oct 31 2016, 2:20 AM · Diffusion, Mercurial