Page MenuHomePhabricator

Remove "No Highlighting" mode from Diffusion
Closed, ResolvedPublic

Description

Users send each other links such as https://secure.phabricator.com/diffusion/P/browse/master/README.md$22, expecting to direct the precipitant to line 22 in the file; If the recipient has somehow disabled source highlighting on the file, the link just shows the file, confusing both users.

I'm pretty sure the user disabled this either by mistake, or in order to copy something (ie, they assume that "copy" will not work correctly out of a formatted page).

I don't think we can realistically highlight part of the plain-text view, but maybe there's some way we can reduce the confusion here?

Some random ideas:

  • if the link has $22, turn on highlighting?
  • revert the settings back to highlight + blame after a week / browser session?
  • disable plain-text mode for diffusion?

Event Timeline

I think the textarea predates using JS magic to make "copy" work. I think we could probably remove the "disable highlighting" mode now; I can't really imagine any legitimate reason to intentionally disable it in modern code, except maybe not realizing that "copy" will work correctly via magic.

I guess "select all, copy" is harder without the textarea, maybe, but that seems marginal.

epriestley renamed this task from line-linking fails silently when user's set to "no highlighting" to Remove "No Highlighting" mode from Diffusion.Nov 2 2016, 9:04 PM