Page MenuHomePhabricator
Feed Advanced Search

Jun 17 2016

epriestley added a comment to T11173: User unable to create repository if not in the "Default Edit Policy" of Diffusion Application.

There are two completely different flows. At HEAD, the flow is entirely different and uses none of the same code.

Jun 17 2016, 8:57 PM · Diffusion (v3), Restricted Project, Policy, Bug Report
cspeckmim added a comment to T11173: User unable to create repository if not in the "Default Edit Policy" of Diffusion Application.

there's no way to change "Edit Policy" from the initial form page

Is that not the same thing as "Editable By" during repository creation?

Screen Shot 2016-06-17 at 4.51.04 PM.png (331×1 px, 53 KB)

Jun 17 2016, 8:55 PM · Diffusion (v3), Restricted Project, Policy, Bug Report
epriestley added a comment to T11173: User unable to create repository if not in the "Default Edit Policy" of Diffusion Application.

This would work now, except that there's no way to change "Edit Policy" from the initial form page.

Jun 17 2016, 8:49 PM · Diffusion (v3), Restricted Project, Policy, Bug Report
chad updated subscribers of T11173: User unable to create repository if not in the "Default Edit Policy" of Diffusion Application.

Nevermind I am wrong. Anyways, @epriestley can explain policies better. I think this is correct on our side.

Jun 17 2016, 8:46 PM · Diffusion (v3), Restricted Project, Policy, Bug Report
chad added a comment to T11173: User unable to create repository if not in the "Default Edit Policy" of Diffusion Application.

If I set "Can Edit" to Noone and "Can Create" to Admins, I can create repositories. But this is current Phabricator.

Jun 17 2016, 8:42 PM · Diffusion (v3), Restricted Project, Policy, Bug Report
cspeckmim added a comment to T11173: User unable to create repository if not in the "Default Edit Policy" of Diffusion Application.

Yea I'm really sorry about March 4th. I'll probably look at upgrading in the following weeks. I slowed down updating because of the new UI layout to differential revisions which I thought would upset some people, needed to wait for warmer weather, etc. :x)

Jun 17 2016, 8:34 PM · Diffusion (v3), Restricted Project, Policy, Bug Report
chad added a comment to T11173: User unable to create repository if not in the "Default Edit Policy" of Diffusion Application.

Anyways... this sounds correct. Why should a user be able to create something they can't edit?

Jun 17 2016, 8:31 PM · Diffusion (v3), Restricted Project, Policy, Bug Report
chad added a comment to T11173: User unable to create repository if not in the "Default Edit Policy" of Diffusion Application.

March 4th?

Jun 17 2016, 8:30 PM · Diffusion (v3), Restricted Project, Policy, Bug Report
cspeckmim created T11173: User unable to create repository if not in the "Default Edit Policy" of Diffusion Application.
Jun 17 2016, 8:23 PM · Diffusion (v3), Restricted Project, Policy, Bug Report
chad added a comment to T10433: Repo in Diffusion has no padding after Branches box if footer is not configured.

I can't reproduce this on your linked install.

Jun 17 2016, 7:53 PM · Diffusion, Bug Report
chad added a project to T11171: When clicking an image in the comment edit modal, the image modal gets under the edit modal: Differential.
Jun 17 2016, 7:17 PM · Lightbox, Bug Report
scode added a comment to T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI.

@eadler Did you have enough insight/recollection as to whether all our reported cases were due to users editing in the web UI?

Jun 17 2016, 4:51 PM · Prioritized, Restricted Project, Arcanist, Bug Report
epriestley added a comment to T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI.

From a technical point of view I think the ideal solution to this is to make the commit message format unambiguously parseable, but I'm not immediately sure how to do that without making other things worse. It's valuable for messages to be human-readable and human-editable, and I think we'd be worse overall if we tried to escape or encode messages in Git itself (or represent them as XML or whatever).

Jun 17 2016, 4:05 PM · Prioritized, Restricted Project, Arcanist, Bug Report
eadler added a comment to T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI.

I'm not sure I have a good answer to that. :/

Jun 17 2016, 3:48 PM · Prioritized, Restricted Project, Arcanist, Bug Report
epriestley added a comment to T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI.

What's the behavior you'd expect or prefer when a user writes this commit message?

Jun 17 2016, 3:15 PM · Prioritized, Restricted Project, Arcanist, Bug Report
epriestley added a comment to T11172: Unable to configure Arcanist as per the quick start tutorial.

I can't reproduce this. Here's what I did.

Jun 17 2016, 3:01 PM · Documentation, Bug Report
chad added a comment to T11162: Unable to Edit Projects as Administrator, Showing Restricted.

We require reproduction steps for bug reports. I would also use an up to date version of Phabricator before filing the bug report (it's required that you update before filing a bug).

Jun 17 2016, 2:31 PM · Projects, Bug Report (Needs Information)
grooveek created T11172: Unable to configure Arcanist as per the quick start tutorial.
Jun 17 2016, 2:22 PM · Documentation, Bug Report
chad added a comment to T11160: View Wiki Docs that only pertain to a certain group.

Create a custom query inside Phriction, save it, then go to Dashboards and make a Panel with that query.

Jun 17 2016, 2:16 PM · Dashboards, Phriction, Bug Report
chad added a comment to T11171: When clicking an image in the comment edit modal, the image modal gets under the edit modal.

looks like an awesome feature to me

Jun 17 2016, 2:14 PM · Lightbox, Bug Report
• damio created T11171: When clicking an image in the comment edit modal, the image modal gets under the edit modal.
Jun 17 2016, 2:08 PM · Lightbox, Bug Report
• rmaspoch added a comment to T11160: View Wiki Docs that only pertain to a certain group.

Thank you we basically created two projects to group the members into those two projects and i removed myself and only stayed in one and that seemed to kind of work. I see only the files i expected but also some deleted files history that is greyed out. It would be nice to have an easy place to put custom queries to be used for each of the apps but I love Phabricator so keep up the good work thanks.

Jun 17 2016, 1:42 PM · Dashboards, Phriction, Bug Report
epriestley closed T11169: User without "can edit" permission, can change task via comment action as Invalid.

This is expected. You do not need edit permission to comment on a task or take other actions available in the action dropdown.

Jun 17 2016, 1:37 PM · Policy, Bug Report
rphl created T11169: User without "can edit" permission, can change task via comment action.
Jun 17 2016, 1:27 PM · Policy, Bug Report
avivey edited projects for T11165: Changing a callsign throws a 404, added: Diffusion; removed Differential.
Jun 17 2016, 3:40 AM · Diffusion (v3), Bug Report
chad added a comment to T11164: Badges: Unwanted entry at the history.

We should get this punted out of prototype status, don't think there is a lot to cover before that. See T11167 if you find additional items.

Jun 17 2016, 2:06 AM · Badges, Bug Report
chad added a comment to T11164: Badges: Unwanted entry at the history.

Isn't Badges a Prototype?

Jun 17 2016, 1:34 AM · Badges, Bug Report
Luke081515.2 created T11165: Changing a callsign throws a 404.
Jun 17 2016, 12:19 AM · Diffusion (v3), Bug Report
Luke081515.2 created T11164: Badges: Unwanted entry at the history.
Jun 17 2016, 12:04 AM · Badges, Bug Report

Jun 16 2016

• medemi68 created T11162: Unable to Edit Projects as Administrator, Showing Restricted.
Jun 16 2016, 10:10 PM · Projects, Bug Report (Needs Information)
avivey renamed T11152: Some workflows of arc are broken on Windows from EXCEPTION: The current working directory is not part of a working copy for a supported version control system to Some workflows of arc are broken on Windows.
Jun 16 2016, 8:20 PM · Arcanist, Windows, Bug Report
avivey added a comment to T11152: Some workflows of arc are broken on Windows.

We're basically having lots of problems with Windows; There are a few reports about arc version just not working on Windows (I'm a little surprised @hach-que doesn't run into this; Can you maybe do a quick phriction page about your Windows setup, as in "this setup works, do this"?).

Jun 16 2016, 8:17 PM · Arcanist, Windows, Bug Report
chad added a comment to T11160: View Wiki Docs that only pertain to a certain group.

Your best workaround for now is multiple text panels for each organization.

Jun 16 2016, 6:41 PM · Dashboards, Phriction, Bug Report
chad added a comment to T11160: View Wiki Docs that only pertain to a certain group.

T11161 is the follow up for Dashboards

Jun 16 2016, 6:40 PM · Dashboards, Phriction, Bug Report
epriestley added a project to T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI: Prioritized.
Jun 16 2016, 6:32 PM · Prioritized, Restricted Project, Arcanist, Bug Report
chad added a comment to T11160: View Wiki Docs that only pertain to a certain group.

I'll create a separate task to re-think Panel creation UI.

Jun 16 2016, 6:31 PM · Dashboards, Phriction, Bug Report
chad merged task T11160: View Wiki Docs that only pertain to a certain group into T9622: Allow Phriction pages to have Project tags.
Jun 16 2016, 6:31 PM · Dashboards, Phriction, Bug Report
eadler moved T11145: Dialog submit buttons don't disable on click from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 16 2016, 6:28 PM · Restricted Project, PHUI, Bug Report
eadler moved T11154: Build results don't always get conferred to their buildable from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 16 2016, 6:28 PM · Restricted Project, Harbormaster, Bug Report
eadler moved T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 16 2016, 6:28 PM · Prioritized, Restricted Project, Arcanist, Bug Report
chad added a comment to T11160: View Wiki Docs that only pertain to a certain group.

You're not creating a custom query, at least in that screenshot. The query is "All Documents", which is what you're getting.

Jun 16 2016, 6:27 PM · Dashboards, Phriction, Bug Report
eadler added a project to T11154: Build results don't always get conferred to their buildable: Restricted Project.
Jun 16 2016, 6:26 PM · Restricted Project, Harbormaster, Bug Report
eadler added a project to T11145: Dialog submit buttons don't disable on click: Restricted Project.
Jun 16 2016, 6:26 PM · Restricted Project, PHUI, Bug Report
epriestley merged task T10742: PhabricatorRepositoryCommitParserWorker fails on deleted commits into T9028: Phabricator handles commits which are published and later deleted poorly.
Jun 16 2016, 6:08 PM · Diffusion, Bug Report
epriestley added a comment to T10742: PhabricatorRepositoryCommitParserWorker fails on deleted commits.

I'm going to merge this into T9028. Specifically, daemons should be able to permanently fail operations on unreachable commits after D16131. That task discusses deleted/unreachable commits more broadly.

Jun 16 2016, 6:08 PM · Diffusion, Bug Report
epriestley closed T10933: You Shall Not Pass: Unknown Object (Repository) as Invalid.

We can't reproduce this, so we can't move forward. Feel free to open a new issue if you are able to provide reproduction steps.

Jun 16 2016, 6:05 PM · Diffusion, Bug Report
epriestley closed T11137: Unable to update Git repositories with latest stable as Resolved.

This fix appears to be holding.

Jun 16 2016, 6:02 PM · Diffusion, Bug Report
• rmaspoch created T11160: View Wiki Docs that only pertain to a certain group.
Jun 16 2016, 5:53 PM · Dashboards, Phriction, Bug Report
angel added a comment to T11156: Exception on auth configuration.

Pulled and working! Thanks a lot!

Jun 16 2016, 1:12 PM · Auth, Bug Report
epriestley added a comment to T11156: Exception on auth configuration.

This should be fixed at HEAD of master. Let us know if you're still seeing issues after updating.

Jun 16 2016, 1:06 PM · Auth, Bug Report
epriestley closed T11156: Exception on auth configuration as Resolved by committing Restricted Diffusion Commit.
Jun 16 2016, 1:04 PM · Auth, Bug Report
epriestley added a comment to T11156: Exception on auth configuration.

Thanks for the report! This should be fixed once D16128 is reviewed, likely later today.

Jun 16 2016, 10:47 AM · Auth, Bug Report
epriestley added a revision to T11156: Exception on auth configuration: Restricted Differential Revision.
Jun 16 2016, 10:46 AM · Auth, Bug Report
epriestley claimed T11156: Exception on auth configuration.
Jun 16 2016, 10:46 AM · Auth, Bug Report
angel added a project to T11156: Exception on auth configuration: Auth.
Jun 16 2016, 8:44 AM · Auth, Bug Report
angel created T11156: Exception on auth configuration.
Jun 16 2016, 8:24 AM · Auth, Bug Report
flashydave added a comment to T11152: Some workflows of arc are broken on Windows.

We have a large user base using various install locations on their PC's. The issue has come about following a recent upgrade from a 2015 version with more than one person affected.
If you look at the code I cant see why you would need write access - it is just processing path strings.
Anyway I have moved the install to your suggested directory but with no change to the fault symptom.

Jun 16 2016, 7:41 AM · Arcanist, Windows, Bug Report
chad added a project to T11154: Build results don't always get conferred to their buildable: Harbormaster.
Jun 16 2016, 3:02 AM · Restricted Project, Harbormaster, Bug Report
hach-que added a comment to T11152: Some workflows of arc are broken on Windows.

As someone who regularly uses Arcanist on Windows, I can't say I've seen this issue. You should try placing Arcanist in a writable directory, like C:\Tools\Arcanist. Installing it into "Program Files" is probably not ideal, as that's not a writable location.

Jun 16 2016, 2:53 AM · Arcanist, Windows, Bug Report
hach-que added a comment to T11154: Build results don't always get conferred to their buildable.

Yeah, this is a known bug with aborting builds. It doesn't actually functionally impact anything (you can still restart the builds later, etc.)

Jun 16 2016, 2:45 AM · Restricted Project, Harbormaster, Bug Report
yelirekim created T11154: Build results don't always get conferred to their buildable.
Jun 16 2016, 1:56 AM · Restricted Project, Harbormaster, Bug Report

Jun 15 2016

chad updated the task description for T11152: Some workflows of arc are broken on Windows.
Jun 15 2016, 8:53 PM · Arcanist, Windows, Bug Report
chad renamed T11152: Some workflows of arc are broken on Windows from Executing "arc version" on Windows results in EXCEPTION: (Exception) The current working directory is not part of a working copy for a supported version control system.... to EXCEPTION: The current working directory is not part of a working copy for a supported version control system.
Jun 15 2016, 8:52 PM · Arcanist, Windows, Bug Report
flashydave created T11152: Some workflows of arc are broken on Windows.
Jun 15 2016, 8:49 PM · Arcanist, Windows, Bug Report
aristedes added a comment to T11151: Commit emails have broken formatting.

I know you have focussed on the missing background, but I'm not overly fussed about that. But I am surprised that the commit subject shown twice in a row, once truncated inside a table and once not, is anything else but a bug.

Jun 15 2016, 4:05 PM · Diffusion, Audit, Bug Report
epriestley closed T11151: Commit emails have broken formatting as Invalid.
<pre class="remarkup-code" style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">We use cayenne query to get these courses directly for database. It allows exclude any influence of the cayenne snapshot implmentation on these relations</pre>
Jun 15 2016, 3:50 PM · Diffusion, Audit, Bug Report
aristedes added a comment to T11151: Commit emails have broken formatting.

I know I didn't retrieve all the info you asked for, so let me know if you want to see anything else or want me to decode the base64 email body.

Jun 15 2016, 3:35 PM · Diffusion, Audit, Bug Report
aristedes added a comment to T11151: Commit emails have broken formatting.

I've learned some interesting things.

Jun 15 2016, 3:33 PM · Diffusion, Audit, Bug Report
epriestley added a comment to T11151: Commit emails have broken formatting.

Can you provide:

Jun 15 2016, 12:54 PM · Diffusion, Audit, Bug Report
aristedes created T11151: Commit emails have broken formatting.
Jun 15 2016, 11:26 AM · Diffusion, Audit, Bug Report
hach-que added a comment to T11138: mail is not delivered if metamta.placeholder-to-recipient is null.

Local Version Bitnami Phabricator 20160523-0

Jun 15 2016, 7:29 AM · Mail, Bug Report

Jun 14 2016

eadler renamed T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI from arcanist incorrectly parsers fields inside fields to arcanist incorrectly parses fields inside fields.
Jun 14 2016, 10:13 PM · Prioritized, Restricted Project, Arcanist, Bug Report
chad updated the task description for T11142: Side-by-side diff viewer breaks lines on word boundaries and makes diffing difficult in some situations.
Jun 14 2016, 8:42 PM · Restricted Project, Bug Report (Needs Information), Differential
chad added a comment to T11142: Side-by-side diff viewer breaks lines on word boundaries and makes diffing difficult in some situations.

The diff UI just looks off in the video, each line takes up two lines. I don't know what browser / OS that is nor have any diffs here to reproduce it though. Retina Mac / Chrome maybe?

Jun 14 2016, 8:41 PM · Restricted Project, Bug Report (Needs Information), Differential
avivey added a comment to T11142: Side-by-side diff viewer breaks lines on word boundaries and makes diffing difficult in some situations.

Is this the same issue https://slack-files.com/T029GG40X-F1FA40DUJ-cdf3ae1eec (From IRC a couple of days ago)? Extra-long words, like minified javascript, doesn't get broken.

Jun 14 2016, 8:19 PM · Restricted Project, Bug Report (Needs Information), Differential
chad renamed T11145: Dialog submit buttons don't disable on click from Race conditions with form submissions to Dialog submit buttons don't disable on click.
Jun 14 2016, 8:11 PM · Restricted Project, PHUI, Bug Report
chad added a comment to T11149: user settings and global defaults for email do not reflect site config.

I think this is resolved in rPd68b2cc0e4c4, but merging into the feedback/errata task regardless.

Jun 14 2016, 5:20 PM · Bug Report
chad merged task T11149: user settings and global defaults for email do not reflect site config into T11098: Feedback and Errata for Global Settings.
Jun 14 2016, 5:19 PM · Bug Report
chad added a comment to T11149: user settings and global defaults for email do not reflect site config.

Can you try HEAD? or are you on stable?

Jun 14 2016, 5:16 PM · Bug Report
allixsenos added a comment to T11149: user settings and global defaults for email do not reflect site config.

just upgraded to the hashes from https://secure.phabricator.com/w/changelog/2016.24/ before spotting issue, unsure if it was that way before

Jun 14 2016, 5:14 PM · Bug Report
chad added a comment to T11149: user settings and global defaults for email do not reflect site config.

What version of Phabricator are you running?

Jun 14 2016, 5:13 PM · Bug Report
allixsenos closed T11148: option names for Vary Subjects are copypasta from Re-Prefix option as Resolved by committing Restricted Diffusion Commit.
Jun 14 2016, 5:13 PM · Bug Report
allixsenos created T11149: user settings and global defaults for email do not reflect site config.
Jun 14 2016, 5:11 PM · Bug Report
allixsenos added a revision to T11148: option names for Vary Subjects are copypasta from Re-Prefix option: Restricted Differential Revision.
Jun 14 2016, 5:07 PM · Bug Report
allixsenos added a comment to T11148: option names for Vary Subjects are copypasta from Re-Prefix option.

ah it's phutil_symbols...

Jun 14 2016, 5:02 PM · Bug Report
allixsenos added a comment to T11148: option names for Vary Subjects are copypasta from Re-Prefix option.

I have a patch for this but arc lint is taking forever and all of my CPU... :-/

Jun 14 2016, 5:00 PM · Bug Report
allixsenos created T11148: option names for Vary Subjects are copypasta from Re-Prefix option.
Jun 14 2016, 4:58 PM · Bug Report
chad added a project to T11142: Side-by-side diff viewer breaks lines on word boundaries and makes diffing difficult in some situations: Differential.
Jun 14 2016, 2:50 PM · Restricted Project, Bug Report (Needs Information), Differential
chad added a comment to T11145: Dialog submit buttons don't disable on click.

Nice! I was able to duplicate that. Might be all? dialogs.

Jun 14 2016, 5:08 AM · Restricted Project, PHUI, Bug Report
joshuaspence added a comment to T11145: Dialog submit buttons don't disable on click.

Ah I see. So for the "create ticket" workflow, it only seems to happen when creating a ticket from a workboard. In this case, I do not see the button go disabled.

Jun 14 2016, 5:01 AM · Restricted Project, PHUI, Bug Report
joshuaspence added a comment to T11146: Phriction preview 404s.

I was able to reproduce this on a Phacility test instance as well: https://test-ftzenxozitfe.phacility.com/phriction/edit/?slug=/

Jun 14 2016, 4:50 AM · Phriction, Bug Report
joshuaspence created T11146: Phriction preview 404s.
Jun 14 2016, 4:44 AM · Phriction, Bug Report
chad added a comment to T11145: Dialog submit buttons don't disable on click.

Does the submit button not go "disabled" when you click on it? JS should be immediately doing this. I can't not get it to do this on anything I test.

Jun 14 2016, 4:26 AM · Restricted Project, PHUI, Bug Report
chad added a comment to T11145: Dialog submit buttons don't disable on click.

Wouldn't form re-submission be disabled through javascript on the client?

Jun 14 2016, 4:24 AM · Restricted Project, PHUI, Bug Report
joshuaspence added a comment to T11145: Dialog submit buttons don't disable on click.

I am using Chrome on Ubuntu, but I don't think k the browser/OS has much to do with it. I'm guessing that you can't reproduce it because you have more internets than I do. If you can artificially throttle the connection speed then it might be easier to reproduce.

Jun 14 2016, 4:16 AM · Restricted Project, PHUI, Bug Report
chad added a comment to T11145: Dialog submit buttons don't disable on click.

I can't reproduce locally or on Phacility in Chrome/Mac. Is there a specific browser/os I should test?

Jun 14 2016, 4:12 AM · Restricted Project, PHUI, Bug Report
joshuaspence created T11145: Dialog submit buttons don't disable on click.
Jun 14 2016, 3:49 AM · Restricted Project, PHUI, Bug Report
chad updated subscribers of T11142: Side-by-side diff viewer breaks lines on word boundaries and makes diffing difficult in some situations.

I did get the file to download. It think it should have just downloaded on this page though and not sent me to the File page, so I'll follow up on if that's a bug with @epriestley .

Jun 14 2016, 12:57 AM · Restricted Project, Bug Report (Needs Information), Differential
chad added a comment to T11142: Side-by-side diff viewer breaks lines on word boundaries and makes diffing difficult in some situations.

We still need a complete bug report for this. See Contributing Bug Reports.

Jun 14 2016, 12:48 AM · Restricted Project, Bug Report (Needs Information), Differential
markwei added a comment to T11142: Side-by-side diff viewer breaks lines on word boundaries and makes diffing difficult in some situations.

I'll do so as soon as I can.

Jun 14 2016, 12:43 AM · Restricted Project, Bug Report (Needs Information), Differential