mail is not delivered if metamta.placeholder-to-recipient is null
Open, Needs TriagePublic

Description

This is duplicate of now closed T11130 with more information. I thought I gave enough details talking about rule I created and output of the message I saw. Anyway as more information was expected in a new bug, I am adding this one.

I have created an herald rule, screenshot of which is below.

The message tab shows the following, where To is None and Cc is vivekanand (me)

And finally, this is what the status shows. "invalid address: null"

That is all I can see in the mail metadata tab, and mail is not sent, delivery is failed.

Now just to be sure the empty metamta.placeholder-to-recipient is causing the problem, I added an email to it and resent (using ./bin/mail resend) the mail, it works perfectly, the mail is sent.

Just to be sure, this is how the config screen looks when the mail fails to deliver.

And the versions are : -
phabricator 77d543ba44638a2e43e1b6bb7f75db80b4046409 (Sat, May 21)
arcanist 0249f90a9a4aa42da0823673a6ac8c620251d82a (Sat, May 21)
phutil 7ff4bd8dfb0b58686a72821dd0e9e79e0f5cbbb9 (Sat, May 21)
Local Version Bitnami Phabricator 20160523-0

Hope the information given here is enough and helpful. I am ready to add more information if needed.

Thanks,
Vivekanand.

Local Version Bitnami Phabricator 20160523-0

Externally packaged versions of Phabricator are not supported by this upstream. You need to install Phabricator by using the Installation Guide.

epriestley moved this task from Backlog to v3 on the Mail board.Jul 16 2016, 2:02 PM

I am running into this issue too and am on commits:

phabricator d3b7a0f37c975397455d633254e9b4a1246023f9 (Fri, May 26) (branched from 9d37ad3022bfff8a2900b9d728e6abbb6a1e27f0 on origin)
arcanist 21fe07925b07cab0f73ec824fe8ce02f53b24fe0 (Fri, May 19) (branched from 129d51fa0936c9bae48fadf3a3f39e26d69d24da on origin)
phutil d02cc05931b02c684d4c729510090591ca45f951 (Apr 29 2017) (branched from a900d7b63e954e221efe140f0f33d3d701524aae on origin)

I am seeing the following exception in the logs:

[15-Jun-2017 08:06:55 America/Los_Angeles] [2017-06-15 08:06:55] EXCEPTION: (PhutilProxyException) Error while executing Task ID 297129. {>} (phpmailerException) Invalid address: null at [<phabricator>/externals/phpmailer/class.phpmailer.php:462]
[15-Jun-2017 08:06:55 America/Los_Angeles] arcanist(head=stable, ref.stable=21fe07925b07), phabricator(head=stable, ref.stable=d3b7a0f37c97), phutil(head=stable, ref.stable=d02cc05931b0)
[15-Jun-2017 08:06:55 America/Los_Angeles]   #0 <#2> PHPMailer::AddAnAddress(string, string, string) called at [<phabricator>/externals/phpmailer/class.phpmailer.php:408]
[15-Jun-2017 08:06:55 America/Los_Angeles]   #1 <#2> PHPMailer::AddAddress(string) called at [<phabricator>/src/applications/metamta/adapter/PhabricatorMailImplementationPHPMailerAdapter.php:68]
[15-Jun-2017 08:06:55 America/Los_Angeles]   #2 <#2> PhabricatorMailImplementationPHPMailerAdapter::addTos(array) called at [<phabricator>/src/applications/metamta/storage/PhabricatorMetaMTAMail.php:657]
[15-Jun-2017 08:06:55 America/Los_Angeles]   #3 <#2> PhabricatorMetaMTAMail::sendNow() called at [<phabricator>/src/applications/metamta/PhabricatorMetaMTAWorker.php:26]
[15-Jun-2017 08:06:55 America/Los_Angeles]   #4 <#2> PhabricatorMetaMTAWorker::doWork() called at [<phabricator>/src/infrastructure/daemon/workers/PhabricatorWorker.php:123]
[15-Jun-2017 08:06:55 America/Los_Angeles]   #5 <#2> PhabricatorWorker::executeTask() called at [<phabricator>/src/infrastructure/daemon/workers/storage/PhabricatorWorkerActiveTask.php:171]
[15-Jun-2017 08:06:55 America/Los_Angeles]   #6 <#2> PhabricatorWorkerActiveTask::executeTask() called at [<phabricator>/src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemon.php:22]
[15-Jun-2017 08:06:55 America/Los_Angeles]   #7 PhabricatorTaskmasterDaemon::run() called at [<phutil>/src/daemon/PhutilDaemon.php:219]
[15-Jun-2017 08:06:55 America/Los_Angeles]   #8 PhutilDaemon::execute() called at [<phutil>/scripts/daemon/exec/exec_daemon.php:131]

Just adding this info to the ticket in case it is of help.

avivey added a subscriber: avivey.Jun 15 2017, 8:57 PM

I'm not sure I understand something:

What is the problem? What is wrong/not working?

Also, @aravindh: Your install is in an inconsistent state, you should upgrade all 3 repos at the same time - see Upgrading Phabricator.

What is the problem? What is wrong/not working?

If I add a subscriber to a differential revision, the email doesn't get sent to subscriber email. If I check the mail list and do mail show-outbound, I see the following:

PROPERTIES
ID: 42303
Status: fail
Related PHID: PHID-CMIT-kdjcwzte6ip7ivdj2oi4
Message: Invalid address: null

This is also reflected in the /mail/ page if I look at the info for that message id.

Your install is in an inconsistent state, you should upgrade all 3 repos at the same time

Thanks for pointing that out. I did a git pull in all three repos AFAIK. But I can try again. to see if they sync up. However I have been having this issue for a long time and have done multiple upgrades in that time.

avivey renamed this task from metamta.placeholder-to-recipient doesn't upgrade CCs to To as it says so. [With more info] to mail is not delivered if metamta.placeholder-to-recipient is null.Jun 15 2017, 9:23 PM