These are in good shape technically for whatever you want to throw at them.

I think T4100 and design changes elsewhere sharply reduced the need for this, and don't anticipate pursuing it any time soon except perhaps as part of adjacent tasks like T5307 (and maybe T10034 and T4863).

As mentioned in T9775, we think this would be a very useful feature for those of us who need to work on multiple projects. Having it tied to the flags application would make it awesomely customizable (and make Flags a much more useful application).

Might be a good place to integrate PHURL too.

I expected to add additional actions into the header, so it should be easy to do.

@chad, do you have any general ideas on what this might look like offhand? It would be good to get a rough first iteration of a direction while I'm tackling ApplicationEditor since all the "generic batch editor" stuff will happen at some point in that process.

thank you for pointing to
/src/applications/celerity/postprocessor/CelerityHighContrastPostprocessor.php
i've added a new variable $itembg in
CelerityHighContrastPostprocessor.php and CelerityDefaultPostprocessor.php

so maybe just add some expression for $def-bg-color and $def-font-color instead of #fff and #000?

i see that there are some kind of expressions

There is no simple or easy means to supporting or building an inverse theme without some sort of more full featured CSS post processor. We just rely heavily on white and rgba for layering and swapping these colors over would require lots of testing and time to support. The upstream doesn't have any interest in solving these problems. At the end of the day, there will always be more impactful things to build into Phabricator.

Well a dark theme seems to require much more effort than this and be painless to support.
However I think after @epriestley works on high contrast theme, you can do the same as extension., if you want to code it.

the better look

in fact a white background for all texts is a disaster.

i've tried to change config->user interface, but all i got there is a ui.header-color
and in fact a white background for all texts is a disaster.

that's cool

lgtm

Yeah, I think it's very unlikely that we'll require hovering to reveal document hierarchy (or, eventually, parent projects) since two results called "Onboarding" (or, in the future, "Sprint 32") are completely indistinguishable right now. This use case feels much stronger to me as a material usability issue than snippeting.

Thanks for adding me to this issue! Please don't rely on mouseovers/hovering. I want to be able to just look at the results and see which ones are relevant without having to move my mouse.

D14097 reverts this because it felt really bad in production, and generally not very promising as a direction we could iterate on and make successful.

pls revert. pls.

How about we:

I mocked this out and intended to build it into the redesign for PHUIObjectItemListView, but never got to it. A snippet/summary button like GitHub uses. Could be useful here.

I searched for 'self actions' earlier today and that search would be much harder now.

Here's a case where the result feels OK, especially if I'm a new user:

On real data, this feels very bloated to me for tasks, at least:

This doesn't feel completely solid to us yet so we're going to try it out for a bit and see if there are further adjustments to make. We're interested in feedback on this version of the feature if anyone has a particularly positive or negative experience with it. I'll push it to this install shortly so it's available to play around with.

See that diff for some details, here's what it looks like currently:

D14095 is a rough pass at this. I'm summarizing (showing the first ~paragraph of content) rather than showing contextual content around body search results. This is easier and maybe-better, given that our search results are more highly structured than webpages? I'm not sure if this holds up in practice.

If the issue here is that you want to send all of the diff comments in a single email, why not just send those on a timed basis? E.g.: I have submitted a diff, and someone comes to review it. If there's a new comment within 5 minutes (maybe less or more, not sure about the exact time), it doesn't get mailed. If we don't have any new comments for these 5 minutes, all new comments get collected into a single email. No need for comment drafts at all, only maybe you'd have to add a timer under every draft saying that it will get saved in 5 mins, no need to click the Submit button under an empty textarea.

With as much opinions as participants or more, it's important to focus on what user wants to achieve and what Phacility wants to preserve.

I thought I'd mention one other thing, since apparently the holdup on this issue is concerns over Phabricator branding. No-one on our team knows what Phabricator is called—they call it Phacility because that's what's in the URL. Allowing customization of the square icon instead of the "Phabricator" text would resolve that issue.

I got somehow bit by this today... I have only handful "custom policies" and those are quite combination of uers/projects/legal documents etc. In current situation I fully agree with @devurandom: Dialog visible upon clicking "custom policy" should be as descriptive as the on in history - it would make it waay more readable and easy-to-use

this may be covered by the spaces system?

In T4214#128906, @beng wrote:

I strongly recommend a standard panda icon be shipped as a recommended alternate icon.

I strongly recommend a standard panda icon be shipped as a recommended alternate icon.

You can build a Dashboard Panel and embed multiple queries. There isn't current OR functionality.

I want to have a query that list all the diff related to me, including author:me, review:me, subscribe:me. Currently the board doesn't support this query. I can only do author:me AND review:me AND subscribe:me.

+1 to qgil's suggestion. Our logo looks like this:

T7993 is the opposite of this. There are essentially two ways to lay these font icons out, either make them absolutely positioned or make them inline. Both have different drawbacks. Inline icons look more fluid, but they break at the icon when wrapped. Absolute are more predicable and break after the first word, but they can have uneven spacing between the icon and words. For buttons I prefer the more predicable route, and for tags, we go more fluid, though T7993 would maybe disagree. I don't really know any other CSS magic to fix these... maybe tables?

No, it's not meant to be centered. The FontAwesome icons all have varying widths. On buttons they are aligned left, which looks correct in 99% of cases, and wrong on this one case given the icon.

this may be covered by the spaces system?

The visibility of a Space in our Phab instance is using a Custom Policy. When I click the red "Custom Policy" box, I am presented with this text, which does not help me at all:

Users with the "Can View" capability for this object:

Thanks!

In T8755#125710, @chad wrote:

@sitic or @Nikerabbit, are either of you seeing any issues on this install? We haven't had any reports since our last font rebuild so I would like to close this out.

@sitic or @Nikerabbit, are either of you seeing any issues on this install? We haven't had any reports since our last font rebuild so I would like to close this out.

You're welcome to submit a fix, I don't anticipate revisiting this component for some time. For the most part, most icon stacks are aligned on the left edge in Phabricator, but it's not consistent and at some point we have to move on to the next project.

The issue is here as well in Differential, just less noticeable:

The problem is we'd never ship those icons specifically because they are bad choices for visualizing information. If you want to submit a fix, that's fine, but I don't understand why you're asking us to make your UI look better.

The UI is the standard search UI though (with status icons).

It's a custom application (for release management).

I have no idea what UI that is