Page MenuHomePhabricator
Create Task
Maniphest T8755

Rebuild Lato / Roboto Slab fonts packs
Closed, ResolvedPublic
Actions

Description

The Lato we include in the redesign branch looks bad on Windows and Ubuntu from quick testing. We should include all fallback types.

https://driftmgmt.com/blog/design/font-face-typography-best-practices-in-2013/

Browsers with bad line-height in Lato:

FF Mac
Ubuntu anything

Browsers with crappy looking Lato / Roboto Slab:

Windows 8 anything
Ubuntu anything

Revisions and Commits

rP Phabricator
ClosedD13558 Smaller Lato font footprint
D13556rPab7dc13c67fd Rebuild Lato fonts for Firefox
D13553rP5457135951f8 [Redesign] Full Lato font kit
D13552rP4c7208cfa97f [Redesign] Rebuild Roboto Slab

Related Objects

Event Timeline

chad created this task.Jul 4 2015, 6:59 PM
chad renamed this task from Rebuilt Lato fonts to Rebuild Lato / Roboto Slab fonts packs.
chad claimed this task.
chad raised the priority of this task from to Needs Triage.
chad updated the task description. (Show Details)
chad added a project: Design.
chad added subscribers: chad, epriestley.
chad added a revision: D13552: [Redesign] Rebuild Roboto Slab.Jul 4 2015, 8:09 PM
chad added a commit: rP4c7208cfa97f: [Redesign] Rebuild Roboto Slab.Jul 4 2015, 8:16 PM
chad added a revision: D13553: [Redesign] Full Lato font kit.Jul 4 2015, 8:36 PM
chad added a commit: rP5457135951f8: [Redesign] Full Lato font kit.Jul 4 2015, 9:30 PM
chad closed this task as Resolved.Jul 5 2015, 2:40 AM
chad reopened this task as Open.EditedJul 5 2015, 5:14 PM

Not all font packs have resolved the line height issues in some browsers.

chad mentioned this in T8549: Feedback on 2015 Redesign.Jul 5 2015, 5:15 PM
chad updated the task description. (Show Details)
chad added a comment.Jul 5 2015, 6:45 PM

Good news is swapping out to Google's hosted Lato font fixes the issue in my sandbox, but unclear why. At least it seems fixable today. Also found D13555 in the process.

chad added a revision: D13556: Rebuild Lato fonts for Firefox.Jul 5 2015, 7:24 PM
chad added a commit: rPab7dc13c67fd: Rebuild Lato fonts for Firefox.Jul 5 2015, 7:28 PM
chad added a revision: D13558: Smaller Lato font footprint.Jul 6 2015, 3:00 AM
chad mentioned this in rPbdd0e340ff91: Smaller Lato font footprint.Jul 6 2015, 2:17 PM
chad triaged this task as Normal priority.Jul 6 2015, 7:27 PM

Will keep open in case of issues.

chad added a subscriber: Nikerabbit.Jul 7 2015, 1:59 PM
sitic added a subscriber: sitic.Jul 9 2015, 4:05 PM
chad added a comment.Jul 9 2015, 5:03 PM

@sitic or @Nikerabbit, are either of you seeing any issues on this install? We haven't had any reports since our last font rebuild so I would like to close this out.

sitic added a comment.Jul 9 2015, 5:35 PM
In T8755#125710, @chad wrote:

@sitic or @Nikerabbit, are either of you seeing any issues on this install? We haven't had any reports since our last font rebuild so I would like to close this out.

No, the font issues seems to be fixed here.

chad added a comment.Jul 9 2015, 5:36 PM

doctordance

chad added a comment.Jul 9 2015, 5:36 PM

Thanks!

chad closed this task as Resolved.Jul 16 2015, 3:07 PM
Phabricator · Built by Phacility