Page MenuHomePhabricator

PHUITagView icons wrap over newline
Closed, ResolvedPublic

Description

It looks odd to me that the project icon is on a different line to the project name:

hashtag (1×1 px, 204 KB)

Event Timeline

joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added projects: Mobile, Projects.
joshuaspence added a subscriber: joshuaspence.

The options are 1) break the tag or 2) don't break the tag and have overflow hide part of it.

Personally, I felt that (at least in the case of my screenshot) it would be better to push the entire tag to the second line.

If you add nowrap to the tag, it will get cut off by overflow:hidden when the tag is too long for the bounding box, or break the bounding box. This UI is the lesser of two evils.

Particularly after T3670, these might get a lot longer than they are right now in reasonable cases.

We could maybe try to prevent it from breaking between the icon and first word? Not sure if that's practical.

Particularly after T3670, these might get a lot longer than they are right now in reasonable cases.

Specifically, I'm agreeing that overflow: hidden or something else that hides content inside the tag isn't a good fix here.

I think previously these did used to break at the first word, we used to absolutely position the icon, but moved to a more flexible inline icon.

Actually I'm just guessing on that. I really don't know. Obviously the answer is to just make these tables.

I hear CSS4 has white-space: nowrap-first-space-but-wrap-the-rest-normally;.

display: inline-table; mwuahahahaha

chad renamed this task from Hashtags wrap over newline to PHUITagView icons wrap over newline.Apr 30 2015, 11:36 PM
chad edited projects, added PHUI; removed Projects, Mobile.
chad claimed this task.