Page MenuHomePhabricator
Feed Advanced Search

Jun 15 2015

btrahan accepted rP53ef057b1b51: Merge branch 'master' into redesign-2015.
Jun 15 2015, 10:27 PM
btrahan accepted rP0fd0f171f10f: Fix an undeclared property on AphrontPlainTextResponse.
Jun 15 2015, 10:26 PM
btrahan accepted rP069568757242: Fix an undefined property on HarbormasterBuildLogQuery.
Jun 15 2015, 10:26 PM
btrahan accepted rP5878500e1f5e: Fix missing property on PhabricatorYoutubeRemarkupRule.
Jun 15 2015, 10:25 PM
btrahan accepted rPee8de4a9ec55: Fix an issue with `{M13}` and Spaces.
Jun 15 2015, 10:22 PM
btrahan accepted D13299: Fix a fatal in Calendar widget in Conpherence.
Jun 15 2015, 6:49 PM
btrahan accepted D13282: Separate "Revision" and "Diff" fields in Differential.

whatcouldgowrong

Jun 15 2015, 6:49 PM
btrahan accepted D13264: Show spaces in policy explanation dialogs.
Jun 15 2015, 6:38 PM

Jun 12 2015

btrahan added a comment to T4214: Allow installs to change or supplement the "Phabricator" icon.
In T4214#120383, @qgil wrote:

What I didn't explain is that this Phabricator header was one of the most contentious topics among some of our most experienced volunteers and some of my managers too. They were happy to fork the header and assume the cost of maintaining the local code. I calmed the discussion by promising that one day this will be fixed. So yes, communities care about their logos.

PS: if my story encouraged you to lower the priority from Normal to Wishlist, maybe I should have done something different on my Friday afternoon. :)
PS2: The "spooky eye" is not an hypothetical expression, I'm just quoting. In any case, as of today it doesn't compete with the popularity of the "Phabricator" wordmark.

Jun 12 2015, 11:31 PM · Design
btrahan lowered the priority of T4214: Allow installs to change or supplement the "Phabricator" icon from Normal to Wishlist.
In T4214#120376, @qgil wrote:

We call it "Wikimedia Phabricator" and our community talks about "Phabricator". Therefore [Wikimedia logo] + "Phabricator" makes sense, while "[What is this spooky eye?] + "Wikimedia" will create more confusion than the vanilla Phabricator header. I think the perceptions in other communities using Phabricator will be similar. All of them know their own logos, and all of them will recognize "Phabricator".

Jun 12 2015, 4:06 PM · Design
btrahan added a comment to T4214: Allow installs to change or supplement the "Phabricator" icon.

I think that Phabricator should be "white label" software that anyone can take and quickly configure so it looks like it comes 100% from their own organization. That way, new users won't have any idea they are using Phabricator, and will instead think their own organization has some sweet tools, or in the SaaS competitor case, that SaaS competitor A really builds some great software!

Jun 12 2015, 3:15 PM · Design
btrahan accepted D13259: Add a "Subscribers" object policy.
Jun 12 2015, 2:28 PM
btrahan accepted D13258: Add a "Thread Members" object policy and some unit tests.
Jun 12 2015, 2:26 PM

Jun 11 2015

btrahan awarded D13257: Allow PolicyRules to serve as "Object Policies" a Yellow Medal token.
Jun 11 2015, 11:42 PM
btrahan accepted D13257: Allow PolicyRules to serve as "Object Policies".
Jun 11 2015, 11:42 PM
btrahan accepted D13252: Allow different policy rules for different types of objects.
Jun 11 2015, 8:28 PM
btrahan accepted D13251: Add a "template" parameter to application default policies.
Jun 11 2015, 8:23 PM
btrahan accepted rP57b898af9a53: Merge branch 'master' into redesign-2015.
Jun 11 2015, 6:40 PM
btrahan closed T8453: Searching via custom fields doesn't work as Invalid.

See T8516 for the "detect misconfiguration better" task.

Jun 11 2015, 6:24 PM · Custom Fields
btrahan created T8516: Better detect misconfiguration of "options" in custom field.
Jun 11 2015, 6:24 PM · Restricted Project, Custom Fields
btrahan added a comment to T8453: Searching via custom fields doesn't work.

Sorry I raised T8436, as this ticket is focus on search custom field. so I re-open it again as I still can re-repro it on list field, below is my custom field. can u please verify a list field to see if it is fixed, if so I may need to update my code to latest.

"tke:system": { 
     "name": "System", 
      "required": true, 
      "type": "select", 
      "search": true, 
      "copy": true, 
      "options": [ "", "SharePoint", "Agent Appointment", "Agent Registration", "AR Overdue", "Business Travel Approval", "CAPA (Corrective Instruction)", "Cash Advance Approval"]
      }
Jun 11 2015, 6:23 PM · Custom Fields
btrahan accepted D13250: Fix feed query cursor-based pagination on 32-bit systems.
Jun 11 2015, 5:22 PM
btrahan accepted D13249: Support Spaces in Maniphest batch editor.
Jun 11 2015, 5:22 PM
btrahan accepted D13248: Add some documentation for Spaces.
Jun 11 2015, 5:22 PM
btrahan accepted D13247: Support Spaces in ApplicationEmail.
Jun 11 2015, 5:18 PM
btrahan accepted D13246: Use ApplicationTransactions in ApplicationEmail.

One new piece of tech: made it easier for Editors to raise DuplicateKeyException as a normal ValidationException, so callers don't have to handle this case specially.

Jun 11 2015, 5:11 PM
btrahan accepted D13243: Don't show Space monograms in SpaceContextView.
Jun 11 2015, 5:10 PM
btrahan accepted D13242: Implement a "Space is any of..." condition in Herald.
Jun 11 2015, 5:01 PM
btrahan accepted D13238: Allow Spaces to be archived.
Jun 11 2015, 5:00 PM

Jun 10 2015

btrahan accepted D13235: Add a "Description" field to Spaces.
Jun 10 2015, 10:43 PM
btrahan accepted D13232: Support Spaces in Maniphest.
Jun 10 2015, 10:43 PM
btrahan accepted D13231: Support Spaces in Pholio.

Just double checking the images that comprise a mock are also "space'd" properly by this change.

Jun 10 2015, 10:42 PM
btrahan accepted D13229: Improve some Spaces behaviors.
Jun 10 2015, 10:37 PM
btrahan accepted D13239: Don't require users be activated in order to establish Web sessions.
Jun 10 2015, 10:33 PM

Jun 9 2015

btrahan added a comment to T8485: conpherence makes it hard to see all active conversations.

Can you take a step back and explain a bit more how you and your team is using Conpherence? Basically, I'm trying to understand how come there are so many active threads at once for an individual and what the nature of these threads is...?

Jun 9 2015, 9:16 PM · Conpherence
btrahan accepted D13227: Make "Order By" field render correctly when showing a SavedQuery with an order alias.
Jun 9 2015, 8:48 PM
btrahan committed rP0fab38e0229d: Conpherence - fix default widget on main Conpherence view. (authored by btrahan).
Conpherence - fix default widget on main Conpherence view.
Jun 9 2015, 8:48 PM
btrahan closed T8489: conpherence widget column defaults to Settings instead of Participants as Resolved by committing rP0fab38e0229d: Conpherence - fix default widget on main Conpherence view..
Jun 9 2015, 8:47 PM · Conpherence
btrahan closed D13228: Conpherence - fix default widget on main Conpherence view. by committing rP0fab38e0229d: Conpherence - fix default widget on main Conpherence view..
Jun 9 2015, 8:47 PM
btrahan added a comment to T8489: conpherence widget column defaults to Settings instead of Participants.

This is just a regression caused by D13058.

Jun 9 2015, 8:47 PM · Conpherence
btrahan retitled D13228: Conpherence - fix default widget on main Conpherence view. from to Conpherence - fix default widget on main Conpherence view..
Jun 9 2015, 8:46 PM
btrahan added a revision to T8489: conpherence widget column defaults to Settings instead of Participants: D13228: Conpherence - fix default widget on main Conpherence view..
Jun 9 2015, 8:46 PM · Conpherence
btrahan accepted D13226: Fix "unmarked 0 inline comments as not undone" transactions.
Jun 9 2015, 8:30 PM
btrahan added a comment to T8478: Loading Conpherence handles may recurse indefinitely.

But how will you get SEV0 bugs if you don't dabble in infinite recursion?

Jun 9 2015, 7:58 PM
btrahan added a comment to D13219: Desktop Notification support.

It looks like the site only gets to send one desktop notification at a time?

Jun 9 2015, 7:28 PM
btrahan planned changes to D13219: Desktop Notification support.

Taking it out of your queue for now.

Jun 9 2015, 7:08 PM
btrahan added a comment to T8487: Link in Documentation Does Not Exist.

Oh whoops, I guess I took awhile to submit that comment and missed the update notification. :/

Jun 9 2015, 6:58 PM · Documentation
btrahan added a comment to T8487: Link in Documentation Does Not Exist.

That is an example URI and would be different for your Phabricator installation. For example, for this installation, https://phabricator.example.com/oauthserver/client/create/ is https://secure.phabricator.com/oauthserver/client/create/

Jun 9 2015, 6:57 PM · Documentation
btrahan triaged T8488: Remove "room" vs "message" distinction as Normal priority.
Jun 9 2015, 6:54 PM · Conpherence
btrahan added a subtask for T8488: Remove "room" vs "message" distinction: T5681: Allow applications to provide custom policy rules.
Jun 9 2015, 6:53 PM · Conpherence
btrahan added a parent task for T5681: Allow applications to provide custom policy rules: T8488: Remove "room" vs "message" distinction.
Jun 9 2015, 6:53 PM · FreeBSD, Policy
btrahan moved T8488: Remove "room" vs "message" distinction from Backlog to v3 on the Conpherence board.
Jun 9 2015, 6:53 PM · Conpherence
btrahan accepted D13225: Use SearchFields in Maniphest.
Jun 9 2015, 6:51 PM
btrahan added a comment to T8485: conpherence makes it hard to see all active conversations.

Just filed T8488 which may make this better.

Jun 9 2015, 6:47 PM · Conpherence
btrahan added a comment to T8488: Remove "room" vs "message" distinction.

Submitted that a bit early. Basically I think the distinction here is adding some confusion. Very very open for discussion. :D

Jun 9 2015, 6:41 PM · Conpherence
btrahan updated the task description for T8488: Remove "room" vs "message" distinction.
Jun 9 2015, 6:40 PM · Conpherence
btrahan created T8488: Remove "room" vs "message" distinction.
Jun 9 2015, 6:37 PM · Conpherence
btrahan added a comment to T8485: conpherence makes it hard to see all active conversations.

See also T7589, which for the durable column plans to improve the recent room / messages switcher.

Jun 9 2015, 3:27 PM · Conpherence
btrahan closed T8485: conpherence makes it hard to see all active conversations as Invalid.

This is again by design. @chad - please note this task.

Jun 9 2015, 3:12 PM · Conpherence
tycho.tatitscheff awarded D13219: Desktop Notification support a Baby Tequila token.
Jun 9 2015, 2:34 PM
sshannin awarded D13219: Desktop Notification support a Evil Spooky Haunted Tree token.
Jun 9 2015, 1:32 PM
btrahan accepted D13220: Try using a less-rich but less-risky thread title in Conpherence handles.
Jun 9 2015, 2:09 AM
btrahan updated subscribers of T8478: Loading Conpherence handles may recurse indefinitely.

That sounds fine to me, but I think I iterated to @chad's dream state... I actually think we used to have "(No Title)" or something for a time...

Jun 9 2015, 12:32 AM
btrahan updated D13219: Desktop Notification support.
Jun 9 2015, 12:28 AM
btrahan added a comment to D13219: Desktop Notification support.

Screen Shot 2015-06-08 at 5.26.28 PM.png (414×914 px, 135 KB)

Jun 9 2015, 12:25 AM
btrahan added a task to D13219: Desktop Notification support: T4139: Add support for desktop notifications.
Jun 9 2015, 12:23 AM
btrahan added a revision to T4139: Add support for desktop notifications: D13219: Desktop Notification support.
Jun 9 2015, 12:23 AM · Aphlict

Jun 8 2015

btrahan added a comment to D13218: Don't try to generate a CSRF token for the omnipotent user.

Jun 8 2015, 11:15 PM
btrahan accepted D13218: Don't try to generate a CSRF token for the omnipotent user.
Jun 8 2015, 11:02 PM
btrahan accepted D13217: Fix an issue with adding or updating images in unified diff view.
Jun 8 2015, 10:39 PM
btrahan accepted D13216: Don't load attached files for profile images.
Jun 8 2015, 10:39 PM
btrahan accepted D13215: Stop "join project" from trying to write an inverse edge on Users.
Jun 8 2015, 9:44 PM
btrahan added a comment to T6713: Adding a comment to a conpherence sometimes duplicates the message in the UI.

Thanks for the persistence @sshannin. :D

Jun 8 2015, 9:17 PM · Transactions, Conpherence
btrahan committed rP818fcf00350a: Conpherence - fix durable column message duplicating bug (authored by btrahan).
Conpherence - fix durable column message duplicating bug
Jun 8 2015, 9:12 PM
btrahan closed T6713: Adding a comment to a conpherence sometimes duplicates the message in the UI as Resolved by committing rP818fcf00350a: Conpherence - fix durable column message duplicating bug.
Jun 8 2015, 9:12 PM · Transactions, Conpherence
btrahan closed T6713: Adding a comment to a conpherence sometimes duplicates the message in the UI, a subtask of T7571: Conpherence v2 Errata, as Resolved.
Jun 8 2015, 9:12 PM · Conpherence
btrahan closed D13214: Conpherence - fix durable column message duplicating bug by committing rP818fcf00350a: Conpherence - fix durable column message duplicating bug.
Jun 8 2015, 9:12 PM
btrahan retitled D13214: Conpherence - fix durable column message duplicating bug from to Conpherence - fix durable column message duplicating bug.
Jun 8 2015, 9:11 PM
btrahan added a revision to T6713: Adding a comment to a conpherence sometimes duplicates the message in the UI: D13214: Conpherence - fix durable column message duplicating bug.
Jun 8 2015, 9:11 PM · Transactions, Conpherence
btrahan accepted D13213: Implement PhabricatorApplicationTransactionInterface on PhabricatorUser.
Jun 8 2015, 8:12 PM
btrahan added a comment to T8453: Searching via custom fields doesn't work.

(confirmed did not repro when I made another new task either)

Jun 8 2015, 7:06 PM · Custom Fields
btrahan closed T8453: Searching via custom fields doesn't work as Invalid.

Repro'd for me then I edited the field and it didn't repro anymore. Maybe I had a daemon error or something, or all the changes here fixed it?

Jun 8 2015, 7:05 PM · Custom Fields
btrahan added a comment to T8453: Searching via custom fields doesn't work.

I'm updating my instance but will confirm it still repros when its back up

Jun 8 2015, 7:02 PM · Custom Fields
btrahan added a comment to T8453: Searching via custom fields doesn't work.

{"mycompany:estimated-hours": {"name": "Estimated Hours", "type": "int", "caption": "Estimated number of hours this will take.", "search" : true}}

Jun 8 2015, 7:01 PM · Custom Fields
btrahan updated the task description for T8453: Searching via custom fields doesn't work.
Jun 8 2015, 7:00 PM · Custom Fields
btrahan moved T8468: No conpherence user documentation from Backlog to Future on the Conpherence board.
Jun 8 2015, 6:48 PM · Documentation, Conpherence
btrahan accepted D13197: Drive Maniphest grouping and ordering through standard infrastructure.
Jun 8 2015, 6:44 PM
btrahan accepted D13195: Convert Harbormaster Build Plans to SearchField.
Jun 8 2015, 6:42 PM
btrahan accepted D13196: Move Repositories to SearchField.
Jun 8 2015, 6:42 PM
btrahan accepted D13194: Convert Macro to SearchFields.
Jun 8 2015, 6:39 PM
btrahan accepted D13193: Support ordering in SearchField.
Jun 8 2015, 6:37 PM
btrahan added inline comments to D13190: Move People to SearchFields.
Jun 8 2015, 6:36 PM
btrahan accepted D13191: Make Subscribers automatically provide working SearchFields.
Jun 8 2015, 6:34 PM
btrahan awarded D13191: Make Subscribers automatically provide working SearchFields a Haypence token.
Jun 8 2015, 6:34 PM
btrahan accepted D13190: Move People to SearchFields.
Jun 8 2015, 6:28 PM
btrahan accepted D13189: Move Projects to SearchFields.
Jun 8 2015, 6:26 PM
btrahan awarded D13206: Apply Herald subscription effects immediately a Piece of Eight token.
Jun 8 2015, 5:47 PM
btrahan accepted D13206: Apply Herald subscription effects immediately.
Jun 8 2015, 5:47 PM
btrahan accepted D13210: Fix an issue with mention transactions in Calendar.

That mfilter() pattern is (was?) in many an editor me thinks...

Jun 8 2015, 5:46 PM
btrahan added a comment to T8469: Hard to find New Room workflow.

I'm not saying its the best design in the world, just that it was intentional. Also, this install would have tons of junk rooms if it was as easy to make as a message, and I don't think enough value would have been created to offset all that spam / giant junk listing of rooms to wade through for all users for all time. This is just this install though and maybe frequently creating new rooms / making sure new users know how to make more than one room first thing right away is important.

Jun 8 2015, 5:15 PM · Conpherence