Page MenuHomePhabricator
Differential D13217

Fix an issue with adding or updating images in unified diff view
ClosedPublic
Actions

Authored by epriestley on Jun 8 2015, 10:07 PM.
Tags
None
Referenced Files
F19017474: D13217.id31951.diff
Sun, Nov 23, 8:04 AM
F18822282: D13217.id.diff
Oct 23 2025, 5:34 AM
F18822031: D13217.diff
Oct 23 2025, 3:42 AM
F18784616: D13217.id.diff
Oct 13 2025, 1:36 PM
F18498320: D13217.diff
Sep 4 2025, 6:36 PM
F18080470: D13217.id31953.diff
Aug 4 2025, 9:51 PM
F18040534: D13217.id31951.diff
Aug 3 2025, 4:07 AM
F17943468: D13217.diff
Jul 31 2025, 8:24 AM
View All Files
Subscribers
epriestley
Tokens
"Grey Medal" token, awarded by joshuaspence.

Details

Reviewers
btrahan
Maniphest Tasks
T8069: Exception: Argument 1 passed to DifferentialChangesetHTMLRenderer::renderImageStage()
Commits
Restricted Diffusion Commit
rP929f5f22acef: Fix an issue with adding or updating images in unified diff view
Summary

Fixes T8069.

Test Plan

Viewed a new image in unified diff view.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 31951.Jun 8 2015, 10:07 PM
epriestley retitled this revision from to Fix an issue with adding or updating images in unified diff view.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8069: Exception: Argument 1 passed to DifferentialChangesetHTMLRenderer::renderImageStage().
Herald added a subscriber: epriestley. · View Herald TranscriptJun 8 2015, 10:07 PM
btrahan accepted this revision.Jun 8 2015, 10:39 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 8 2015, 10:39 PM
Closed by commit rP929f5f22acef: Fix an issue with adding or updating images in unified diff view (authored by epriestley, committed by epriestley). · Explain WhyJun 8 2015, 10:40 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence awarded a token.Jun 8 2015, 11:01 PM

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
render/
2 lines

Diff 31953

View Options

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

Loading...
Phabricator · Built by Phacility