Page MenuHomePhabricator

Improve some Spaces behaviors
ClosedPublic

Authored by epriestley on Jun 9 2015, 11:48 PM.
Tags
None
Referenced Files
F14060434: D13229.diff
Mon, Nov 18, 1:13 AM
F14045969: D13229.diff
Wed, Nov 13, 4:41 PM
F14037216: D13229.diff
Sun, Nov 10, 2:23 PM
F14021810: D13229.diff
Wed, Nov 6, 12:11 PM
F14021206: D13229.id31977.diff
Wed, Nov 6, 6:23 AM
F13970437: D13229.diff
Oct 17 2024, 7:42 AM
Unknown Object (File)
Oct 13 2024, 9:49 AM
Unknown Object (File)
Oct 10 2024, 3:24 AM
Subscribers

Details

Reviewers
btrahan
chad
Maniphest Tasks
T8449: Spaces v1 Errata
Commits
Restricted Diffusion Commit
rP739bdeccabe7: Improve some Spaces behaviors
Summary

Ref T8449. Try out some more subtle behaviors:

  • Make the "Space" control part of the policy control, so the UI shows "Visible To: [Space][Policy]". I think this helps make the role of spaces more clear. It also makes them easier to implement.
  • Don't show the default space in headers: instead, show nothing.
  • If the user has access to only one space, pretend spaces don't exist (no edit controls, no header stuff).

This might be confusing, but I think most of the time it will all align fairly well with user expectation.

Test Plan
  • Viewed a list of pastes (saw Space with non-default space, no space with default space, no space with user in only one space).
  • Viewed a paste (saw Space with non-default space, saw no space with default space, saw no space with user in only one space).
  • Edited spaces on objects (control as privileged user, no control as locked user).
  • Created a new paste in a space (got space select as privileged user, no select as locked user).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve some Spaces behaviors.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 10 2015, 10:37 PM
This revision was automatically updated to reflect the committed changes.