Drive Maniphest grouping and ordering through standard infrastructure
ClosedPublic
Actions

Authored by epriestley on Jun 7 2015, 9:14 PM.

Details

Reviewers

Maniphest Tasks

T7909: Allow ascending order for Conduit's maniphest.query's "order" parameter (order-created, order-modified)
T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch
T8441: Integrate Spaces into ApplicationSearch

Commits

Restricted Diffusion Commit
rP1a091e526047: Drive Maniphest grouping and ordering through standard infrastructure

Summary

Ref T8441. Ref T7715. Ref T7909. Clean up all the ordering and grouping hacks in Maniphest so we can drive it through normal infrastructure, move it to SearchField, introduce Spaces, and eventually modernize the Conduit API.

Test Plan

Executed all grouping/ordering queries, including custom queries.
Forced execution with old aliases; got modern results.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 31887.Jun 7 2015, 9:14 PM

epriestley retitled this revision from to Drive Maniphest grouping and ordering through standard infrastructure.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T8441: Integrate Spaces into ApplicationSearch, T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch, T7909: Allow ascending order for Conduit's maniphest.query's "order" parameter (order-created, order-modified).

Herald added a subscriber: epriestley. · View Herald TranscriptJun 7 2015, 9:14 PM

btrahan accepted this revision.Jun 8 2015, 6:44 PM

btrahan edited edge metadata.

btrahan added inline comments.

resources/sql/autopatches/20150504.symbolsproject.1.php
14–17	que?

This revision is now accepted and ready to land.Jun 8 2015, 6:44 PM

epriestley added inline comments.Jun 8 2015, 6:50 PM

resources/sql/autopatches/20150504.symbolsproject.1.php
15	Oh -- I think this is from a diff 1-2 diffs back, but RepositoryQuery wasn't strict about `withIDs(array())` and would just load everything. I made it strict, but that caused `execute()` on 21 to start failing with an empty array.