Differential D13206

Apply Herald subscription effects immediately
ClosedPublic
Actions

Authored by epriestley on Jun 8 2015, 1:51 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 3, 6:58 PM

	Unknown Object (File)
	Thu, Nov 28, 7:07 PM

	Unknown Object (File)
	Mon, Nov 25, 5:49 AM

	Unknown Object (File)
	Thu, Nov 21, 1:40 PM

	Unknown Object (File)
	Thu, Nov 21, 10:30 AM

	Unknown Object (File)
	Thu, Nov 21, 10:30 AM

	Unknown Object (File)
	Thu, Nov 21, 10:29 AM

	Unknown Object (File)
	Thu, Nov 21, 10:09 AM

Subscribers

Tokens

"Piece of Eight" token, awarded by btrahan.

Details

Reviewers

Maniphest Tasks

T8464: Herald "subscribe" rules do not take effect immediately, skipping mail about the first transaction

Commits

Restricted Diffusion Commit
rPc3b11439f281: Apply Herald subscription effects immediately

Summary

Fixes T8464. We could incorrectly use a cached value when computing CC's.

Just load a fresh value. There are no other callers that would benefit from this cache, so it's more complicated to reload it correctly prior to publishing than to just skip it.

Also make the PHID headers unique.

Test Plan

Verified that users received mail about the transactions which caused them to be added to an object.
Veirfied that headers no longer have redundant values.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 31909.Jun 8 2015, 1:51 PM

epriestley retitled this revision from to Apply Herald subscription effects immediately.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8464: Herald "subscribe" rules do not take effect immediately, skipping mail about the first transaction.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 8 2015, 1:51 PM

btrahan accepted this revision.Jun 8 2015, 5:47 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 8 2015, 5:47 PM

btrahan awarded a token.Jun 8 2015, 5:47 PM

Closed by commit rPc3b11439f281: Apply Herald subscription effects immediately (authored by epriestley, committed by epriestley). · Explain WhyJun 8 2015, 5:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

metamta/

storage/

PhabricatorMetaMTAMail.php

1 line

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

9 lines

Diff 31926

src/applications/metamta/storage/PhabricatorMetaMTAMail.php

Loading...

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...